This is mostly a discussion/question dev-side and not really user-side, hope it's okay.

I noticed sodium-fabric#445 and saw:

I will accept a closed issue and punt back to my side and use MethodHandles. Wanted to send over what I knew.

Being curious as I am I looked at Fabrication's access widener and got quite surprised as in Fabric's wiki it's something really unrecommended to use and only for like inner classes case, or cases in which mixins cannot help.

I can understand why MethodHandles are really not a good solution, though I was wondering, for methods, why not use Invokers? They would solve the visibility issue, should cost less performance-wise than MethodHandle, the only thing that can be annoying is the casting of the Minecraft's object as a duck-interface.

Here's a link on Invoker usage if needed: https://github.com/2xsaiko/mixin-cheatsheet/blob/master/invoker.md

The only way to quickly get rid of cobwebs is by the sword. It a spider's web...why it can't burn?

Split off from #3

Makes walking through berry bushes not hurt when you're wearing leggings
Goes along with cactus_walk_doesnt_hurt_with_boots
Admittedly this mod already exists for fabric, but i like my tweaks consolidated when possible, since downloading 30 mods for tiny individual tweaks is annoying, just figured it would fit well with existing functionality

Minecraft: Java Edition and Legacy Console Edition both include an unused Giant mob. You can read about it and its history on the official Minecraft wiki article, but, essentially, it is an almost twelve block tall zombie with drastically inflated hit points and damage. It cannot spawn due to not appearing in any biome's spawn lists and needing to meet the impossible spawn condition of a light level over 11 and below 8, and, although it can be spawned with /summon, it has no AI ever since snapshot 14w06a. 18w50a gave the giant AI, sounds and everything needed for it to function as a copy of the zombie that moves twice as fast, but this was scrapped again in 19w05a. Again, the precise details of this implementation of it are on the page above, in the History section.

As a niche/joke option, I would like a tweak that restores the giant to its functional state from 18w50a, and allows it to spawn rarely in the overworld by adding it to biome spawn lists and making its spawn conditions possible to meet. It may need a loot table for rotten flesh drops as well; the wiki doesn't mention whether the snapshot gave it one. Naturally, its size would keep it out of most caves and forested biomes, so it may only appear to ravage empty biomes such as plains or deserts.

As additional features, one could be summoned by the zombie siege event that occurs in villages, and they could be allowed to spawn with armour or an iron shovel or sword with the same chance as zombies, or perhaps a greater chance to spawn with rarer types to reward fighting them.~

The game crashes on boot when OptiFine is used with Fabrication.

Versions used are: MineCraft 1.16.4, Fabric 10.8, FabricAPI 0.29.3, OptiFine G6 pre10, OptiFabric 1.8.16, Fabrication 1.2.9.

Crash Report: crash.txt
Log from GDLauncher: log_gdl.log
Log from MineCraft: log_mc.log

why vanilla only protecc nethr star smh

Split off from #3

Makes touching a cactus not hurt when you're wearing a chestplate
Goes along with cactus_walk_doesnt_hurt_with_boots

After installing this mod and activating many features, entered a singleplayer world to do some testing.

After a while, I paused then unpaused, and all mobs ceased movement, and everything just stopped working.
Checking the MultiMC console, i recieved the following messages despite being on a singleplayer world:
[15:57:31] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 130486ms or 2609 ticks behind
[15:58:37] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 51161ms or 1023 ticks behind
[15:59:06] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 13959ms or 279 ticks behind
with no other error messages, unfortunately.
So something, after installing just this mod, caused even a singleplayer world to almost completely cease ticking.
Had to kill the instance since the world wouldn't save and quit. Unknown cause- bad mod interactions maybe?
I'll have to do more testing. In the meantime just thought I'd bring it to your attention in case you may have any ideas.

Singleplayer mod list for reference:
(Yes, I know Optifine is terrible, and Optifabric is unsupported, but unfortunately, I require it for most of the features of my resource packs to function, as there are no alternatives for many of the features. Also OF is clientside so it shouldn't be causing this if it's an interaction with the mod?... I think?)
accurate-block-placement-1.0.7.jar
appleskin-mc1.16-fabric-1.0.11.jar
borderless-mining-1.0.6+1.16.2.jar
cleancut-mc1.16-2.1-fabric.jar
clear-skies-mc116-1.5.48.jar
cleardespawn-1.16.2-fabric0.17.2-1.1.1.jar
CompactStatusEffects-1.2.2.jar
darkness-mc116-1.6.50.jar
DynamicSoundFilters-1.1.3+1.16.2.jar
EnchantedToolTips-1.3.4-1.16.jar
Fabric-1.16.3-TillItBreaks-0.1.jar
fabric-api-0.24.1+build.412-1.16.jar
fabric-language-kotlin-1.4.0+build.1.jar
fabrication-1.0.2.jar
horse-stats-vanilla-4.1.4.jar
i-am-very-smart-2.1.0+mc1.16.1.jar
illuminations-1.2.2.jar
light-overlay-5.5.3.jar
lock_minecart_view-for-MC1.16.2-1.2.1.jar
microDurability-0.2.0+1.16.3.jar
modlist.txt
modmenu-1.14.6+build.31.jar
mousewheelie-1.5.7+mc1.16.2-pre1.jar
nightvisionflashbegone-1.0.0.jar
nomoreglowingpots-1.0.2.jar
optifabric-1.6.4.jar
OptiFine_1.16.3_HD_U_G3.jar
phosphor-fabric-mc1.16.1-0.6.0+build.7.jar
potiondescriptions-1.16.3-fabric-1.0.0.jar
PresenceFootsteps-r28+1.16.2.jar
RoughlyEnoughItems-5.6.1.jar
slight-gui-modifications-1.4.0.jar
stepup-1.16.2-fabric0.17.2-1.1.jar
tooltipfix-1.0.2-1.16.jar
torohealth-1.16.3-fabric-1.jar
XaerosWorldMap_1.11.0_Fabric_1.16.3.jar
Xaeros_Minimap_20.26.0_Fabric_1.16.3.jar
[1.16.2]bettermodbutton-1.1.4.jar

When the item despawn rules are enabled and with the following section:

[@tags.minecraft:]
shulker_boxes=invincible

The stackable shulker boxes rule from gnembon/fabric-carpet fails to stack shulker boxes that are on the ground.
Disabling the item despawn rules allows the stackable shulker boxes to work properly again.

I assume this is caused by how Fabrication modifies NBT tags on the present items, but I'm unsure what would cause them to not stack with others under the relevant rule. Does the mod mess with the item itself in any way other than NBT tags?

If there is nothing that can be changed about this from Fabrication's side, I can go ahead and open an issue on the Fabric Carpet repository.

Split off from #3

Would it be possible to change the particles used for dripping? current ones hang in the air too long and can be annoying in first-person view. alternatively, disable them from showing in first person at least.

Sync Attacker Yaw seems to stop working (goes back to default behavior) after player dies

Mods:

• fabric api
• lithium
• starlight
• fabrication (obviously)
• overworld two

I am using Java 15 OpenJ9 (but I doubt that would be the problem)

I use a datapack to debuff natural health regeneration and to add a little health regen after sleeping so I use bed frequently. I would like the phantoms to spawn even when a player was sleeping the previous night.

Photoallergic creepers - something for those who want the days to be completely safe.
Why do zombies burn in daylight? I don't know too. This is the only game where zombies won't like sun. Why aren't they called vampires then?

presuming this is a hardcoded list right now
would be nice to have this configured for a proper modded context, like Tech Reborn's gem tools

the config gui specifically mentions not wanting to use datapacks, but maybe it could use the system you've written for the mod already?

four unused sound effects are currently still in the game; ghast affectionate scream, wolf howl, player breath, and silverfish step. my ideas on the usage of these four sounds would be for the affectionate scream to happen while a ghast is in the overworld, the howl would be made from wild wolfs at night, the silverfish is kinda obvious it would happen when a silverfish moves, and the player breath maybe when the player gets out of water after almost drowning.

I would like to see a tweak to force banner patterns applied to shields to render at their full resolution, as seen on the banner block itself, instead of the weird half resolution used on vanilla shields, which makes most banner patterns look ugly.

This resource pack fixes this issue and adds other features as well. However, reading through previous reports, I understand that you would like Fabrication/Forgery to be a one stop shop for fixes and tweaks, and that you aren't afraid of fixing things that other mods fix to assert this.

Crash on startup with both Fabrication and KubeJS, both mods work fine individually. I have no idea how to read those particular errors but Fabrication is the one who appears in the error so that's where I'm reporting.

Minecraft - 1.16.4
Fabric API - 0.25.1
Fabrication - 1.2.2
KubeJS Fabric - 1.6.0
Rhino - 1.7.13.7

The log file gets cut off before the exception so here's the copied MultiMC log (so it has extra stuff at the top) : https://gist.github.com/Lykrast/47aec9660a9c013cb698222ef60f82d9

Shulkerboxes with Fire Protection still burns after placing down and picking up, rendering them kinda useless.
However it seems like this could potentially be a feature quite hard to implement, if that's so then just implement to shulkerboxes or a limited set of blocks

I find gold_tools_useful_in_nether to have some interesting potential for modpack development: for example, players can have the choice to start in the Nether or in the Overworld, and the tools that they have available naturally specialize them to life in their respective environments and encourage trading.

I would like to request an extension of this functionality by allowing one to add tools to new fabrication:end_blocks and fabrication:end_blocks_only_in_end tags that deal 50x durability damage to tools not in a fabrication:end_tools tag. This would be useful in mod packs that add new biomes and tool types to the End to make it a viable starting location; without these mods, of course, it would be useless, save for the niche use in making some weird tool super effective against End blocks in vanilla.

In addition to this, as many mods such as Better End or BYG that would be used in such a modpack add new wood or stone types that create the default wooden or stone tools, a tag similar to the 'fungal' tag that modpack creators could apply to wooden or stone tools crafted with these wood/stone types would be appreciated. They could be named 'End Wooden ___' or 'End Stone ___' for widespread compatibility with different material types.~

Split off from #3

Makes campfires get placed un-lit, requiring you to light them with a flint and steel to use them
Would be great for builders since many use unlit campfires for decorations/awnings/roofing and need to throw splash bottles or bring a shovel everywhere. In general i find more unlit fires are used than lit fires for building

Split off from #3

Also allow applying infinity to crossbows, maybe as a seperate option. may require some tweaking if implemented, as another mod that does so has some issues with the implementation which have yet to be addressed

Sometimes when jumping into the void you will get teleported to the surface and take 1 tick of void damage then die, even if at full health. This will put your items at the surface, but won't allow you to live. This is somewhat inconsistent,

When attempting to void jump in the end you fall out of the world and it doesn't teleport you at all.

Split off from #3

Allows you to right click with any item enchanted with fire aspect to function like a flint and steel, including slight durability damage
Bedrock edition has this functionality to an extent (at least allowing lighting campfires this way, unsure about other blocks)
not sure if this is doable within the scope of this mod or if too heavy tweaks would be required

Pretty self explanatory.
Allow effect levels to work with Boundless Levels.

Split off from #3

Makes exp gain apply to all items with Mending, at a reduced rate, instead of choosing only one item to mend per exp gain
other mods do similar things, admittedly, but all that i've found are either Forge or client+server, when I'm sure this could be made just a serverside tweak like other enchant tweaks... unless i'm wrong, in which case, ignore this.

To go with enchanted_item_long_despawn, it would be nice if certain special items (based on a whitelist?) could also be set to despawn later. Something that comes up in my mind right away is a shulker box, as it could contain any number of enchanted items itself.

I've found it frustrating on multiple occasions that dyeing sign text is usually impractical because the text colours are dark and difficult to read on most sign types. It's also frustrating that white text appears grey, pink appears almost purple...

I would like to suggest a legible_signs tweak that makes two changes to sign text:

• Increase the brightness of the sign text colours so they actually match their dyes. No more "white" text appearing as grey.
• Give coloured sign text a shadow like the menu button font has, to separate the text from the background and make the text easier to distinguish and read.

latest.log
This is the most concerning crash log I've ever acquired

basically in the title. tested on katplanet, d/ced from server and entered/re-entered nether to try to see if it was a problem with syncing to the client

Split off from #3

Makes anvils unable to be damaged just by using them, only taking damage when they fall from a high height
it just makes sense, since no other crafting station gets damaged from use, it's just weird

The option gold_tools_useful_in_nether adds an nbt tag to wooden tools produced from crimson or warped planks to allow them to evade the 50x durability penalty, as they are made from a Nether substance. This is good! However, stone tools can be made from blackstone, and they do not recieve a similar tag. Adding a tag to the tools produced by these blackstone recipes that gives them this boon and renames them to 'Blackstone ___' would be appreciated.~

discovered by @deli73
Fabrication version 1.2.3_01

Expected:
Upon entering the return portal from the end and watching/skipping the credits, you should return to your spawnpoint with all your experience and items.

Actual behavior:
Upon entering the return portal from the end and watching/skipping the credits, you return to your spawnpoint with all your items but none of your experience.

Possible cause:
The end return portal calls respawn methods to return you to your spawn point. The lose-xp-on-death feature may not be properly detecting that a respawn is due to end return portal usage and resetting player XP anyway.

Similar to my previous suggestion in #39, I would like to see a tweak to enable tools that are a part of nether_tools or, if #39 is accepted, end_tools not tagged with a new fabrication:overworld_tools tag to suffer 50x durability damage when mining blocks native to the Overworld- that is, blocks added to new fabrication:overworld_blocks or fabrication:overworld_blocks_only_in_overworld blocks tags, just as how the gold_tools_useful_in_nether tweak penalizes using non-Nether tools on Nether blocks. This would be a niche option for modpack creators, or just anyone looking for specialization-based tool mechanics.~

Edit: Edited proposed solution to use a new fabrication:overworld_tools tag to make tools exempt from the durability penalty instead of applying the penalty to anything in fabrication:nether_tools or, if #39 is accepted, fabrication:end_tools. This way, a tool can be considered as being appropriate for both the Overworld and one or both other dimensions by adding it to multiple tags. In the previous proposed solution, that would not be possible.

Split off from #3, though multiple people have requested this.

Makes Phantoms spawn in all End biomes aside from "The End" (the central island's biome) to provide a proper way to acquire Phantom Membranes when doInsomnia gamerule is false.
All other mods that do this either add entirely new "End Phantom" mobs, making it less of a spawn tweak and more of an entirely new mob mod, or are Forge-only. honestly was trying to figure out how to do this myself but i can't wrap my head around fabric, am too rusty with Java.

I would be nice if we could change the config the the Mod Menu.

First off, it'd be great if the config could be made ModMenu compatible. As an INI I'm not sure if that's doable? But it would be great for convienience. Anyhow...

=better_pause_freezing
BUG: if tabbed out while a world loads, causing the game to immediately pause when the world is loaded, pause menu does not appear and it looks like the game is frozen. Escape can still be pressed to close the pause menu, however.

=enhanced_moistness
TWEAK: would it be possible to change the particles used for dripping? current ones hang in the air too long and can be annoying in first-person view. alternatively, disable them from showing in first person at least.
SUGGESTION: make splash and lingering water bottles de-aggro enderman who touch their area much like when they touch normal water/rain/etc.

=enchanted_item_long_despawn:
TWEAK: do not apply to items that only have curses, as those can't be removed with a grindstone, so if you want to just toss them and let them despawn, it'd be nice to not have them linger around too long. Besides, does anyone really want to pick up that Curse of Vanishing Stone Sword they got from a chest?

=infibow:
SUGGESTION: also allow applying infinity to crossbows, maybe as a seperate option. may require some tweaking if implemented, as another mod that does so has some issues with the implementation (OnyxStudios/InfinityFix#4) which have yet to be addressed

SUGGESTION:
+cactus_brush_doesnt_hurt_with_chest

makes touching a cactus not hurt when you're wearing a chestplate
goes along with cactus_walk_doesnt_hurt_with_boots

SUGGESTION:
+bush_walk_doesnt_hurt_with_legs

makes walking through berry bushes not hurt when you're wearing leggings
goes along with cactus_walk_doesnt_hurt_with_boots
admittedly this mod already exists for fabric, but i like my tweaks consolidated when possible, since downloading 30 mods for tiny individual tweaks is annoying, just figured it would fit well with existing functionality

SUGGESTION:
+mending_affects_all

makes exp gain apply to all items with Mending, at a reduced rate, instead of choosing only one item to mend per exp gain
other mods do similar things, admittedly, but all that i've found are either Forge or client+server, when I'm sure this could be made just a serverside tweak like other enchant tweaks... unless i'm wrong, in which case, ignore this.

SUGGESTION:
+anvil_damage_only_on_fall

makes anvils unable to be damaged just by using them, only taking damage when they fall from a high height
it just makes sense, since no other crafting station gets damaged from use, it's just weird

SUGGESTION:
+anvil_repair_with_iron

allows you to repair anvils using Iron Blocks
cheaper than making an entirely new anvil each time it breaks, since anvils only have 2 stages of damage to repair, so 2 blocks instead of the normal 3.44 blocks
a nice alternative to the comparatively balance-altering above tweak

SUGGESTION:
+phantoms_spawn_in_end

makes Phantoms spawn in all End biomes aside from "The End" (the central island's biome) to provide a proper way to acquire Phantom Membranes when doInsomnia gamerule is false.
all other mods that do this either add entirely new "End Phantom" mobs, making it less of a spawn tweak and more of an entirely new mob mod, or are Forge-only. honestly was trying to figure out how to do this myself but i can't wrap my head around fabric, am too rusty with Java.

SUGGESTION:
+campfires_place_unlit

makes campfires get placed un-lit, requiring you to light them with a flint and steel to use them
would be great for builders since many use unlit campfires for decorations/awnings/roofing and need to throw splash bottles or bring a shovel everywhere. in general i find more unlit fires are used than lit fires for building

SUGGESTION:
+fire_aspect_lights_fires

allows you to right click with any item enchanted with fire aspect to function like a flint and steel, including slight durability damage
Bedrock edition has this functionality to an extent (at least allowing lighting campfires this way, unsure about other blocks)
not sure if this is doable within the scope of this mod or if too heavy tweaks would be required

if spawn eggs make mobs come from them how come the eggs don't crack?

Split off from #3

Make splash and lingering water bottles de-aggro enderman who touch their area much like when they touch normal water/rain/etc.

debug.log

Release blocker if I've ever seen one.

Player drops set to invincible when dying in the nether can burn and get destroyed. If it is a specific item set to not burn, the item will not burn and will work fine. This works as expected in the overworld.

Split off from #3

Allows you to repair anvils using Iron Blocks
Cheaper than making an entirely new anvil each time it breaks, since anvils only have 2 stages of damage to repair, so 2 blocks instead of the normal 3.44 blocks
A nice alternative to the comparatively balance-altering #11

Here the crash report:

https://pastebin.com/skGa1A31

kinda self-explainatory ain't it?

The game freezes for a fairly long period of time after "mod loading complete" with both mods. It also throws it back to the loading screen for more atlas stitching after reaching the main menu.

crash report - https://hatebin.com/msbapjwlke
latest.log - https://hatebin.com/mftbkarvie

of course I'm describing the return_on_break functionality.
Seems like it will be calculated twice instead of once.

On default settings, light mode where the old lava option is disabled, it still keeps applying in my game.
With fabrication on default settings

Without fabrication