Describe the bug There is a flaky spec on <div class="Box Box-

sounds good, thank you <a class="user-mention notranslate" data-hovercard-type="user"

<a target="_blank" rel="noopener noreferrer" href="https://private-user-images.githubu

Fix flaky spec on `TestFakerFile#test_file_name` about faker HOT 6 CLOSED

thdaraujo commented on June 5, 2024

Fix flaky spec on `TestFakerFile#test_file_name`

from faker.

Comments (6)

keshavbiswa commented on June 5, 2024 1

I think I got it, it's not matching the number (.mp3) as the extension. So updating the last part in the regex to assert for alphanumeric should do the job.

from faker.

keshavbiswa commented on June 5, 2024

I'd like to give this a shot 🤚

from faker.

thdaraujo commented on June 5, 2024

sounds good, thank you @keshavbiswa !

from faker.

keshavbiswa commented on June 5, 2024

This seems like an issue with regexp_parser version bump.

It for some reason matches everystring but "whole-bless/cupiditate.mp3".

matcher = %r{^([a-z\-_.]+)(\\|/)([a-z\-_]+)\.([a-z]+)$}
matcher = Regexp.new Regexp.escape matcher if String === matcher

obj= "cutting-minister/qui.numbers"
matcher =~ obj

Regexp.last_match # => #<MatchData "cutting-minister/qui.numbers" 1:"cutting-minister" 2:"/" 3:"qui" 4:"numbers">

obj = "appointment-notebook/occaecati.bmp"
matcher =~ obj
Regexp.last_match # => #<MatchData "appointment-notebook/occaecati.bmp" 1:"appointment-notebook" 2:"/" 3:"occaecati" 4:"bmp">

# For some reason this doesn't work
obj = "whole-bless/cupiditate.mp3"
matcher =~ obj
Regexp.last_match # => Returns nil