Comments (3)
A bit of an update on this:
we had some sessions around this during ruby conf as you can see there were four PRs that came out of this but we did agree on leaving some of the inconsistent names in place because they do follow proper/popular capitalization.
Fixed on in progress are.
- The room being changed/deprecated to the Room
- Show being changed/deprecated to theater instead as that made it's function more clear.
- fmabrotherhood being changed FullmetalAlchemist from fmabrotherhood to the fullname.
- IDNumber is being changed to IdNumber.
However, we did decide to leave DnD and TheITcrowd as they are because DnD is the popular spelling of the game and TheITCrowd follows correct capitilization.
I think that caught the gist of everything unless @stefannibrasil and @thdaraujo have more to add.
P.S Any of the generators that I haven't mentioned but are in the issue are still up for grabs.
from faker.
Thanks @sjjbirch for creating the issue, some of these generators have inconsistent names. And thanks @Jamal-A-Mohamed for summarizing the work that is being done to address this issue.
from faker.
Thanks everyone! So the remaining generators are:
- "Nhs" => "NationalHealthService"
- "Faker::Australia" => place it inside of the
Locations
module to follow the directory structure.
from faker.
Related Issues (20)
- Trying to call Faker::Music::Opera.saint_saens fails HOT 1
- Dota - Flaky specs
- New generator request: Faker::Commerce.rating HOT 2
- Use deterministic helper to execute the test provided in the block successive number of times HOT 9
- Improve testing of locales files HOT 2
- New generator request: Faker::Company.indian_gst_number HOT 3
- Outdated country names and inconsistencies in en/address.yml HOT 5
- Add benchmarking to faker-ruby HOT 6
- Deprecate Generators with External Calls HOT 3
- Fix/Deprecate `FmaBrotherhood` Generator HOT 2
- Reproducing "Faker::Base#regexify does not work with non-capturing groups or + repeat operator" on v 3.2.1 HOT 2
- `Faker::Time.backward (.forward)` may generate time which is greater (less) than the current time HOT 4
- Fix flaky spec on `TestFakerFile#test_file_name` HOT 6
- Translation missing | en.faker.company.indian_gst_number HOT 6
- Consistent addresses HOT 3
- Drop support for Ruby 2.7 HOT 8
- Invalid GB phone number from `Faker::PhoneNumber.phone_number` HOT 3
- Fake Zip Codes HOT 6
- v3.2.3 correct? HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from faker.