faithful-resource-pack / app Goto Github PK

Right now, green is only used as an accent colour while using light mode. I thought it would be nice to use it in dark mode as well, for consistency and because it would look nicer.

Describe the bug
When I try to add an additional image to my add-on, the site is showing during a frame of a second the image name but it removes it after. My image is 1920x1080, JPEG format.

To Reproduce
Steps to reproduce the behaviour:

1. Click on the edit button of your add-on.
2. Click on'Replace additional image(s)
3. Chose your image.

Expected behaviour
Normally, the image name should stay where the button is.

Screenshots
Video available in Compliance Devs Discord in #webapp. (The image I used in this video was simply used as an example to show the bug. It does the same thing as for the image I said above.

Browser & Environment (computer/phone):

• Firefox

Logs
If applicable, add screenshots of the console log (ctrl + shift + i for chrome/edge)

Right now, the controls for language switching are always at the bottom of the page. But since many pages like the gallery or contributions are very long, it can require the user to scroll very far down to reach the controls. The gallery is the most annoying page of them all, since oftentimes you'll reach the "bottom", reach for the controls but then more textures load and you have to scroll again.

This is why I think the controls should be moved somewhere else. Perhaps to the top of the page to the navbar?

Describe the bug
When you keep yourself logged in for a while, the discord authentication token expires and cause issues with actions using permissions

Expected behaviour
Being logged out when the token expires

Additional context
Submitted this error to let people know why they have to re-login themself.

• theme color not consistent with header
  

• background image scaled very big on long lists
  

• menu is infinitely long / as long as the page
  

• every path overflows
  

Describe the bug
When a user has submitted an add-on and goes back to its submissions page, the page doesn't load

To Reproduce
Steps to reproduce the behaviour:

1. Don't be an Admin (or someone who can see all non-approved addons)
2. Submit an add-on
3. Go back to the submissions page
4. See the error

Expected behaviour
Pending/Denied addons should still be accessible by owners

Screenshots

Browser & Environment (computer/phone):

• Chrome & Mozilla (doesn't seems to be related)
• Version [e.g. 22]

Additional context
code here

Describe the bug
When searching for someone's contributions on the Contributions page, the dates that are shown next to the texture preview are not translated, and show up in English even when selecting another language.

To Reproduce
Steps to reproduce the behaviour:

1. Select a language other than English
2. Go to the Contributions page
3. Search for anybody's contributions
4. See the untranslated dates

Expected behaviour
The dates should show up in the selected language.

Screenshots

Browser & Environment (computer/phone):

• Firefox
• 99.0.1

Describe the bug
texture menu poping up when it shouldn't

Steps to reproduce

1. Go to the gallery
2. Click on any texture
3. Press escape instead of the X button
4. Scroll down to a bit to load new textures or use the search bar and type something
5. The texture menu will open up

Expected behaviour
the menu to not pop up when you do step 4.

Browser & Environment:

• Browser: chrome
• Environment: windows 10

Additional context
if you refresh the page it stops happening until you do the steps again

Describe the bug
Title says it all.

To Reproduce
Steps to reproduce the behaviour:

1. Set the theme in the web app to the System option
2. Change your system theme
3. See the theme not being applied in the web app
4. Refresh
5. The theme is now applied

Expected behaviour
The theme should be applied immediately when system theme is changed.

I wouldn't call this a bug, but probably more of an oversight. All language files are being loaded even though just the one that is activated should be. These files are pretty small, but scaling that to hundreds of users and many page visits per session definitely results in a lot of unnecessary traffic.

This is a screenshot from the chrome dev tools in the network tab:

Describe the bug
It's midnight, you go to the addons review page, and you take your best Uranium shot yeet.

To Reproduce
Steps to reproduce the behaviour:

1. Go to the addon review page

Expected behaviour
A colour that doesn't burn my eyes :'(

Screenshots

Describe the bug
When updating a Minecraft version through the webapp, all paths are successfully changed, but the versions inside settings.json remains the same, which, doesn't allow us to edit/add this edited version to existing/new textures.

To Reproduce
Steps to reproduce the behaviour:

1. Go to the texture tab in the database menu
2. Click on modify a Minecraft version
3. Set a new field
4. Refresh the page
5. Open any texture & go to its path, see the path using the field you've edited
6. Edit the version of that path, you can't see the edited path you've added;

Expected behaviour
Settings.json being smoothly updated

Screenshots
Should be implemented somewhere here
https://github.com/Compliance-Resource-Pack/App/blob/main/backend/paths.js#L87

Additional context
⚠️ This also happens with adding a new version!!

Right now, the All texture tag shows up as All in all languages, making any translations technically incomplete. If possible, it would be nice to have this category name translatable.

Describe the bug
On the Users page, when searching for a user (doesn't even have to yield any results) and then using the search field to search for another one, nothing happens. This is because /[username] is added to the URL instead of replacing the previous search.

To Reproduce
Steps to reproduce the behaviour:

1. Go to the Users page
2. Search for anything (yes, literally any text)
3. Press the Search button
4. Search for something once again using the search field (can be the same string)
5. See the URL getting longer and longer as you mash the Search button

Expected behaviour
The new search should replace the old one in the URL.

Screenshots

Browser & Environment (computer/phone):

• Firefox
• 99.0.1

Describe the bug
When using light theme, the add-on description field on the Reviews page is coloured incorrectly.

To Reproduce
Steps to reproduce the behaviour:

1. Use light theme
2. Go to the Reviews page
3. Open any add-on
4. See the error

Screenshots

Browser & Environment (computer/phone):

• Firefox
• 99.0.1

Is your feature request related to a problem? Please describe.
As @Pomi108 said multiple times, you can't easily edit nor delete/add a contribution to a texture and fix missing/wrong contributions inside the database

Describe the solution you'd like
If @Pomi108 can explain how she's seeing what she wants

Describe alternatives you've considered
Smash my head on my keyboard to write code, jk.

Additional context
Nope

Describe the bug
When switching to a language featuring a translation for the All tag, the translation doesn't get applied until after the page is refreshed – unlike all other translations.

To Reproduce
Steps to reproduce the behaviour:

1. Go to the gallery
2. Choose a language that translates the All tag (currently only Czech does this)
3. See the tag not being translated
4. Refresh the page
5. See the translation being applied

Expected behaviour
The translation should appear as soon as the language is switched.

Screenshots
English page, after switching from Czech:

Browser & Environment (computer/phone):

• Firefox
• 99.0.1

When using a translation, the standard English date format is still used, which might be incorrect in some languages. It would be very useful to have the ability to define a custom date format for each language.

Describe the bug
When loading anybody's contributions on the Contributions page, they're shown in French no matter what language is selected. They'll only change to the correct ones once another language is selected.

To Reproduce
Steps to reproduce the behaviour:

1. Make sure your language isn't set to French
2. Go to the Contributions page
3. Search for anybody's contributions
4. See them being displayed in French
5. Switch your language to something else
6. See the correct translations being applied

Screenshots

Browser & Environment (computer/phone):

• Firefox
• 99.0.1

Logs
The console gets spammed by this, but I'm not sure whether that's related to this issue.

Additional context
Probably related to the fixing of #45.

Some pages are just unnecessary to be logged in to access them.

Some of these pages that should be publicly accessible are:

• Dashboard (would need a replacement for the "Profile" widget
• Statistics
• Gallery

The gallery page likely being to most used one by people who don't actually need to do anything with their linked account.

Describe the bug
You can't find users without being case sensitive

To Reproduce
Steps to reproduce the behaviour:

1. Go to (https://webapp.compliancepack.net/#/contributors/all/Juknum) -> find me
2. Got to (https://webapp.compliancepack.net/#/contributors/all/juknum) -> you can't find me

Expected behaviour
Be able to search users without being worried about case sensitive stuff

At the moment, when the Users page is loaded, all users get loaded along with it. This leads to near-unusable performance.

It would make more sense to not load any users out of the box, and instead only show them when searching, like on the Contributions page.

• Translation (Moved to Crowdin)
• Mods
• Modpacks
• Add-ons

Unfortunately I don't have any screenshots anymore, but updating your Discord profile picture does following things in the webapp:

• The webapp profile picture doesn't load at all anymore
• breaks loading of pending and denied add-ons in the reviews section
• possibly more that I haven't seen yet

All of this fixes itself after logging out and back in again, but this issue should still be looked into.

Describe the bug
When using light theme and then switching to dark, some elements remain light.

To Reproduce
Steps to reproduce the behaviour:

1. Have your theme set to Light as a starting point (make sure to refresh while using it)
2. Set your theme to dark
3. See that some elements aren't being changed
4. Refresh
5. The theme is now applied properly

Screenshots

Additional context
This doesn't happen every time for some reason. But it occurs more often than not.
It also doesn't happen in reverse – switching from Dark to Light theme seems to happen properly every time.

Describe the bug
When searching for a texture name that doesn't exist in the gallery, instead of showing the usual No results found. text, a weird rectangle is shown instead.

To Reproduce
Steps to reproduce the behaviour:

1. Go to https://webapp.faithfulpack.net/#/gallery/java/32x/1.18.2/All/break_particle for example.
2. Observe the rectangle.

Expected behaviour
A text saying No results found. should be shown.

Screenshots

Browser & Environment (computer/phone):

• Firefox
• 99.0.1

Logs
No logs are generated.

Describe the bug
It seems that people that was logged in now gets the following errors when coming back to the webapp since the 'theme update' commit

To Reproduce
Steps to reproduce the behaviour:

1. Be already logged
2. Open the webapp
3. Nothing loads
4. See the error in the console

Expected behaviour
Not that lmao

Screenshots

Browser & Environment (computer/phone):

• Edge

Doing a hard refresh solve this issue

• Moves apps hard-coded settings to the database
• Make a page where admins & devs can edit settings

Title says it all. Right now the transparency checkerboard in the gallery is 32x32, which makes textures like glass look really weird when viewed.

Simply changing the checkerboard to a 2x2 or 4x4 one would do the trick in my opinion.

Describe the bug
Even when switching to a language other than English, none of the strings in date picker calendars like the one in the Add Contribution window are translated.

To Reproduce
Steps to reproduce the behaviour:

1. Go to https://webapp.faithfulpack.net/#/contributions
2. Press the Add manually button
3. See that the calendar is not translated

Expected behaviour
The calendar should display translated strings.

Screenshots

Browser & Environment (computer/phone):

• Firefox
• 99.0.1

Is your feature request related to a problem? Please describe.
Mobile menus is way more user friendly than the desktop menu, plus if we use the mobile menu on desktop, the top part become available for dark mode & language option

Describe the solution you'd like
Use mobile menu for the desktop too

Additional context
None

A missing tag that can be used to find which textures are yet to be completed. Basically /missing but on the gallery.

Describe the solution you'd like
If possible, the tag could be automatically assigned and removed depending on whether or not a texture for 32x or 64x exists. Seperate tags for 32x, 64x, bedrock etc could also be used.

Describe alternatives you've considered
I don't have any alternatives, but anyway to find a list of missing textures on the gallery.

Additional context
N/A

Describe the bug
When you search for contributors in the user list the popup window, you can't find people without any contribution

To Reproduce
Steps to reproduce the behaviour:

1. Go to database tab
2. Click on add manually
3. Search for Derp
4. No result found, but the user exist: https://webapp.compliancepack.net/#/contributors/all/Derp

Expected behaviour
Being able to add contributions to newly created/contributor without contribution yet.

Screenshots

Describe the bug
If the path of a texture is too long, the text and/or the delete and edit buttons overflow, which can also cause that buttons aren't visible at all.

Example texture: #1174 cartographer

Screenshots

Describe the bug
When submitting addons on the web app, this error shows and prevents submitting the new addon when the header image has a capitalized PNG extension: "Request failed with status code 403: Extension not allowed."

To Reproduce
Steps to reproduce the behaviour:

1. Start a new addon submission in the web app.
2. Upload a header image with extension ".PNG".
3. Fill in all required fields.
4. See the error when clicking the "Submit" button.

Expected behaviour
There should be no error, since ".PNG" should be treated exactly as ".png".

Screenshots

Browser & Environment (PC):

• Browser = Google Chrome
• Version 100.0.4896.127 (Official Build) (64-bit)

Logs
You might want to collect this on your own.

Describe the bug
Since the last few commits, some aspects of editing textures in the database are fully broken. For example what I found was: deleting texture paths doesn't work and adding textures uses doesn't work.

possible related commits:
a8459c7
1b0df6c
2353737

To Reproduce
Steps to reproduce the behaviour:

1. Edit a texture
2. either try to add a use or try to delete a path
3. nothing happens

Browser & Environment (computer/phone):

• Windows 10, Brave 1.31.87 and Firefox 93.0

Logs
no error logs related to the issue

Describe the bug
Newly added versions and/or displayed versions do not get sorted, which results in incorrect versions displaying in the webapp and bot, it especially breaks much in the bot displaying textures

To Reproduce
Steps to reproduce the behaviour:

1. look at literally anything that has versions

Expected behaviour
Correct sorting of versions either when a version gets added or when versions get displayed

Screenshots

1.18 should be at the start and not at the end

shows "1.18 - 1.17.1" instead of "1.13.2 - 1.18"

shows "1.18+" instead of "1.17.1+"

Describe the bug
Take for example the dirt texture. For Compliance purposes, the texture has been merged with options_background and thus multiple java paths (in a single version) are assigned to the texture ID. However, searching for options_background in the gallery yields no results.

To Reproduce
Steps to reproduce the behaviour:

1. Go to the gallery
2. Search for any texture that has multiple paths assigned to the ID in a single edition and version
3. No results when searching for any texture name other than the first (?)

Expected behaviour
The gallery should show these "merged" textures separately (they should still be listed as one ID with multiple paths though – the issue is with the search output). As in, the gallery should search the paths themselves, not just the IDs.

Screenshots

Describe the bug
When using a page scale other than 100% (for example 110% or 90%) and searching for something like potion_bottle in bedrock (which doesn't display all results immediately and instead loads them when you scroll to the bottom of the page), the additional textures don't load. This applies when searching for all textures (without a search query) as well.

To Reproduce
Steps to reproduce the behaviour:

1. Set your browser scale to anything other than 100% (now happens on all scales)
2. Go to the gallery
3. Don't search for anything, just leave it on All
4. Scroll to the bottom of the page
5. See that additional textures aren't being loaded

Screenshots

Browser & Environment (computer/phone):

• Firefox
• 99.0.1

Additional context
If you set your browser scale to 100%, the textures start being loaded immediately (and inversely, when setting it back to something other than 100%, they stop being loaded), no refreshing is required.

Describe the bug
As admin you are unable to edit an add-on from other authors, which has definitely worked before the add-on rework. You are able to open the edit page and make edits, but clicking the "submit" button does nothing.

To Reproduce
Steps to reproduce the behaviour:

1. Be an admin
2. Edit any add-on on the reviews page
3. Click submit

Browser & Environment:

• Brave 1.36.119 (based on Chromium 99.0.4844.83)

Logs

Describe the bug
When trying to delete a single author's contribution from a texture by deleting it from their page in the Contributions tab, all contributions on said texture are deleted instead.

To Reproduce
Steps to reproduce the behaviour:

1. Go to the Textures tab
2. Search for a single contributor
3. Find a texture that's got multiple authors
4. Delete the contribution using the trash can button
5. See that all contributions are deleted

Expected behaviour
Only the searched author's contribution should be deleted from the texture.

Browser & Environment (computer/phone):

• Firefox
• 95.0.2

While editing the texture use, newly added versions like 1.18 get displayed

But when editing the texture path, the version is gone and can't be selected anywhere

Describe the bug
Some parts are still dark & the differences between elements are really bad :/

Browser & Environment (computer/phone):

• Edge

Right now, textures like redstone_dust_overlay (which is fully transparent) are shown as not done in the gallery.

This can be misleading. I suggest that for textures that are excluded from the /missing command, we simply display the vanilla texture instead.

Alternatively, we could hide textures like these from displaying completely.

• Make a database collection for mods & modpacks, this would fix not founds mods when downloading modpacks resources pack (this would use ID instead of names)

• Use CurseForge project ID for mods ID (todo: find a solution for mods not on curse)

• Add support for Modrinth & others platform

Describe the bug
When you try to search something like bed/black in the gallery, you will only be met with a blank page.

To Reproduce

1. Go to the gallery
2. Input a query containing the forward slash / character (for example bed/black
3. Observe the page break

Expected behaviour
Inputting a slash in the search query could search in a given folder instead. Like bed/black could search in entity/bed/black.

Screenshots

Browser & Environment (computer/phone):

• Firefox 95.0.2

Describe the bug
The Anonymous option in user settings straight up doesn't work at all. Even when it's not checked, the name is still shown everywhere.

Additionally, instead of users not in the database showing as Unknown user, they show up as Anonymous instead.

To Reproduce
Steps to reproduce the behaviour:

1. Check the Anonymous checkbox in the user settings of any user
2. Go to the gallery and search for a texture they're credited for
3. Observe their name being shown

Expected behaviour
The name should be censored and show Anonymous. Users not in the database should be displayed as Unknown user.

Screenshots

Browser & Environment (computer/phone):

• Firefox
• 99.0.1

• based on features from https://coolors.co/
• implement into the current bot commands (/color and /palette)

(main reason for this being, that coolors.co, the current service that we use is bloated with many features that we don't actually need)

Describe the bug
When viewing a texture that is not done in the gallery, for example sculk_shrieker_can_summon_inner_top, the name can overflow the frame if it's too long.

To Reproduce
Steps to reproduce the behaviour:

1. Go to the gallery
2. Search for sculk_shrieker_can_summon_inner_top
3. See the error

Expected behaviour
The name should be limited to the frame and not extend past it.

Screenshots

Browser & Environment (computer/phone):

• Firefox
• 99.0.1

Describe the bug
On the Contributions page, when searching for a person's contributions, the texture names and all the authors related to the contribution were listed as well. This is, however, no longer the case.

To Reproduce
Steps to reproduce the behaviour:

1. Go to the Contributions page
2. Search for the contributions of any contributor
3. See only the date and ID being listed

Expected behaviour
The name of the texture should be shown, along with all the authors related to the contrib, as that's useful when there are multiple authors.

Screenshots

Browser & Environment (computer/phone):

• Firefox
• 99.0.1