faisalman / age-calc-cs Goto Github PK

May you should move the fields to private properties.

For one case it calculates the age wrong. For example:

Start Date: 02/01/2019
End Date: 08/31/2020

It calculates as 1 year, 7 months and 2 days instead of 1 year, 6 months and 30 days.

Hi.

Your code is not calculating correctly.

Birthday = 02/23/2022 (MM/dd/yyyy)

Example Dates:
04/28/2022 => 0 Years, 2 Months, 5 Days
04/29/2022 => 0 Years, 2 Months, 6 Days
04/30/2022 => 0 Years, 2 Months, 7 Days
05/01/2022 => 0 Years, 2 Months, 6 Days (should be 8 Days)
05/02/2022 => 0 Years, 2 Months, 7 Days (should be 9 Days)
05/03/2022 => 0 Years, 2 Months, 8 Days (should be 10 Days)

The issue happens because you are calculating the days without considering the months / year. You have to calculate years & months at first and after this the remaining days.

this.Months = Cday.Month - (Bday.Month + 1) + Math.Abs(DaysRemain / DaysInBdayMonth);

Bday 26 Nov 2020
Cday 25 Dec 2020

Run.
DaysRemain = 25+ (30- 26) = 29
this.Months = 12 - (11+1) + Math.Abs(29 /30)
Math.Abs(29 / 30) >> 0.999
this.Months = 12 - (11+1) + 0.999
this.Months = 1 (int) Wrong!

Age 1 month 29 days

add Math.Truncate()
this.Months = Cday.Month - (Bday.Month + 1) + Math.Truncate(Math.Abs(DaysRemain / DaysInBdayMonth));

Age 29 days