coffeebros's People
Forkers
bear-codingcoffeebros's Issues
add db_test, getPlaces and postPlaces
Not using what you requiring you get rid of it :)
Line 2 in f9b3304
allow user to submit reviews using fetch with post
initial front-end, mobile first
Check postdata query
your review query doesnt work check it
ids are not unique, check tempPic
readme
public directory is not structured very well
Top Rated Places handler (BE)
some of your select queries in the read data are not used in the handlers
even though you are using some of them in tests make sure that you use what your are testing
Not clear instructions
I don't get it, The search doesn't seem to work, and reviews are not being added
I feel like I'm lost, I don't want to say that it is not working application, but that's how it looks like in my browser.
we can't code review any broken sites or not finished codes.
I think you should act like the clients are stupid people who you should explain everything to them, and don't let them suffer by cloning and adding some sentences so it works, please make our life easier
Some of the tests are failing
I think you just need to update the expectations to reflect your default data changes, and you'll be ๐ฏ
set up test dependencies and initial server files
tape, supertest, tap-spec
nodemon
server.js, router.js, handlers.js
Lovely designs!
Looks wonderful on mobile. You should be able to make it responsive (i.e. look good on desktop) very easily, try removing grid-template-columns: 1fr 1fr 1fr;
and adding a sensible max-width
.
Database queries tests
Add error handling to the search
It seems like your server crashes when the user searches for a place that doesn't exist ๐ฅ
Select/Insert execute functions
build index.js
search query (with autocomplete if time allows)
add rating/review
Database build
CoffeeBros
- Places
- ID
- name
- rating
- address
- google map
- Review
- ID
- place_id
- comment
- rating
- Address
- ID
- City
- Street
- Pictures
- ID
- Place ID
- PictureURL
fix accessibility as much as you can ;)
accessibility check gives 63%
Delete unused functions and commented ones
Make the UI for the city dropdown and for the 'find your place' button for obvious
It's not clear that the first is a dropdown and the second is a button ๐คทโโ๏ธ
Handler for /search endpoint.
router.js | handlers.js |
---|
- handle endpoint | [ ] parse url to get place and city
- call handler for search | [ ] connect to the db
๐ ๐ | - [ ] get data and return it
Show top rated places (FE)
Using setTimeout to make sure database queries have completed
This is a bit of a ๐- you don't want to rely on an arbitrary number of milliseconds to know when an operation is finished.
You can rewrite this in a clever way using something like a parallel function, or you can use promises instead of callbacks (I know we haven't covered that yet).
But in your case it's actually quite inefficient to be looping through an array and making a database query for each of them. I'm pretty sure you can make use of the power of SQL here and do it all in one query using a clever little JOIN
๐
add public to handlers.js file
Get(Select)/Post(Insert) functions
- get Reviews
- get Places
- get Address By ID
- get Places By Name
- get Latest Reviews
- get Review By Place ID
- get Pictures By Place ID
- get Place Details By ID
- get Map By Place ID
- get Top Places
- insert review
Delete outdated branches
Server keep crashing
TypeError: Cannot read property 'address_id' of undefined
at selectQueries.getPlacesByName (/home/karam/Desktop/FACN5/Team-Projects/Week06/Review/CoffeeBros/src/handlers.js:65:50)
at databaseConnection.query (/home/karam/Desktop/FACN5/Team-Projects/Week06/Review/CoffeeBros/database/queries/selectquery.js:8:7)
at Query.client.query (/home/karam/Desktop/FACN5/Team-Projects/Week06/Review/CoffeeBros/node_modules/pg-pool/index.js:300:18)
at Query.handleReadyForQuery (/home/karam/Desktop/FACN5/Team-Projects/Week06/Review/CoffeeBros/node_modules/pg/lib/query.js:125:10)
at Connection. (/home/karam/Desktop/FACN5/Team-Projects/Week06/Review/CoffeeBros/node_modules/pg/lib/client.js:215:19)
at emitOne (events.js:116:13)
at Connection.emit (events.js:211:7)
at TLSSocket. (/home/karam/Desktop/FACN5/Team-Projects/Week06/Review/CoffeeBros/node_modules/pg/lib/connection.js:125:12)
at emitOne (events.js:116:13)
at TLSSocket.emit (events.js:211:7)
[nodemon] app crashed - waiting for file changes before starting...
Add instructions for running the app to your readme
๐ค
Delete unused test files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.