Git Product home page Git Product logo

domain-finder's People

Contributors

mynahmarie avatar nickp123 avatar samisha99 avatar

Stargazers

 avatar

Watchers

 avatar  avatar

domain-finder's Issues

test.test.js

I think you guys should add more tests,

and the existing test code doesn't really text anything in your API πŸ˜“

The webpage instruction

Its not really that clear to how use the search menu

in my opinion instead of clicking the button to go to the domain it should go automatically

or maybe the button text should be different to prevent confuse πŸ€”

README

BEAUTIFUL README ❀️

i would only add local instructions

Searching for future results

Searching for a 'futuristic' date shouldn't give any results πŸ˜…

(Unless your planing to predict the future) πŸ‘½

"Search not found"

When the search results didnt find anything it returns 'undefined'
in my opinion there should be a message saying "Info not found" or something instead of

IP address: 80.178.83.138
City: Tel Aviv
State/Region: Tel Aviv
Country: Israel
Zipcode:
Timezone: Asia/Jerusalem
Coordinates: 32.0666, 34.765

Index.html

We need an index file with the basic divs and sections we will use.

Pretty code

you thought this is an issue to compliment your beautiful code didn't you?

you could really shorten these line of code by defining a variable that equals to data.archived_snapshots.closest

xhr request callback

callbacks like this should always be error first callbacks, cause currently when an error occurs in your xhr request you are returning,
and then nothing would happen after it, it's just going to hang and the user won't know the heck just happend.

that's why in callbacks they take error first and always check if there's an error so it can handle it depending on how you told it to handle it.

ps: same goes to the archive api request

console errors

please check for console errors
:bowtie: πŸ˜„ πŸ˜† 😊 πŸ˜ƒ ☺️ 😏 😍 😘 😚 😳 😌 πŸ˜† 😁 πŸ˜‰ 😜

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.