facn3 / al-tarikh Goto Github PK
View Code? Open in Web Editor NEWWeek 6 Project
Home Page: http://altarikh.herokuapp.com/
License: Apache License 2.0
Week 6 Project
Home Page: http://altarikh.herokuapp.com/
License: Apache License 2.0
css styles
Line 29 in dcfdc7a
create a function that takes data from a form and posts it to the database
the function could be written in a more efficient (ناجع) way.
Creating back end code
reset.css file is empty!
using px units on css..it is also not easy for me not to use px since I am so used to it, but let's try to use em/rem units since it is considered better practice!
create .gitignore list
Such a cool app! Great work!
However, wouldn't it be better to arrange the list according to the date of event, instead of the order I put?
ex) if I put events for DEC 5, DEC 20, DEC 13, it would be better to see then arranged as DEC 5, DEC 13, DEC 20 on the list?
Create a function that gets data from the database and sends back as response.
Make a schema diagram
Line 16 in dcfdc7a
the name of the function should match what it does, this function renders the data it gets.
Some of the code inside the router could've been maybe written more clearly inside the handler, like here:
https://github.com/FACN3/al-Tarikh/blob/master/src/router.js#L29
and some of the code inside the handler could've been separated in different modules to handle the SQL queries like here:
https://github.com/FACN3/al-Tarikh/blob/master/src/handler.js#L40
It would help to separate the code into well defined modules for readability and also to better keep track of possible issues and make debugging easier...
Create a readme file
there was a workshops for testing database and testing a server i would 100% argue that they were the simplest workshops in the course, it's really not hard to do testing, that is literally the best part of web development seeing 100% coverage and tests pass
Create xhr request to get data fro the database and update the dom
I think it's better to send back what is the error exactly rather than the word error.
https://github.com/FACN3/al-Tarikh/blob/master/src/router.js#L15
Using inner join, query the two tables to get the right data
Set up travis
we don't have access to your database because its still stored locally on your computer so the DB_URL is not reaching any database.
Handling Public files
We need to deploy our app to Heroku
Creating back front code
I mean there is none, why ?!
we introduced config.env should be ignored in the .gitignore file why is it pushed to github ????!!!!!!
if it's on github ( and github is open for everyone ) then people can just come take your database url either delete everyhing in it or crash it or even fill it up with random shizz
Choosing more descriptive names for classes can help for later updates...
https://github.com/FACN3/al-Tarikh/blob/master/public/css/style.css#L25
I'm not sure where to start here since there is so many Github workflow bad practices:
CSS
, Back End
-> those are definitely not good issue names since they don't explain whats going on in the issue, also they are just too big for an issue, imagine im working on something and my backend is like 3000 lines of code, do i just make a pull request that contains 3000 lines of code ????!!!!!!!! that would take years to merge.example of an issue : create the publicHandler function
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.