css styles

create a function that takes data from a form and posts it to the database

Too many console logs!!

https://github.com/FACN3/al-Tarikh/blob/master/src/handler.js#L21
https://github.com/FACN3/al-Tarikh/blob/master/src/handler.js#L32
https://github.com/FACN3/al-Tarikh/blob/master/src/handler.js#L48

the function could be written in a more efficient (ناجع) way.

what if Im a new user whos not one of those?

Creating back end code

database folder

• db_connection
• db_build.js
• db_build.sql
• config.env

1. reset.css file is empty!

2. using px units on css..it is also not easy for me not to use px since I am so used to it, but let's try to use em/rem units since it is considered better practice! 🙌

create .gitignore list

Such a cool app! Great work! 👏 👏 👏

However, wouldn't it be better to arrange the list according to the date of event, instead of the order I put?

ex) if I put events for DEC 5, DEC 20, DEC 13, it would be better to see then arranged as DEC 5, DEC 13, DEC 20 on the list?

Create a function that gets data from the database and sends back as response.

Make a schema diagram

the name of the function should match what it does, this function renders the data it gets.

Some of the code inside the router could've been maybe written more clearly inside the handler, like here:

https://github.com/FACN3/al-Tarikh/blob/master/src/router.js#L29

and some of the code inside the handler could've been separated in different modules to handle the SQL queries like here:

https://github.com/FACN3/al-Tarikh/blob/master/src/handler.js#L40

It would help to separate the code into well defined modules for readability and also to better keep track of possible issues and make debugging easier...

Create a readme file

there was a workshops for testing database and testing a server i would 100% argue that they were the simplest workshops in the course, it's really not hard to do testing, that is literally the best part of web development seeing 100% coverage and tests pass

Create xhr request to get data fro the database and update the dom

I think it's better to send back what is the error exactly rather than the word error.
https://github.com/FACN3/al-Tarikh/blob/master/src/router.js#L15

• make tables

• make DATABASE files

Using inner join, query the two tables to get the right data

Set up travis

we don't have access to your database because its still stored locally on your computer so the DB_URL is not reaching any database.

Handling Public files

😆 😆

We need to deploy our app to Heroku

Creating back front code

I mean there is none, why ?!

we introduced config.env should be ignored in the .gitignore file why is it pushed to github ????!!!!!!

if it's on github ( and github is open for everyone ) then people can just come take your database url either delete everyhing in it or crash it or even fill it up with random shizz

Never ever push your enviroment variables

Choosing more descriptive names for classes can help for later updates...

https://github.com/FACN3/al-Tarikh/blob/master/public/css/style.css#L25

I'm not sure where to start here since there is so many Github workflow bad practices:

• Let's start with issues though, you need to raise small issues and not stuff like CSS, Back End -> those are definitely not good issue names since they don't explain whats going on in the issue, also they are just too big for an issue, imagine im working on something and my backend is like 3000 lines of code, do i just make a pull request that contains 3000 lines of code ????!!!!!!!! that would take years to merge.

example of an issue : create the publicHandler function

• pull requests should always contain a clear title and a good description of what the pull request is actually is AND RELATED TO AN ISSUE

• commits should always have issue numbers in their messages !!!!!!

• @hoslack @MarlenAw for real you guys you merged a PR 20 minutes ago?