facg2 / project-manager Goto Github PK

the document the you are referancing the the mean README.md should ending with the (*.md) extention
like:

userStories.md

it's not a big deal though ^_^

Sorry that I can't raise more issues right now 😢 🌵
There is a lot of code and it's hard in this time to see everything that is happening and where problems are.

I would recommend, after code review, raise your user stories are issues, and focus on getting one at a time working (as well as responding to issues I, and others have raised).

It looks like you've tried to implement a lot of different features and quite a few of them are maybe half done or so.

If you raise your user stories as issues, and decide which are the most important, you can work through them more methodically, so that you can make sure each one works before moving onto the next one, maybe having each pair work on a different user story at a time. This is useful in all projects right from the start, so you can define your priorities in terms of which features really matter to your app, and make sure you focus on them.

data format needed for team profile page from the backend
team = {
name , description ,
members => [names]
projects =>[{id,name,description,status,members[{id,pic,name}]}]
}

In your insert queries (line 44, 127, 221, 304 of handlers.js) you are not using paramaterized queries, this can open you up for SQL injection. See the documentation here for more info: https://node-postgres.com/features/queries#parameterized-query

For example, at the moment in handleAddTeam your query looks like this:

const query = `INSERT INTO teams(name , description) VALUES('${data.name}' , '${data.description}');`;
    getData(query, (err, result) => {...})

the paramaterized and safer version would look like this:

const query = `INSERT INTO teams(name , description) VALUES($1, $2);`;
const values = [data.name, data.description]
    getData(query, values, (err, result) => {...})

(the ... in the callbacks are just so I don't have to paste all of the callback code here)

teams array format needed from the backend to home page
teams = [
{name,description,[{id,pic,name},...]// array for members},
.....
]

facing the problem of database not found,

hey guys, we need to find a why to load member or team pages as we want to send the needed data from the backend to the front end while page loading,
I suggest we make to routes for each one with two different methodes, for example,
member page:
has GET route to start loading the page without data,and inside this page there is "XHR" POST request to request the data needed for this page

implement some functions in handlers.js file

This project is really ambitious and it's nice to see you trying for something big!

Really big files can be quite hard to deal with and when reading the code it can be quite complex, when you have hundreds of lines it can just be quite hard to see what is going on.

If your handlers.js file is getting long (I would probably describe "long" as 100 or more lines) then it can be worth separating your handlers into separate files as well, inside of a handlers directory, each file doesn't have to be for one handler, could have something like "getDataHandlers.js", "postDataHandlers.js", "handleStatic.js" etc.

This file will exeute all Sql Queries

finished handle add projects,
handle edit projects and handle delete project

You no longer have a memebers table in your build script, but there are still a lot of references to it in handlers.js, sometimes in the same query as when you refer to members.js

you should be more specific about the routs
like the route below
any request with url starts with tm gonna satisfies the condition
for example:

/tmmmam ^^
/tmoro^^

  }else if (url.startsWith('/mem')) {

/memoo!
/memontm
/memarto!

Cool code though guys 😄