facg2 / fac-mentorship-schedule Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 1.0 111 KB

A web app to schedule mentors for every week in the cohorts

JavaScript 64.08% PLpgSQL 7.63% HTML 12.70% CSS 15.59%

fac-mentorship-schedule's People

Contributors

Watchers

Forkers

ishak52

fac-mentorship-schedule's Issues

host on heroku

It would be great to see your app hosted on Heroku!

Because of the environment variables it is a lot harder for people to just pull and run locally, so hosting really helps on these projects.

inconsistent variable naming style

Generally, in javascript you'll use camel case (likeThisKindOfWriting), in some languages and such peope also use snake case (snake_case_is_like_this), in your queries/db_functions.js file you have a snake case variable name (cohort_mentor) alongside all your camel case names, I would recommend changing this to make it more consistent.

make a sample database for testing

Add Html & Style

host database on heroku

Our database mustn't stay locally, we should host in heroku

Non-paramterised queries

I raised the same issue elsewhere so I will jsut link to that, take a look here: FACG2/project-manager#40

For you it is in your queries/db_functions.js file, in addCohort, addMenetor, and cohort_mentor.

Fire work guys!

I really loved your code, clear and organized file structure, big like for using SSL
I think you need to handle errors and make the user familiar with some of it, not just Loging it, also it's better to use a <input type="date"> rather than insert it as a text ..
but in general chapeau

date type

Add Readme

using the callback without puting it in the function arguments !

getData(cohort, (err, res) => {
    if (err) {
      console.log(err);
    } else {

      res.map((object, i) => {
        weeks[object.num].mentors.push(object.githubuser);
        weeks[object.num]['title'] = object.week_title
      })
      cb(null, weeks);
    }
  })
}

  cb(null, weeks) is not an argument for this function, you need to add it and need to add the callback in error case so you can handle the error in the callback , like this

if (err) {
     console.log(err);
    cb(null);
   }

Line 16 in d03a969

buildDatabase();

different return types in handlers

in this function

fac-mentorship-schedule/src/handlers.js

Line 65 in d03a969

function viewWeeksHandler(req, res) {

you are returning html if there is an error
but you are returning json if there is no error

facg2 / fac-mentorship-schedule Goto Github PK

fac-mentorship-schedule's People

Contributors

Watchers

Forkers

fac-mentorship-schedule's Issues

Recommend Projects

Recommend Topics

Recommend Org