facebookarchive / atom-menu-patch-for-catalina Goto Github PK

Hi, it appears that Atom v1.47.0 includes atom/atom#20172 (Electron 5.0.12). Just wanted to say thank you for improving our quality of life for this time period :)

Thanks for putting this plugin together. The crashes always seemed to hit at the most inopportune time. I might fork and look into adding a handler esc-key functionality.

Hello,

I'm sure you are already aware of this, but right clicking a file (say file-a.text) whilst file-b.text is open performs it's actions on the open file the the file that was right clicked.

Are we able to fix this?

The only issue I found now with this extension is the context menu getting cut off, menu will not change direction. Needs a way to detect window height. On the file tree it would work if mouse is position above 110pixels inside Atom but when below it will get cut off. On the edit window, it will get cut off anywhere I positioned the mouse.

Below 110 pixels on file tree:

So the only way to get around this is by scrolling the file tree so that the file your aiming for stays above that 110pixels, except when the file tree reaches the bottom, then the menu gets cut off again.

On the edit window it's always cutting off:

Maybe detecting the height of the context menu itself and then calculate the window height in the app, and only show the menu upwards if the height of the menu is going to pass the bottom. The only problem is, when using on my laptop for example, the menu doesn't completely show everything if having a few extensions active since it will show more content on the menu. So i guess, if calculating the size of the context menu, that could be used to also enable a scroll inside the menu if it reaches a 90% of the window in Atom.