In Fabric8AnalyticsStreamConnectionProvider.getNodeJsLocation() there is an exception thrown when running on Linux with no node installed (location is null).

This plugin is not responsible for exporting http packages to others.
The only candidate for export is com.redhat.fabric8analytics.lsp.eclipse, but unless some other plugin actually consumes it, that's unnecessary. Once you add a test plugin, that needs access to com.redhat.fabric8analytics.lsp.eclipse classes, then it might be useful.

TLD;DR : don't export anything

Looking at

It is confusing to call stack analyses for example on java files - display the menu item only for projects and pom.xml files

It would be better to find appropriate Eclipse bundles and depend on them instead of storing libraries in github and packaging them into the f8 plugin..

For example. instead of including httpclient-4.5.jar you can specify org.apache.httpcomponents.httpclient as a dependency in the manifest file.

Currently some URL are not final and are a temporary fix to make Component Analyses and Stack Analyses run. These need to be changed before making it available in the market place.

The authentication needs to be enabled using OSIO icon. On clicking OSIO token, a preference page should come up which contains information about the services that would be enables on logging into OSIO.

When the installation directory of Eclipse contains spaces in its name, the server will fail to start because of the following exception:

java.net.URISyntaxException: Illegal character in path at index 36: file:/home/ljelinko/programs/jbt/4.5 + F8/../../../git/fabric8-analytics-devstudio-plugin/plugins/com.redhat.fabric8analytics.lsp.eclipse.ui/fabric8-analytics-lsp-server-test-devstudio/output/server.js at java.net.URI$Parser.fail(URI.java:2848) at java.net.URI$Parser.checkChars(URI.java:3021) at java.net.URI$Parser.parseHierarchical(URI.java:3105) at java.net.URI$Parser.parse(URI.java:3053) at java.net.URI.<init>(URI.java:588) at java.net.URL.toURI(URL.java:946) at com.redhat.fabric8analytics.lsp.eclipse.ui.Fabric8AnalyticsStreamConnectionProvider.<init>(Fabric8AnalyticsStreamConnectionProvider.java:47) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at java.lang.Class.newInstance(Class.java:442) at org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.createExecutableExtension(RegistryStrategyOSGI.java:184) at org.eclipse.core.internal.registry.ExtensionRegistry.createExecutableExtension(ExtensionRegistry.java:905) at org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtension(ConfigurationElement.java:243) at org.eclipse.core.internal.registry.ConfigurationElementHandle.createExecutableExtension(ConfigurationElementHandle.java:55) at org.eclipse.lsp4e.LanguageServersRegistry$ExtensionLanguageServerDefinition.createConnectionProvider(LanguageServersRegistry.java:102) at org.eclipse.lsp4e.ProjectSpecificLanguageServerWrapper.<init>(ProjectSpecificLanguageServerWrapper.java:142) at org.eclipse.lsp4e.LanguageServiceAccessor.getLSWrapperForConnection(LanguageServiceAccessor.java:199) at org.eclipse.lsp4e.LanguageServiceAccessor.getLSWrappers(LanguageServiceAccessor.java:163) at org.eclipse.lsp4e.LanguageServiceAccessor.getLSPDocumentInfosFor(LanguageServiceAccessor.java:261) at org.eclipse.lsp4e.ConnectDocumentToLanguageServerSetupParticipant$1.run(ConnectDocumentToLanguageServerSetupParticipant.java:74) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)

As of yet, the token is managed through an Eclipse preference which has the following drawbacks:

• security: it should be stored in secured storage as this is a sensitive data
• it forces user to find the token in the OSIO UI and it is a bad UX

As DevStudio/JBossTools team will force as part of the Freesia release train on implementing OSIO login, it would be nice that the LSP plugin get access to the token through an extension point/OSGI service (that will be implemented of course by DevStudio/JBossTools team).
So the behaviour would be:

• if there is an extension point implementation/OSGI service found, call it to get the token
• if not use the current implementation

fabric8-analytics-lsp-server-test-devstudio is downloaded and installed at build time, it should be removed from the git repo (and added to .gitignore)

The stack analyses view is polling for analyses results but if the production is down, it never stops

If you reopen preferences with previously stored long token, the token field is not wrapped automatically and grabs the whole screen area.

Screenshot: https://www.dropbox.com/s/f5wzy4xvf1hztbc/Screenshot%202017-09-13%2010.01.09.png?dl=0

Currently the stack analyses can be viewed from here.

When user opens pom.xml file, the OpenShift.io login is displayed immediately. This is quite confusing. User should be informed that the Fabric8 analyses needs to login into OpenShift.io and asked, if he/she wants to log in.

Note that this will need change of OpenShift.io plugin API.

Only the last project open is processed by the Stack Analyses command

Please refer to the following doc for the test cases that are top be covered for Fabric8 Plugin.
https://docs.google.com/document/d/1D5XIZpHzRw-vnreYYtXRqgXmAa8KKzHFn0IXK_YFdmg/edit#heading=h.aifrx1s6veim

.DS_Store files are macOS specific and generally useless files, please remove them from the git repo

See

Looks like bad copy/paste

Examples are available here: http://www.vogella.com/tutorials/EclipseJobs/article.html#eclipse-background-processing

Next task in Devstudio involves integration of crowd sourcing api with Devstudio, where user will be asked to tag the components, user can skip if he wishes.
This will involve removal of Eclipse job which is implementing a counter to check if the response if stack report is available.

• Create and update site for the plugin
• Trigger analyses on Jenkins
• Upload the plugin on download.jboss.org

Please remove C# reference

Currently the the lookup method only picks the main manifest file. An iterative way to find manifest files was worked upon in this commit. https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin/commit/4e76647b4a7ed203e61ff442e1f1c8a9a49aa236#diff-abfa82c1af087068576ffd6394382b29R72

But this doesn't sound feasible for large scale projects.

Reference Issue #28

When building I see this warning:

[WARNING] Rule 0: org.jboss.tools.releng.CoreUIDependency failed with message:
[CoreUIDependency] com.redhat.fabric8analytics.lsp.eclipse.core is a Core plugin, but depends on these UI plugins directly or transitively:
> org.eclipse.ui

You should seek to move all UI functionality to the .ui plugin, out of the .core one.

Please rename the view to something meaningful and change its ID

When I run the stack analyses, I do not get any results only page that says Loading...

Steps:

1. Make sure you have analyses enabled
2. Open pom file with some security problem
3. The error markers should be visible in Problems view
4. Go to Preferences -> Fabric8 and disable code analyses

RESULT: The LSP server is stopped (you can see it in Eclipse log) but the error markers are still visible

The current implementation of the Stack Analyses will process all files from the workspace. The normal behavior is to use the current selection (file, project) to filter the scope of the command

Force stopping lsp server like this https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin/blob/master/plugins/com.redhat.fabric8analytics.lsp.eclipse.ui/src/com/redhat/fabric8analytics/lsp/eclipse/ui/Fabric8AnalyticsStreamConnectionProvider.java#L71-L72

Throws Exceptions like these
!ENTRY org.eclipse.lsp4e 4 0 2018-01-02 18:04:23.321 !MESSAGE Analyses Disabled !STACK 0 java.io.IOException: Analyses Disabled at com.redhat.fabric8analytics.lsp.eclipse.ui.Fabric8AnalyticsStreamConnectionProvider.start(Fabric8AnalyticsStreamConnectionProvider.java:73) at org.eclipse.lsp4e.LanguageServerWrapper.start(LanguageServerWrapper.java:174) at org.eclipse.lsp4e.LanguageServerWrapper.getInitializedServer(LanguageServerWrapper.java:458) at org.eclipse.lsp4e.LanguageServerWrapper.getServer(LanguageServerWrapper.java:442) at org.eclipse.lsp4e.LanguageServiceAccessor.getLSPDocumentInfosFor(LanguageServiceAccessor.java:357) at org.eclipse.lsp4e.ConnectDocumentToLanguageServerSetupParticipant$1.run(ConnectDocumentToLanguageServerSetupParticipant.java:74) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)
.
@ljelinkova has followed up with LSP4E team and has suggested some changes, but I don't think these changes will be incorporated any time soon.

While current solution works on small scale projects, it would not work on a large ones (like the whole wildfly project for example).

There should be a possibility to get the list of maven pom files from the maven plugin.

The view content is loading forever. There should be a reasonable timeout showing the error if it cannot load.

When the analyses is requested, the request is sent to
https://recommender.api.openshift.io/api/v1/stack-analyses/

However, the results are downloaded from
http://ops-portal-v2-ops-portal-ide.dev.rdu2c.fabric8.io/#/analyze

Is it all right to use this URL or should there be some more "official"?

I get an exception when I run the analyses, then close the Stack analyses view and run the analyses again.

Steps to reproduce:

1. Right click some maven project and select Stack analyses
2. The Stack analyses view should appear
3. Close the view
4. Right click the same project and run the analyses again
   RESULT: The following exception is in error log

org.eclipse.swt.SWTException: Widget is disposed at org.eclipse.swt.SWT.error(SWT.java:4533) at org.eclipse.swt.SWT.error(SWT.java:4448) at org.eclipse.swt.SWT.error(SWT.java:4419) at org.eclipse.swt.widgets.Widget.error(Widget.java:487) at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:424) at org.eclipse.swt.browser.Browser.checkWidget(Browser.java:207) at org.eclipse.swt.browser.Browser.setUrl(Browser.java:1145) at com.redhat.fabric8analytics.lsp.eclipse.CustomView$1.run(CustomView.java:61) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:37) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182) at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4497) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4110) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1155) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1044) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153) at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:680) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:594) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:151) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:653) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:590) at org.eclipse.equinox.launcher.Main.run(Main.java:1499) at org.eclipse.equinox.launcher.Main.main(Main.java:1472)

On the hosted site, the templates folder is not present hence the loading page is not appearing.

The server asks for token once and then sets an environmental variable with the token key and value. What should happen if the token is changed / expired? Should the LSP server check for the changes? Is there an API for that?

@jeffmaury
@geetikabatra

The server directory should be populated at build time. Storing those files in the git repo wastes both space and bandwidth

In some conventions, non API classes are usually kept under *.internal packages. It makes accidental public exposure of internal stuff less likely.
I recommend moving all internal classes to com.redhat.fabric8analytics.lsp.eclipse.internal. Anything that should be considered API can be left in the current package.
Only public packages should be exported in the manifest. See #36

Since the plugin is now dependent on the Openshift IO plugins, it should be added to the site.

At the moment, the LSP server is downloaded from this repository:

https://github.com/invinciblejai/fabric8-analytics-lsp-server/archive/test-devstudio.zip

I think it should be moved to jboss site.

WDYT @nickboldt @invincibleJai @geetikabatra

Need to add fabric8 analytics plugin to JBT and Devstudio update site.

https://github.com/jbosstools/jbosstools-devdoc/blob/master/source/how_to_add_a_plugin_or_feature_to_an_existing_project.adoc#add-a-new-plugin-or-feature-to-jboss-tools
https://github.com/jbosstools/jbosstools-devdoc/blob/master/source/publishing_features_downstream.adoc

The = operand should be changed to addAll

At the moment, the Stack Analyses view has only 3 states

• empty
• loading
• displaying stack analyses

Instead of empty view there should be information how you can run analyses or some button to run analyses over the whole workspace on one click. Also, when analyses is aborted by timeout or an exception occurs, the view should display some message.

Stack Analyses goes into infinite loop if the recommender api is not set

All exceptions should be properly handled - either the user should be informed that something went wrong (e.g. cannot connect to server) or it should be at least logged into the Eclipse error log.

If the node is not installed, an error message is displayed to user but it is covered by login window to OSIO. This is unnecessary. If node is not installed, the server should be disabled and no login should be attempted.

I'd like to ask about the need of authentication in fabric8 lsp server. Is it necessary to provide the user's token to run the server? Could it be changed to some anonymous mode?

The reason I am asking is that it complicates things quite a lot in Devstudio plugin.

First of all, the user might not want to login into OSIO at first. But the plugin will ask him to do so on every open of pom file. This would be very annoying so in order to prevent it we set an eclipse preference "Fabric8 analyses enabled" to false. User then needs to go to Eclipse Preferences in order to enable the analyses again and login into OSIO. But would he ever do that? If there was no OSIO login needed the analyses would work right away.

There are also other areas that will not be covered at all

• user deletes his/her token
• token is expired

How is this done in Visual studio plugin?

@invincibleJai @geetikabatra

At the moment, the analyses can run only for pom.xml filels. I've seen that in VisualStudio also package.json files were analysed.