the currently sound implementation in Source/i_sound.c is cryptic to me and I suspect it to be the cause for some of the apparently random occasional crashes. It may be best to port over the relevant parts (i.e. not libsamplerate, for example) of src/i_sdlsound.c from Chocolate Doom.

n.t.

It seems that the changes that the Wiggle-Fix applies to the MBF code base are smaller compared to the Vanilla code base. Thus, it might be desirable to interate this fix into MBF. However, I remember that the initial implementation was not fail-safe and some variable types had to be changed again in order to prevent crashes. Still not sure if it's worth the effort and risk.

We need something like Choco's -statdump option to check that general demo compatibility is maintained after each commit.

I guess the dlopen() trick doesn't really meet its audience and people just don't want (or understand) to copy DLL files around. As both PCX and BMP formats are really archaic nowadays we need PNG screenshots unconditionally. Therefore I will change the code to make them the default.

@AlexMax I guess we need a new cmake/findSDL2_Image.cmake snippet for this. Would you take care of that?

Basically, this commit:
coelckers/prboom-plus@923bb1b

MBF included a bunch of embedded lumps which are definitely not free.

As a brief summary:

• Lumps using the Doom font: M_AUTO, M_CHAT, M_COMPAT, M_ENEM, M_GENERL, M_HORSEN, M_KEYBND, M_MESS, M_NMARE, M_SETUP, M_STAT, M_VERSEN, M_WEAP. The Freedoom versions would probably work as reasonable stand-ins.
• The dog sprites are from Wolfenstein 3D: DOGS*. ZDoom has a free dog sprite set now that is CC licensed.
• Dog sound effects - unsure the provenance of these. Probably there are some public domain sounds out there that can be used.
• DSGETPOW, STBAR, STCFN096, STTMINUS, WIMINUS. I think these were not present in the Doom 1.1 IWAD and MBF included them as a pedantic compatibility measure so that you could play with any IWAD. Maybe it's not worth bothering to keep that compatibility?
• PLS1* and PLS2* - beta sprites. Move to betagrph.wad and embed some from Freedoom?

Few lines are clamped into one in Setup / Key Bindings / weapons section:

There are two problems after setting reset in General section:

• Aspect ratio resets to wider than 4:3
• SFX are not playing.

(excuse me for being too short, I'll check it more deeper in the evening if necessary)

FreeDoom's IWADs are called freedoom.wad, freedoom2.wad and freedm.wad. I would have to add these to the standard_iwads[] table in d_main.c and tweak the check for plutonia and tnt in CheckIWAD(), because freedoom2.wad contains characteristic lumps of both IWADs.

While MBF has an internal demo_compatibility mode for playback of Vanilla demos, this is far from perfect. I have added all the fixes from the http://prboom.sourceforge.net/mbf-bugs.html website in the https://github.com/fabiangreffrath/WinMBF/tree/demo_fixes branch, but most demos from Choco's quickcheck check still desync.

I am looking at you, Sunlust.wad!

Autoconf sanitizes file names to convert ! to -, making it so directories like /usr/share/doc/woof- appear on installation. Perhaps it's a better idea to use only alphanumerics.

no comment

Currently, it is impossible to clear key bindings in the corresponding menu. I have once provided a patch for PrBoom+ that could get ported over to MBF as well. Although this is strictly no faithful, it falls into the "quality of life" category.

@AlexMax Maybe you could have a look at this?

• In the Woof-0.9.0-win32.zip file created by the make package rule there are some spurious libraries:

  CheckerDependencyHandlingAnalyzerPlugin.dll
  CheckerOptionHandlingAnalyzerPlugin.dll
  SampleAnalyzerPlugin.dll

  What are they, where are they from and why are they installed into the package?

• The package is currently missing the three SDL2 libraries that the executable depends on. Is it somehow possible to add them (and their respective dependencies) to the package?

• How do I create a source tarball? And how do I add source files (e.g. beta.c, dogs.c, icon.c) that are not listed among WOOF_SOURCES?

Apply the original fix found in @fragglet's repository.

I get this message compiling with Visual C++

'strcasecmp' undefined; assuming extern returning int

The culprit is DirIsFile inside d_iwad.c. Looks like it's defined in d_io.h but apparently nothing in d_iwad.c currently includes it.

I managed to run Woof 1.0.0 only after pasting the DLLs from So Doom, not replacing those already bundled with it.

MBF still records mouse turn movement with single byte precision. Consider adding the code from Choco that carries yhe remainder over to the next tic.

seems like some defines not expected in the Windows toolchain are being used

make[2]: Entering directory '/home/chungy/Games/doom/woof/Source'
i686-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I..    -I/usr/i686-w64-mingw32/include/SDL2 -Dmain=SDL_main  -I/usr/i686-w64-mingw32/include/SDL2 -Dmain=SDL_main  -I/usr/i686-w64-mingw32/include/SDL2 -Dmain=SDL_main  -g -O2 -g -O2 -Wall -Wdeclaration-after-statement -Wredundant-decls -MT woof-z_zone.o -MD -MP -MF .deps/woof-z_zone.Tpo -c -o woof-z_zone.o `test -f 'z_zone.c' || echo './'`z_zone.c
In file included from doomdef.h:34,
                 from d_items.h:32,
                 from d_player.h:36,
                 from d_net.h:32,
                 from doomstat.h:40,
                 from z_zone.c:38:
../config.h:178: warning: "malloc" redefined
  178 | #define malloc rpl_malloc
      | 
In file included from z_zone.c:37:
z_zone.h:91: note: this is the location of the previous definition
   91 | #define malloc(n)          Z_Malloc(n,PU_STATIC,0)
      | 
In file included from doomdef.h:34,
                 from d_items.h:32,
                 from d_player.h:36,
                 from d_net.h:32,
                 from doomstat.h:40,
                 from z_zone.c:38:
../config.h:181: warning: "realloc" redefined
  181 | #define realloc rpl_realloc
      | 
In file included from z_zone.c:37:
z_zone.h:93: note: this is the location of the previous definition
   93 | #define realloc(p,n)       Z_Realloc(p,n,PU_STATIC,0)
      | 
In file included from info.h:35,
                 from p_pspr.h:46,
                 from d_player.h:37,
                 from d_net.h:32,
                 from doomstat.h:40,
                 from z_zone.c:38:
z_zone.c: In function ‘Z_Init’:
../config.h:178:16: error: ‘rpl_malloc’ undeclared (first use in this function); did you mean ‘_mm_malloc’?
  178 | #define malloc rpl_malloc
      |                ^~~~~~~~~~
z_zone.c:236:22: note: in expansion of macro ‘malloc’
  236 |   while (!(zonebase=(malloc)(zonebase_size=size + HEADER_SIZE + CACHE_ALIGN)))
      |                      ^~~~~~
../config.h:178:16: note: each undeclared identifier is reported only once for each function it appears in
  178 | #define malloc rpl_malloc
      |                ^~~~~~~~~~
z_zone.c:236:22: note: in expansion of macro ‘malloc’
  236 |   while (!(zonebase=(malloc)(zonebase_size=size + HEADER_SIZE + CACHE_ALIGN)))
      |                      ^~~~~~
z_zone.c: In function ‘Z_Malloc’:
../config.h:178:16: error: ‘rpl_malloc’ undeclared (first use in this function); did you mean ‘_mm_malloc’?
  178 | #define malloc rpl_malloc
      |                ^~~~~~~~~~
z_zone.c:387:21: note: in expansion of macro ‘malloc’
  387 |    while(!(block = (malloc)(size + HEADER_SIZE)))
      |                     ^~~~~~
make[2]: *** [Makefile:1584: woof-z_zone.o] Error 1
make[2]: Leaving directory '/home/chungy/Games/doom/woof/Source'

woof -file Cyber110.wad -deh Cyber110.deh -playdemo cy_itytd.lmp desyncs in MAP12 around gametic 16245.

Interestingly, I have come pretty far with regard to Boom 2.02 demo compatibility. You won't even get this demo past MAP01 with the original WinMBF. As a fun fact, the 30cyx1904.lmp Vanilla demo runs through with the same PWAD, so the issue must be somewhere in Boom 2.02 emulation.

The code is already there and could be taken from Crispy. This would make this port more "universal", because many huge maps are saved in these map formats nowadays. On the other hand, it will open a can of worms regarding rendering bugs that may occur in such large maps. anyway, I think the advantages may outweigh the risks in these cases.

It should be possible to toggle windowed and fullscreen mode from the menu, altough there is the Alt+Enter key combination already. This is still a deviation from full fatihfullness to DOS MBF in the name of quality of life improvements.

I have changed a lot more code than I initially assumed. Go through all these changes and add comments where appropriate.

Currently this spits a gazillion of warnings when compiling with -Wall, mostly redundant declarations and cosmetic stiff like this.

Also, this is a major blocker on the way to CI.

Hello,

I've got every SDL2 package that I could find installed on my Fedora 31 but in the end of the make command it complains like this:

make[2]: *** No rule to make target 'SDL2_MAIN_LIBRARY-NOTFOUND', needed by 'Source/woof'.  Stop.
make[1]: *** [CMakeFiles/Makefile2:207: Source/CMakeFiles/woof.dir/all] Error 2
make: *** [Makefile:152: all] Error 2

Any idea what package I'm missing?

Thank you.

EDIT: this is the list of packages the I've got installed:

dnf list installed *sdl*
Installed Packages
SDL.x86_64                                                     1.2.15-42.fc31                                        @updates-testing
SDL-devel.x86_64                                               1.2.15-42.fc31                                        @fedora         
SDL2.i686                                                      2.0.12-1.fc31                                         @updates        
SDL2.x86_64                                                    2.0.12-1.fc31                                         @updates        
SDL2-devel.x86_64                                              2.0.12-1.fc31                                         @updates        
SDL2_image.x86_64                                              2.0.5-2.fc31                                          @fedora         
SDL2_image-devel.x86_64                                        2.0.5-2.fc31                                          @fedora         
SDL2_mixer.x86_64                                              2.0.4-4.fc31                                          @fedora         
SDL2_mixer-devel.x86_64                                        2.0.4-4.fc31                                          @fedora         
SDL2_net.x86_64                                                2.0.1-9.fc31                                          @fedora         
SDL2_net-devel.x86_64                                          2.0.1-9.fc31                                          @fedora         
SDL2_ttf.x86_64                                                2.0.15-2.fc30                                         @fedora         
SDL_image.x86_64                                               1.2.12-22.fc31                                        @fedora         
SDL_image-devel.x86_64                                         1.2.12-22.fc31                                        @fedora         
SDL_mixer.x86_64                                               1.2.12-18.fc31                                        @fedora         
SDL_mixer-devel.x86_64                                         1.2.12-18.fc31                                        @fedora         
mingw64-SDL2.noarch                                            2.0.12-1.fc31                                         @updates 

I am going to port over support for drag-and-drop of WAD and DEH files onto the executable from Chocolate Doom.

Reportedly, they play back in sync in PrBoom+.

Find out if they are PrBoom demos actually. Find out if they would play back with WinMBF.

The Doom and Doom 2 IWAD distributed with the Doom 3: BFG Edition do contain PWAD headers instead of IWAD headers, and MBF is pretty strict about that and will refuse to load these IWADs.

However, what if these are your only available copies of the IWAD and you just want to try out? Should I sacrifice a part of historical faithfulness for the sake of maximum compatibility with all officially released doom IWADs?

Would you like this feature for this port?

As shown in the release thread, Woof! is able to load extremely huge maps such as planisf2, but there are a couple of rendering glitches. I guess I will merely have to port the fixes over from Crispy.

I am going to port the dynamic creation of IWAD search directories over from Chocolate Doom to tak into account install directories for e.g. GOG and Steam installations.

Converting sound samples to the target sample rate over and over again is expensive. Thus, sound samples should be cached in their target format. This should be optional but enabled by default. Not sure, though, if samples should be saved in system memory (i.e. malloc()) or zone memory (i.e. Z_Malloc()).

Steps to reproduce:

Start a map, open the menu, go to Options -> General. Toggle Fullscreen Mode on and off, on and off. the menu will change to page 2.

When trying to run Lilywhite Lilith this error occurs. Has never happened before so I have no idea what changed.

Mouse issues are still present as well, there is what feels like mouse acceleration being applied.

The Chaingun has been a bit wonky as well, firing erratically and inconsistently.

Hopefully we can nail these down.

While this is based off an MBF fork, it would be nice if you added a "-complevel 9" setting (or equivalent) so Boom compatible demos could be recorded (with all of the MBF features implemented into PrBoom-Plus's "-complevel 9" turned on).

A second feature request I have is working multiplayer support. Since PrBoom-Plus's netplay is busted, PrBoom 2.5 is slowly becoming even more obsolete, MBF 2.04 isn't supported in PrBoom-Plus, and Boom 2.02 and MBF 2.03 (with or without fixes) requires DOS for multiplayer, it would be nice to have a modern port of Boom/MBF which allows the recording of multiplayer demos for "-complevel 9" and "-complevel 11" (both with and without the 3 key bug fixed)

Another one of these in MSVC.

'strcasecmp' undefined; assuming extern returning int

Line 102.

More code to borrow from Choco/Crispy.

This means to dlopen() it during run-time instead of having it hard-linked during build-time.

With a 'c' this time. The WinMBF repository is missing all the documentation that was present in the binary and source releases.

There won't be support for Hacx as an IWAD, as this would mean too many quirks with the level progression. The same is true for Chex, btw.

But the port should work properly with Hacx if loaded as a pwad. I remember there were some mostly trivial fixes required for this.

Most probably I will have to take the mouse handling code from Chocolate Doom once again.

Congrats on 1.0.0! Had a few snags. Had to download zlib1.dll file to get it to launch. and W_GetNumForName: STTMINUS not found!,

Now that mouse and keyboard handling have been adapted, it's time to bring the joystick handling code on par with the implementation from Chocolate Doom 3.0.