ezzabuzaid / flutter-poc Goto Github PK

flutter-poc/lib/main.dart

Lines 91 to 93 in 417bf1b

 // TODO: the form should be invalid if any of the required field is missing 

 // TODO: fill all filed then make sure that the payload have them 

 }

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

add crashlytics

Lines 19 to 22 in 76caffd

 // TODO: add crashlytics 

 // await flutterCrashlytics.initialize(); 

 runZoned<Future<Null>>(

This issue was generated by todo based on a `TODO` comment in `76caffd`. It's been assigned to @undefined because they committed the code.

you need to provide a basic method like required()

flutter-poc/lib/shared/validators.dart

Lines 1 to 6 in 1e6bf7e

 // TODO you need to provide a basic method like required() 

 // and when invoking it use private property to handle the value 

 class Validators { 

 static maxLength(int max) {} 

 static required(value) {} 

 static pattern(RegExp pattern) {}

This issue was generated by todo based on a `TODO` comment in `1e6bf7e`. It's been assigned to @ezzabuzaid because they committed the code.

try to make function like `locateMe()` inside each class that should be singelto...

flutter-poc/lib/app/locator.dart

Lines 19 to 24 in 417bf1b

 // TODO: try to make function like `locateMe()` inside each class that should be singelton 

 locator.registerSingleton(Storage()); 

 locator.registerSingleton(TokenHelper()); 

 locator.registerSingleton<UserService>(UserService()); 

 locator.registerSingleton(Geolocator()); 

 locator.registerSingleton(LocalAuthenticationService());

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

implement onResponse

flutter-poc/lib/app/core/interceptors/url.interceptor.dart

Lines 23 to 28 in 3cba7b9

 // TODO: implement onResponse 

 return response; 

 } 

 // @override 

 // Future<RequestData> interceptRequest({RequestData data}) async { 

 // if (getHeaderValue(data.headers, EMutationRequest.defaultUrl)) {

This issue was generated by todo based on a `TODO` comment in `3cba7b9`. It's been assigned to @undefined because they committed the code.

Store the string in json (Setup localization)

flutter-poc/lib/app/pages/register/register.view.dart

Lines 71 to 76 in 417bf1b

 // TODO: Store the string in json (Setup localization) 

 validators.Required('This field is required'), 

 ]), 

 ), 

 SizedBox(height: 25), 

 TextFormField(

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

if there's not meals an error thrown, so it should be handled by filtering out t...

flutter-poc/lib/app/pages/home/home-meals.dart

Lines 16 to 21 in 6559e85

 // TODO: if there's not meals an error thrown, so it should be handled by filtering out the empty menus or by showing an empty icon or whatever 

 return Expanded( 

 child: GridView.extent( 

 children: List.generate( 

 bloc.meals.length, 

 (index) {

This issue was generated by todo based on a `TODO` comment in `6559e85`. It's been assigned to @ezzabuzaid because they committed the code.

update the icon to be filled, and meal details as well

flutter-poc/lib/app/pages/meals/melas.view.dart

Lines 54 to 58 in 9f43de0

 // TODO: update the icon to be filled, and meal details as well 

 }, 

 ) 

 ], 

 ),

This issue was generated by todo based on a `TODO` comment in `9f43de0`. It's been assigned to @undefined because they committed the code.

expectOne(findByKey('confirm_password'));

flutter-poc/lib/app/pages/register/register.view.dart

Lines 34 to 39 in 417bf1b

 // TODO: expectOne(findByKey('confirm_password')); 

 }); 

 }); 

 group('UserName field must', () { 

 testWidgets('have autofocus', (tester) async {

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

Figure a way to give a custom widget focus node

Lines 91 to 96 in 417bf1b

 // TODO: Figure a way to give a custom widget focus node 

 // CountryField( 

 // key: Key('country'), 

 // onChange: (Country country) { 

 // this.isoCountryCode = country.isoCode; 

 // },

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

Replace this string with constant from json file

Lines 60 to 65 in 417bf1b

 // TODO: Replace this string with constant from json file 

 expectOne(findDescendant(usernameField(), find.text('This field is required'))); 

 }); 

 testWidgets("bind it's value to payload model", (tester) async { 

 await buildPage(tester, LoginView()); 

 final value = 'testText';

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

various interceptor {take a look into angular buildozer interceptors}

flutter-poc/lib/app/pages/meals/meals.bloc.dart

Lines 54 to 58 in 20b90a5

 TODO various interceptor {take a look into angular buildozer interceptors} 

 TODO add git hocks for linting and check code healthy 

 fetch('https://reqres.in/api/users',{method:'POST', data:{ 

 "name": "morpheus",

This issue was generated by todo based on a `TODO` comment in `20b90a5`. It's been assigned to @ezzabuzaid because they committed the code.

update fav meal status here

Lines 13 to 16 in 6559e85

 // TODO: update fav meal status here 

 notifyListeners(); 

 } 

 }

This issue was generated by todo based on a `TODO` comment in `6559e85`. It's been assigned to @ezzabuzaid because they committed the code.

use a jwt token to verify that it's not expaired and valid token

flutter-poc/lib/app/shared/user.dart

Lines 22 to 27 in 76caffd

 // TODO: use a jwt token to verify that it's not expaired and valid token 

 } 

 getInformation() { 

 return _subject.stream; 

 }

This issue was generated by todo based on a `TODO` comment in `76caffd`. It's been assigned to @undefined because they committed the code.

implement push notification, broadcast, multicast and unicast

flutter-poc/lib/app/core/interceptors/logger.interceptor.dart

Lines 42 to 47 in 6024f02

 TODO implement push notification, broadcast, multicast and unicast 

 TODO setup the starter view, it should have a boxed meals and not menus (add home button)

This issue was generated by todo based on a `TODO` comment in `6024f02`. It's been assigned to @ezzabuzaid because they committed the code.

implement onError

Lines 11 to 16 in 3cba7b9

 // TODO: implement onError 

 return err; 

 } 

 @override 

 Future onRequest(RequestOptions options) async {

This issue was generated by todo based on a `TODO` comment in `3cba7b9`. It's been assigned to @undefined because they committed the code.

the below line should be in the teardown function

flutter-poc/test/widget.test/app_todo.dart

Lines 51 to 56 in 417bf1b

 // TODO the below line should be in the teardown function 

 tester.runAsync(() => tokenHelper.removeToken()); 

 }); 

 // TODO: enable that after testing the portal view and home view 

 testWidgets("Should redirect to Login if the token removed",

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

analytic and error service

flutter-poc/lib/app/app.dart

Lines 51 to 56 in 20b90a5

 TODO analytic and error service 

 TODO setup multiple environment 

 TODO setup file generation per screen 

 TODO various interceptor {take a look into angular buildozer interceptors} 

 TODO add git hocks for linting and check code healthy

This issue was generated by todo based on a `TODO` comment in `20b90a5`. It's been assigned to @ezzabuzaid because they committed the code.

setup localization

Lines 70 to 75 in 417bf1b

 // TODO: setup localization 

 const Locale('en'), 

 const Locale('ar'), 

 ], 

 routes: routes, 

 home: Scaffold(

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

assert that forgot password button is functional

flutter-poc/lib/app/partials/meals-details.dart

Lines 147 to 148 in 417bf1b

 // TODO: assert that forgot password button is functional 

 }

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

imagine that the user was added this item to it's cart

Lines 48 to 53 in c3627cf

 // TODO: imagine that the user was added this item to it's cart 

 // with quantity 4 therefore you cannot say that the value is zero 

 // and for that you need to send the quantity when open this dialog 

 int quantity = 0; 

 @override

This issue was generated by todo based on a `TODO` comment in `c3627cf`. It's been assigned to @undefined because they committed the code.

add git hocks for linting and check code healthy

flutter-poc/lib/app/pages/settings/settings.view.dart

Lines 55 to 58 in 20b90a5

 TODO add git hocks for linting and check code healthy 

 fetch('https://reqres.in/api/users',{method:'POST', data:{ 

 "name": "morpheus",

This issue was generated by todo based on a `TODO` comment in `20b90a5`. It's been assigned to @ezzabuzaid because they committed the code.

Enable this when finish setup all pages

Lines 46 to 51 in 95c11a9

 // TODO: Enable this when finish setup all pages 

 // Navigator.pushNamed(context, this.route); 

 } 

 }, 

 ), 

 ),

This issue was generated by todo based on a `TODO` comment in `95c11a9`. It's been assigned to @undefined because they committed the code.

move it to widget folder

flutter-poc/lib/app/pages/portal/register/register.view.dart

Lines 118 to 123 in f502474

 // TODO move it to widget folder 

 DropdownButtonFormField<Country>( 

 decoration: InputDecoration( 

 labelText: 'Country', 

 labelStyle: Theme.of(context).textTheme.body1, 

 enabledBorder: UnderlineInputBorder(

This issue was generated by todo based on a `TODO` comment in `f502474`. It's been assigned to @undefined because they committed the code.

Add your own signing config for the release build.

flutter-poc/android/app/build.gradle

Lines 46 to 51 in 6024f02

 // TODO: Add your own signing config for the release build. 

 // Signing with the debug keys for now, so `flutter run --release` works. 

 signingConfig signingConfigs.debug 

 } 

 } 

 }

This issue was generated by todo based on a `TODO` comment in `6024f02`. It's been assigned to @ezzabuzaid because they committed the code.

Password char check if it has uppercase and lowercase

flutter-poc/lib/app/pages/portal/register/register.view.dart

Lines 197 to 202 in f502474

 // TODO Password char check if it has uppercase and lowercase 

 validator: validators.validate([ 

 validators.Required(), 

 validators.MinLength(8), 

 ]), 

 onSaved: (value) {

This issue was generated by todo based on a `TODO` comment in `f502474`. It's been assigned to @undefined because they committed the code.

setup file generation per screen

flutter-poc/lib/app/pages/portal/register/register.view.dart

Lines 53 to 58 in 20b90a5

 TODO setup file generation per screen 

 TODO various interceptor {take a look into angular buildozer interceptors} 

 TODO add git hocks for linting and check code healthy 

 fetch('https://reqres.in/api/users',{method:'POST', data:{ 

 "name": "morpheus",

This issue was generated by todo based on a `TODO` comment in `20b90a5`. It's been assigned to @ezzabuzaid because they committed the code.

prevent special char

Lines 79 to 84 in f502474

 // TODO prevent special char 

 ], 

 validator: validators.validate([ 

 validators.Required('This field is required'), 

 validators.Between( 

 'Username must be between 8 and 16 char',

This issue was generated by todo based on a `TODO` comment in `f502474`. It's been assigned to @undefined because they committed the code.

fill all filed then make sure that the payload have them

Lines 92 to 93 in 417bf1b

 // TODO: fill all filed then make sure that the payload have them 

 }

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

setup multiple environment

flutter-poc/lib/app/pages/portal/register/register.view.dart

Lines 52 to 57 in 20b90a5

 TODO setup multiple environment 

 TODO setup file generation per screen 

 TODO various interceptor {take a look into angular buildozer interceptors} 

 TODO add git hocks for linting and check code healthy 

 fetch('https://reqres.in/api/users',{method:'POST', data:{

This issue was generated by todo based on a `TODO` comment in `20b90a5`. It's been assigned to @ezzabuzaid because they committed the code.

setup on blur validate for confirm password field

Lines 159 to 164 in b5ab5bf

 // TODO: setup on blur validate for confirm password field 

 this.payload.password = value; 

 }, 

 obscureText: true, 

 ), 

 SizedBox(height: 25),

This issue was generated by todo based on a `TODO` comment in `b5ab5bf`. It's been assigned to @undefined because they committed the code.

here it should be weather remove or add, find a way to set favorites meals

flutter-poc/lib/app/pages/meals/melas.view.dart

Lines 50 to 55 in 9f43de0

 // TODO: here it should be weather remove or add, find a way to set favorites meals 

 favoritesBloc.addToFavoritesMeals( 

 FavoritesModel(itemId: this.meal.sId), 

 ); 

 // TODO: update the icon to be filled, and meal details as well 

 },

This issue was generated by todo based on a `TODO` comment in `9f43de0`. It's been assigned to @undefined because they committed the code.

move the validation to validation module

flutter-poc/lib/app/pages/portal/register/register.view.dart

Lines 170 to 175 in f502474

 // TODO move the validation to validation module 

 // phone.PhoneNumberUtil.isValidPhoneNumber( 

 // isoCode: this.selectedCountry.isoCode, 

 // phoneNumber: value, 

 // ); 

 return null;

This issue was generated by todo based on a `TODO` comment in `f502474`. It's been assigned to @undefined because they committed the code.

Find a way to do the async validation

flutter-poc/lib/app/pages/portal/register/register.view.dart

Lines 169 to 174 in f502474

 // TODO Find a way to do the async validation 

 // TODO move the validation to validation module 

 // phone.PhoneNumberUtil.isValidPhoneNumber( 

 // isoCode: this.selectedCountry.isoCode, 

 // phoneNumber: value, 

 // );

This issue was generated by todo based on a `TODO` comment in `f502474`. It's been assigned to @undefined because they committed the code.

assert that remember is functional by checking the value of remember me

flutter-poc/lib/app/pages/login/login.view.dart

Lines 145 to 148 in 417bf1b

 // TODO: assert that remember is functional by checking the value of remember me 

 // TODO: assert that remember me doesn't save the token in localstorage 

 // TODO: assert that forgot password button is functional 

 }

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

assert that the logo is ready

Lines 34 to 39 in 417bf1b

 // TODO: assert that the logo is ready 

 // Logo(), 

 Form( 

 key: formKey, 

 child: Column( 

 crossAxisAlignment: CrossAxisAlignment.start,

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

Create base class to include the child class in the locator directly

flutter-poc/lib/app/locator.dart

Lines 16 to 21 in 417bf1b

 // TODO: Create base class to include the child class in the locator directly 

 void setupLocator() { 

 // REVIEW Locator has one critical issue which is cannot know which class depends on another so it should be order depend on that 

 // TODO: try to make function like `locateMe()` inside each class that should be singelton 

 locator.registerSingleton(Storage()); 

 locator.registerSingleton(TokenHelper());

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

enable that after testing the portal view and home view

flutter-poc/test/widget.test/app_todo.dart

Lines 55 to 60 in 417bf1b

 // TODO: enable that after testing the portal view and home view 

 testWidgets("Should redirect to Login if the token removed", 

 (WidgetTester tester) async { 

 await tester.runAsync(() => tokenHelper.setToken('J.W.T')); 

 await tester.pumpWidget(App()); 

 await tester.runAsync(() => user.isAuthenticated());

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

test the country widget first then expectOne(findByKey('country'));

Lines 31 to 36 in 417bf1b

 // TODO: test the country widget first then expectOne(findByKey('country')); 

 expectOne(findByKey('mobile')); 

 expectOne(findByKey('password')); 

 // TODO: expectOne(findByKey('confirm_password')); 

 }); 

 });

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

read about const, final, static in dart

Lines 40 to 45 in 6024f02

 TODO read about const, final, static in dart 

 TODO implement streaming and charts 

 TODO implement push notification, broadcast, multicast and unicast 

 TODO setup the starter view, it should have a boxed meals and not menus (add home button)

This issue was generated by todo based on a `TODO` comment in `6024f02`. It's been assigned to @ezzabuzaid because they committed the code.

assert that remember me doesn't save the token in localstorage

flutter-poc/lib/app/app.dart

Lines 146 to 148 in 417bf1b

 // TODO: assert that remember me doesn't save the token in localstorage 

 // TODO: assert that forgot password button is functional 

 }

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

theme functions should be moved to another class

Lines 14 to 19 in 417bf1b

 // TODO: theme functions should be moved to another class 

 static final settingBloc = locator<SettingsBloc>(); 

 App({Key key}) : super(key: key) { 

 // settingBloc.getSettings(); 

 }

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

find a way to test the geolocator getCurrentLocation(placeDetails)

flutter-poc/lib/app/pages/register/register.view.dart

Lines 43 to 48 in 417bf1b

 // TODO: find a way to test the geolocator getCurrentLocation(placeDetails) 

 future: Future.value(placeDetails), 

 initialData: placeDetails, 

 builder: (BuildContext context, AsyncSnapshot<Placemark> snapshot) { 

 isoCountryCode = snapshot?.data?.isoCountryCode; 

 return Container(

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

Enable it

flutter-poc/test/widget.test/app_todo.dart

Lines 27 to 32 in 417bf1b

 // TODO: Enable it 

 // tearDown(() async { 

 // tokenHelper.removeToken(); 

 // }); 

 // STUB make the FutureProvider fail by providing an error 

 // STUB update the app twice, every time with new bool value

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

implement streaming and charts

flutter-poc/android/app/build.gradle

Lines 41 to 46 in 6024f02

 TODO implement streaming and charts 

 TODO implement push notification, broadcast, multicast and unicast 

 TODO setup the starter view, it should have a boxed meals and not menus (add home button)

This issue was generated by todo based on a `TODO` comment in `6024f02`. It's been assigned to @ezzabuzaid because they committed the code.

Specify your own unique Application ID (https://developer.android.com/studio/bui...

Lines 35 to 40 in 6024f02

 // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html). 

 applicationId "com.example.learning_flutter" 

 minSdkVersion 16 

 targetSdkVersion 28 

 versionCode flutterVersionCode.toInteger() 

 versionName flutterVersionName

This issue was generated by todo based on a `TODO` comment in `6024f02`. It's been assigned to @ezzabuzaid because they committed the code.

assert expectOne(findByType(HomeView));

Lines 142 to 147 in 417bf1b

 // TODO: assert expectOne(findByType(HomeView)); 

 }); 

 }); 

 // TODO: assert that remember is functional by checking the value of remember me 

 // TODO: assert that remember me doesn't save the token in localstorage 

 // TODO: assert that forgot password button is functional

This issue was generated by todo based on a `TODO` comment in `417bf1b`. It's been assigned to @ezzabuzaid because they committed the code.

setup the starter view, it should have a boxed meals and not menus (add home but...