eynsherkiel / twill Goto Github PK

Hello. I found a small bug in your code. In GetUniqueBrush you check if List<Brush> contains some new Brush:

But SolidColorBrush is class:

Therefore Contains will check the equality of object references, that are always different.

I suggest replacing this code:
while (Brushes.Contains(resultBrush));
with this code:
while (Brushes.Any(brush => (Math.Abs(resultBrush.Color.R - brush.Color.R) + Math.Abs(resultBrush.Color.G - brush.Color.G) + Math.Abs(resultBrush.Color.B - brush.Color.B)) < 60));

In addition, it checks not only the equality, but the similarity