Git Product home page Git Product logo

community-admob-plus's People

Contributors

1n3jgkl9pq6cumrw avatar abdrahim-au avatar b3l7 avatar einfachhans avatar eliadafeka avatar ewisuri avatar eyalin avatar gregai avatar ifeddy avatar johnfitz1775 avatar longa1992 avatar martijnmichel avatar melvin-felix avatar mikkimichaelis avatar mkuklis avatar naveed-ahmad avatar netlob avatar ollm avatar petarov avatar peterjewicz avatar rastafan avatar ratson avatar rayros avatar rickgbw avatar sandervankasteel avatar slothentic avatar steebchen avatar yigit-serin avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

community-admob-plus's Issues

[iOS] CORS error when plugin (community-)admob-plus-cordova is added

Problem with iOS only.

I load static data from a local JSON file (fetch("staticData.json")). Since I use the plugin cordova-plugin-wkwebview-file-xhr, I have no CORS error.

Since I added the admob plugin (community-admob-plus-cordova last version or [email protected]), I have now the error CORS: Cross origin requests are only supported for HTTP.

There's probably an interference with (community-)admob-plus-cordova and cordova-plugin-wkwebview-file-xhr.

Have you faced the same issue?

testmode ads working ok but real ads - iOS

Hello,
When i set admob.configure({testDeviceIds: ['5c9e03fa207f0b705e48a5cc78242c68']}); test ads are working but when i delete it it's not working.
Any helps please?
Thanks

Test video / fallback video of bear and seagulls playing in iOS default video player as well as in the google player in testmode

Describe the bug
Sorry if this bug is a bit absurd, but a video of a bear (originates from Windows Vista, was used as a sample video for the .wmv codec back then) appears in the iOS default video player inside of the webview as an overlay. When you then show the loaded ad, the same video plays in the Google Video player.

When this bug occurs, the video simply pops up in the floating iOS video player from Safari Webkit. I assume this is either a fallback file if there was an error with the loaded video or that this is a test video that is falsely showing here. What is confusing me is why it is A) showing in the Safari video player and B) why it is showing if I'm not opting to show an ad anyway, it just pops up in some cases (rather rarely, around 0.2-.5%) after loading an ad.

This is the source of said video. I just hope that you guys have an idea where this video is from and why it is playing, if not, I'll try to get in touch with google and test whether this strange bug occurs without testmode as well.

To Reproduce
Steps to reproduce the behavior:

  1. Integrate the plugin
  2. Add all necessary id's and enable test mode
  3. Load rewarded video ads without showing them
  4. (Optional) When the bear video is showing, trigger the show ad event as fast as possible and when you are lucky the same video shows inside the Google Admob player

Expected behavior
The video of the bear with seagulls should not appear.

Screenshots
IMG_6991
IMG_6985
IMG_6989

Environment
Using Construct 3 and Chadori's plugin from the ConstructMasterCollection.

Additional context

Check whether Interstitial, Reward ads are loaded

After loading any ad we have a callback event. But if want to check a specific ad at any time that if it is available/loaded or not how we can do it?

Do we have isLoaded function to check for Reward, Interstitial, RewardInterstitial ads. How to do it?

Duplicate banners implemented previous work arounds, and have large number of crashes

First of all thanks for taking up this project.

I've implemented the work arounds in the issue over in the old repo.
admob-plus#450

document.addEventListener('pause', function() {
if (banner) {
console.log('pause hide banner');
banner.hide();
}
});
document.addEventListener('resume', function() {
if (banner) {
console.log('resume show banner');
banner.show();
}
});

and i've also passed the banner ID to banner load.

banner = new admob.BannerAd({
adUnitId: bannerId,
position: "top",
size: {
adaptive: "anchored"
},
id: _bannerId ? Number.parseInt(_bannerId) : null
}
);

I write the bannerId to local storage when it loads and read it when the app starts.

I get a lot of app crashes with:
AMBBanner.swift line 8 specialized static AMBBanner.updateLayout()
Fatal Exception: NSGenericException
Unable to activate constraint with anchors <NSLayoutYAxisAnchor:0x2810d14c0 "ServerLife.AMBBannerStackView:0
ร—10416c6f0.top"> and <NSLayoutYAxisAnchor:0x2810f4680 "UILayoutGuide:0ร—283ca8d20'UlViewSafeAreaLayoutGui de' top"> because they have no common ancestor. Does the constraint or its anchors reference items in different vie w hierarchies? That's illegal.

From what I can gather from my users this is happening when they come back from closing an Interstitial.

Before I move to this new repo, I'd like to know

  1. If the original issue has been fixed.
  2. What work arounds anyone else is using.
  3. Does anyone else have this crash.

Would it support android target api 33?

Google has sent this warning to apps that does not target API 33

To provide users with a safe and secure experience, Google Play requires all apps to meet target API level requirements.
From 31 Aug 2023, if your target API level is not within one year of the latest Android release, you won't be able to update your app.

So, I was wondering if this plugin would work ok with this upgrade from api 31 to 33?

Admob Native Crashes

This community-admob-plus sorted my issues with admob. My concern now is with the native admob.
I have sorted out the admob native. It displays but sometimes it crashes my app (guess when it is not loaded). My code is
if(ad.showfail || ad.loadfail){
//ad.show();
}else{
new Promise(function(resolve){
setTimeout(function() {
ad.hide();
resolve();

}, 12000);
});
ad.showWith(document.getElementById('nativeads'));
ad.load();
}

How can I catch the error? Please help!

After plugin installation: window.location.reload() open up the browser rather than reload the Ionic App

Describe the bug
After plugin installation: window.location.reload() open up the external browser rather than reload the Ionic App. If I uninstalled that plugin window.location function working perfectly again that it should be.

To Reproduce
Steps to reproduce the behaviour:

  1. Create an ionic app
  2. install the plugin 'cmd: ionic cordova plugin add community-admob-plus-cordova'
  3. apply the click function on any button and add the line 'window.location.reload()'
  4. you will see the app goes to the external browser with the localhost link.

Expected behaviour
window.location function should work within the Ionic App and navigate the app or reload it. Do not go to an external browser.

Screenshots
https://drive.google.com/file/d/1Qpo1xo3wwbKkEVN_ezlimUWAt1bALTrH/view

Environment

Ionic:

Ionic CLI : 7.1.1 (/usr/local/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 6.7.4
@angular-devkit/build-angular : 15.2.8
@angular-devkit/schematics : 15.2.8
@angular/cli : 15.2.8
@ionic/angular-toolkit : 8.1.0

Cordova:

Cordova CLI : 11.1.0
Cordova Platforms : android 11.0.0
Cordova Plugins : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 5.0.0, (and 21 other plugins)

Utility:

cordova-res : 0.15.4
native-run : 1.7.2

System:

Android SDK Tools : 26.1.1 (/Users/iamarslansaleem/Library/Android/sdk)
NodeJS : v18.15.0 (/usr/local/bin/node)
npm : 9.6.7
OS : macOS Unknown
Xcode : Xcode 14.3 Build version 14E222b

iOS SDK update?

Hello,
Thanks for the great work
Can you update to the latest ios sdk?
Thanks

Problem with Cordova consent and AdMob

Good Morning,

I have created my game with Gdevelop, for Android it has worked perfectly, but on iOS I find this recurring error. I don't know what else to do and I'm desperate, because I can't find a solution. I don't know if it's a conflict between cordova-plugin-consent and admob-plus-cordova, but I keep getting this error and I don't know what to do.

I```
nstalling "admob-plus-cordova" for ios

[!] The Jabali Espacial [Debug] target overrides the LD_RUNPATH_SEARCH_PATHS build setting defined in `Pods/Target Support Files/Pods-Jabali Espacial/Pods-Jabali Espacial.debug.xcconfig'. This can lead to problems with the CocoaPods installation

[!] The Jabali Espacial [Release] target overrides the LD_RUNPATH_SEARCH_PATHS build setting defined in `Pods/Target Support Files/Pods-Jabali Espacial/Pods-Jabali Espacial.release.xcconfig'. This can lead to problems with the CocoaPods installation
Adding admob-plus-cordova to package.json
Discovered plugin "cordova-plugin-consent". Adding it to the project
Installing "cordova-plugin-consent" for ios
Failed to install 'cordova-plugin-consent': Error: Command failed with exit code 1: pod install --verbose
Preparing

[!] CocoaPods could not find compatible versions for pod "GoogleUserMessagingPlatform":
In snapshot (Podfile.lock):
GoogleUserMessagingPlatform (= 2.1.0, >= 1.1)

In Podfile:
GoogleUserMessagingPlatform (~> 2.0.0)

Specs satisfying the GoogleUserMessagingPlatform (~> 2.0.0), GoogleUserMessagingPlatform (= 2.1.0, >= 1.1) dependency were found, but they required a higher minimum deployment target.


Adding admob-plus-cordova to package.json
Discovered plugin "cordova-plugin-consent". Adding it to the project
Installing "cordova-plugin-consent" for ios
Failed to install 'cordova-plugin-consent': Error: Command failed with exit code 1: pod install --verbose
Preparing

Analyzing dependencies

Inspecting targets to integrate
Using ARCHS setting to build architectures of target Pods-Jabali Espacial: (``)

Finding Podfile changes
A GoogleUserMessagingPlatform

  • Google-Mobile-Ads-SDK
I add the complete log in case it can help.

Thanks for your help.

I get these Xcode errors inside of AMBCore and AMBBanner

Describe the bug
I get these 2 Xcode errors when trying to build with the plugin (see screenshots)

To Reproduce
Steps to reproduce the behavior:

  1. Build with cordova and install the pods
  2. See the issue inside of xcode (latest version)

Expected behavior
There should be no errors

Screenshots
Bildschirmfoto_2023-04-23_um_21 46 56
Bildschirmfoto_2023-04-23_um_21 51 57

Environment
Using construct 3 and building with cordova and this addon.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.