Solve issues for Node.js CITGM about express HOT 11 CLOSED

This is officially completed! Express.js is back to the CITGM! 🎉

from express.

Yes, I fixed that a long time ago, also in this repo too, which is probably why you cannot reproduce it while running tests locally from clone?

from express.

Curent status

We are just waiting for this PR to be merged, the CI is passing 🥳

from express.

Great point @dougwilson. Now I am thinking that maybe is because CITGM is using 4.18.2 and the patch in [email protected] is not yet released within express? 🤔

unreleased
==========

  * Fix routing requests without method
  * deps: [email protected]
    - Fix strict json error message on Node.js 19+
    - deps: content-type@~1.0.5
    - deps: [email protected]

4.18.2 / 2022-10-08
===================

  * Fix regression routing a large stack in a single route
  * deps: [email protected]
    - deps: [email protected]
    - perf: remove unnecessary object clone
  * deps: [email protected]

from express.

Oh, interesting. I guess that is true, if citgm uses published vereion it wouldn't be there. I was confused bc I saw the log saying downloading from github.com. I guess we can queue up a parch release quickly to make it available to citgm, without going through the minor release timeline.

from express.

Yeah, a patch release sounds great 👍

from express.

Could we maybe do a release as a group on video? One of the things we're gonna need to get better at is training people and how to do these things safely and with the correct procedure. This seems like a good one to get started with.

from express.

Oh, ok, good thing you mentioned! I wqs gonna try and squeeze it in today so we could get the citgm checked off, but I can hold off for us to find a time and day to do it together.

from express.

Obviously we want to land the 5 release soonish, but other than that do we have anything pending to use as an example to record for educational purposes?

from express.

This was just to make a patch for 4 for citgm to use. Happy to do whatever. I have to leave in about 45 mins, and was on to do this patch before the work week starts and I get more limited, but happy to di whatever we want, just let me know. I'll keep holding until I hear more.

from express.

To circle back, there was not time today to finish the CICD and also record this release. We will try and get a recording in a future release, so going to mark my comments and the rest as off topic. Sorry for delaying it.

from express.