Git Product home page Git Product logo

Comments (3)

krzysdz avatar krzysdz commented on April 28, 2024

This is not a problem with express or hbs. The problem is passing user-controlled input to res.render.
The express documentation says:

The locals object is used by view engines to render a response. The object keys may be particularly sensitive and should not contain user-controlled input, as it may affect the operation of the view engine or provide a path to cross-site scripting. Consult the documentation for the used view engine for additional considerations.

from express.

joeyguerra avatar joeyguerra commented on April 28, 2024

For further reference, please review OWASP C5: Validate All Inputs.

I'm currently thinking that since hbs knows it's own schema, it could mitigate this issue by disallowing its core underlying design schema from the view model being passed in.

@Shruti-Ramenahalli have you considered submitting a pull request to the hbs repo with a suggested design fix?

from express.

wesleytodd avatar wesleytodd commented on April 28, 2024

If you believe there is a security issue please see our reporting guidelines.

from express.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.