expensivekoala / fishing-real Goto Github PK

When using this mod together with "Boids" from Tomate0613; when you get a fish and try to reel it in, they never land where they're supposed to land: somewhere alongside the feet of the player, instead they always land in the water.

Mods such as Effishiency work by changing the stacksize of the item being fished.
To increase compatibility with Effishiency and other similar mods (and maybe datapacks) we should spawn an entity per-item in the itemstack.

Hi, for some context, i have a small server where i play with my friends, used the mod and worked flawlessly, but since i updated to 1.6 both the server and client continue crashing. I verified by downgrading the mod that it only happens with the 1.6 version
Here is the log, i suck at reading logs so i can't really understand the issue
https://mclo.gs/NyDFLpp

When both mods are installed, more frequently only quality crops "fish item" is fished instead of the proper fish entity
(Mod does not work properly)

This does not matter with vanilla fishes, but I am currently playing a mod called Environmental which adds a fish which use a noise-based system to determine what variant should be spawned based on the world coordinate. However, since fishing real always spawns the fish at some set location and, all fished koi will only be 1 set variant that will rarely be the same variant as the koi that would naturally spawn there.

This feature wouldn't really affect fishes in vanilla, but should patch up other edge cases where some fish mobs have variants depending on the coordinate/biome spawned. I would really appreciate, thank you

I Want To Fish When It Comes To Real Fishing Because Many Mods Can't Do That.

1.19.2 Forge
version Fishingreal-1.19.2-1.6.1.jar

Aquaculture-1.19.2-2.4.8.jar

Fish pulls from rod only spawn item and not the mob
Have tried with data pack and without data pack
How do you fix this?

the mob fish seemed to have the same name as the item and not the spawn egg.

Hey, I was just wondering if I could get some help making my own data pack for this mod, I've tried to make one, but it never works. I know I'm obviously doing something wrong, but I can't figure out what. It would be nice if I got some step-by-step instructions on how to do it. Thanks!

PS: you should make it so a fish entity has to bite the line for you to reel it in, if that's possible?

I am making a modpack and most mods are with fabric, so I can't use this, but I want to.

I've tested a while and noticed that I couldn't get any other item from fishing, here's my latest.log:
latest.log

crash-2023-07-11_12.24.10-client.txt
Haven't tried using the 1.19.4 datapack for aquaculture yet however

you put real instead of reel smh

https://github.com/TeamMetallurgy/Aquaculture/blob/master/src/main/java/com/teammetallurgy/aquaculture/entity/AquaFishingBobberEntity.java#L170-L192

As was brought up in #18, the current support for Aquaculture is very limited.
Bait consumption and Double fish chance happen after the first ItemFishedEvent fires (and gets cancelled) so they never happen.

I created a datapack to convert items to entities as suggested on the mod's Curseforge page, and it fails to convert the koi fish from Critters and Companions version 1.18.2-1.0.2. It successfully converts the koi in versions 1.19.2-1.1.2 and 1.19.2-1.0.2.

My 1.18.2 datapack has the proper pack format and successfully converts other modded fish (e.g. upgrade_aquatic:nautilus).

I asked the author of the Critters and Companions mod about it, and they responded: "Koi fish is exactly the same entity in 1.0.2 and 1.1.2."

This is what I have in the json:

{
"input": {
"item": "crittersandcompanions:koi_fish"
},
"result": {
"id": "crittersandcompanions:koi_fish"
}
}

Hello! I'm using this mod in an upcoming modpack, soon to be released. I really love the concept of fishing up random fish that are alive. But it would be nice if we could have optional results. For example, it could have a weight to gather an item or the living mob entity, or even some other loot table entry.

{
  "input": {
    "name": "minecraft:salmon"
  },
  "result": [
    {
      "type": "item",
      "name": "minecraft:salmon",
      "weight": 10
    },
    {
      "type": "entity",
      "name": "minecraft:salmon",
      "weight": 5
    },
    {
      "type": "loot_table",
      "name": "namespace:chests/fishing_treasure",
      "weight": 1
    }
  ]
}

These changes could make the mod Fishing Real very versatile allowing modpacks/datapack creators to provide new play experiences. Please let me know if you'd be interested in adding these features.

I think you should add compat for Aquacultures weight feature, so you can reel in a fish and still have it display its weight.

So while playing I was thinking it would be cool if you could add in an item like a net which if a player holds it in their offhand while fishing it would make the fish caught act as if the mod was not enabled or fill buckets of water with the fish to make fishing in the middle of the water viable.

Hey.. I'm not sure if this is the correct section to make suggestions; so sorry if its not but I have a request. I really want to add fish from Aquaculture 2 to Fishing Real and I have looked absolutely everywhere for a tutorial how but have had no hope. I created a folder named fishing inside my servers datapacks like the instructions insisted and placed all the fishes jsons or something. Sadly that did nothing.

In the latest forge versions the 1.18.x version of the mod gets the "failed to load correctly" error, specifying "java.lang.NoClassDefFoundError: net/minecraft/tags/Tag$Named

Any chance?

Hello o/

I could use some help with getting the datapack made correctly, as I can't seem to get it right. Would you mind having a look at what I have currently?

enigmatica.zip

Bonus info: The datapack works, as the other namespace in there is working without issues.

I Want To Fish When It Comes To Real Fishing Because Many Mods Can't Do That.

I'm working on a modpack that includes Aquaculture 2, Upgrade Aquatic, and Fishing Real, however, after making a global datapack with Openloader, I'm still getting regular items and not summoning actual fish. The Openloader folder is structured as so:

openloader

data

Lonely Datapack

data
pack.mcmeta

fishingreal

fishing

arapaima.json
arrau_turtle.json
atlantic_cod.json
atlantic_halibut.json
etc.

An archive of the folder can be found on my Google Drive.