Hi,

I was starting to implement a helper to easier create "mock objects" for Pester tests from real world examples. I stumbled across "ConvertFrom-ObjectToString" which does much of the tasks I was looking for.

I would like to enhance the generated string to handle property values

• that are $null
• contain an array value
• are hashtables
  in a simple fasion.

Before I create a PR I would like to understand the use case for the "$Object -is [System.Collections.IDictionary]" part.
Using my testcases, it will never get executed, because "$Object -is [Object]" already gets valid.
From my point of view, I would check for [IDictionary] before the more general "[Object]".

Can you tell me, how you use the 'IDictinionary'?

Best regards,
Wolfgang

Hi,

In Get-ComputerTask.ps1 Actions is empty.
Indeed the Actions only exist in Get-ScheduledTask.

Test on Windows Server 2016.

error in PSSharedGoods.psd1

RequiredModules = @(@{ModuleName = 'PSWriteColor'; GUID = '0b0ba5c5-ec85-4c2b-a718-874e55a8bc3f'; ModuleVersion = '0.87'; },
@{ModuleName = 'Connectimo'; GUID = 'e4f4f8a6-473e-4ba5-8166-480658c11421'; ModuleVersion = '0.0.5'; })

RequiredModules = @(@{ModuleName = 'PSWriteColor'; GUID = '0b0ba5c5-ec85-4c2b-a718-874e55a8bc3f'; ModuleVersion = '0.87.0'; },
@{ModuleName = 'Connectimo'; GUID = 'e4f4f8a6-473e-4ba5-8166-480658c11421'; ModuleVersion = '0.0.5'; })

The first time I open ISE I enter the get-module command, everything is clean, there are no extra modules. And if I enter the command Get-Module -ListAvailable, modules appear in the list immediately
Connectimo
PSSharedGoods
PSWriteColor
I don't understand what I did to make these modules load automatically

If you are using the Get-WinADForestControllers command via PSRemoting, it happened to me, that that i got the following erro:
Get-ADForest : Unable to contact the server. This may be because this server does not exist, it is currently down, or it does not have the Active Directory Web Services
running.

The issue is the Get-ADForest command within this function.
It can be solved, if the Get-ADForest command will be run with the Credential Parameter.

Because of this, I would like to add the Credential Parameter to the Get-WinADForestControllers command and pass this parameter to the Get-ADForest command.

I will create a pull request to fix this issue.

Hello,

I would like to know if you plan to add a -Credential parameters into the Get-Computer* CMDlets in a near future.
Indeed, when we work with trusted domain, we need sometimes to specify another account.

I ran some tests on my own with the Get-ComputerApplication and it works fine. But for others functions, it needs some work.
Before doing a PR, I would like to know your point of view.

Thanks

After reading through this blog post https://get-powershellblog.blogspot.com/2017/06/how-safe-are-your-strings.html I thought it might be worth mentioning that adding an end{} with the following could be more secure.

End {
$OldPasswordPlain = $Null
$NewPasswordPlain = $Null
[System.GC]::Collect()
}

Pester seems to be a good PowerShell testing library: https://github.com/pester/Pester

IMHO unit tests add to better code quality and ease refactoring, so you should consider this, IMHO.

The current tests are rather integration tests? Or they do not really use a library: https://github.com/EvotecIT/PSSharedGoods/blob/master/Public/TestFunctionality/Test-ComputerPort.ps1
Basically it seems to be for manual testing, but Pester can e.g even mock stuff, so it may be possible to test more stuff.

Found it on https://stackoverflow.com/questions/1004424/is-there-a-unit-testing-framework-for-testing-powershell-with-powershell-scripts?noredirect=1&lq=1

Not sure if this was on purpose or not, but the English word "Settings" should only have 2 T's but the function name has 3. The file name it resides in is correct though.

Helllo,

I'm using this code to download two modules:
Initialize-ModulePortable -Name 'ADEssentials' -Download -Path "$ScriptDirectory\Modules" Initialize-ModulePortable -Name 'PSWriteHTML' -Download -Path "$ScriptDirectory\Modules"
in the folder I get back this result

:
If i look inside the ADEssentials.ps1 I see that there are all modules added.
PSWriteHTML.psd1
PSEventViewer.pds1
ADEssentials.psd1

Why the PSWriteHTML.psd1 is also added?
When I change the download order, this has no effect. Every time it is addes to the ADEssentials.psd1 file.
Correct me if I'm wrong, but normaly in this file only the module should be addes for the provides module??

Thanks.

When using PS normal console's auto-complete, the address that auto completed contains a slash at the end.
In this case, the function (in line 79 in "Initialize-ModulePortable.ps1") does a replace of $path (that includes '\' at its end) to $psscriptroot, that causes the final result to be without the slash after $psscriptroot.

For example, if I run this command:

Initialize-ModulePortable -Name FileSplitter -Path C:\Users\Me\Desktop\ -Download

The file that will be created will contain that:

$Modules = @(
   "$PSScriptRootfilesplitter\1.3\FileSplitter.psd1"
)
foreach ($_ in $Modules) {
   Import-Module $_ -Verbose:$false -Force
}

If I am right in my diagnosis, it can be fixed by checking if $Path contains a slash (or back-slash) at its end and delete it.

found this issue when I run
Invoke-Testimo -ReturnResults -Sources DCServices

reference: https://github.com/EvotecIT/Testimo/blob/master/Private/SourcesDomainControllers/Services.ps1

Warning "Get-CimData - No data for computer Computer. Most likely an error on receiving side."

Note: it still works when running the function using the "-All" switch parameter

Why do you convert the datatypes all to string?
Is it needed?

... Line 99
elseif ($Object.GetType().Name -in 'String', 'DateTime', 'TimeSpan', 'Version', 'Enum') {
$Object = $Object.ToString()
} elseif ($Depth)
...

Best Regards

When using:

• #36

Variables get autopopulated on read, not sure why

According to the NtpServer doc reference, the flags that can be associated with external NTP servers are:

0x01 SpecialInterval
0x02 UseAsFallbackOnly
0x04 SymmetricActive: For more information about this mode, see Windows Time Server.
0x08 Client

But the code defines them without the appropriate leading zero which breaks the string matching later in the function.

So if NtpServer is set to a value like 0.pool.ntp.org,0x08 1.pool.ntp.org,0x08, it shows up as NtpServerIntervals : {Incorrect, Incorrect} instead of NtpServerIntervals : {Client, Client} in the function output.

As a tangential issue, these are bit flags that can be combined. So you may want to either change the code to interpret them as such, or include all combinations of the flags in the $NtpServerInterval definition like this:

$NtpServerIntervals = @{
    '0x01' = 'SpecialInterval'
    '0x02' = 'UseAsFallbackOnly'
    '0x03' = 'SpecialInterval+UseAsFallbackOnly'
    '0x04' = 'SymmetricActive'
    '0x05' = 'SpecialInterval+SymmetricActive'
    '0x06' = 'UseAsFallbackOnly+SymmetricActive'
    '0x07' = 'SpecialInterval+UseAsFallbackOnly+SymmetricActive'
    '0x08' = 'Client'
    '0x09' = 'SpecialInterval+Client'
    '0x0A' = 'UseAsFallbackOnly+Client'
    '0x0B' = 'SpecialInterval+UseAsFallbackOnly+Client'
    '0x0C' = 'SymmetricActive+Client'
    '0x0D' = 'SpecialInterval+SymmetricActive+Client'
    '0x0E' = 'UseAsFallbackOnly+SymmetricActive+Client'
    '0x0F' = 'SpecialInterval+UseAsFallbackOnly+SymmetricActive+Client'
}