evgenyorekhov / actus Goto Github PK

redux-devtools-extension

https://github.com/fuzetsu/mergerino

• actus-default-actions
• actus-localstorage
• actus-logger
• actus-freeze
• actus-redux-devtools?

Similar to https://github.com/microstates/microstates.js.

• #6 Add support for slice actions

joi or Yup?

• Try specific packages
• Try https://github.com/selfrefactor/rambda (doesn't have mergeDeep())
• Try https://github.com/TinkoffCreditSystems/utils.js
• Try https://www.npmjs.com/package/nanoutils

Similar to https://redux.js.org/recipes/structuring-reducers/using-combinereducers/.

It might be not needed if #5 is implemented by adding redux-devtools-extension integration.

• https://github.com/FormidableLabs/freactal (some parts of the effects API)
• https://github.com/dvajs/dva/tree/master/packages/dva-loading

Current API

The following forms are supported by default:

1. (value, state) => nextState
2. (value) => nextState
3. () => nextState
4. (value) => (state) => nextState

Pros:

• form 2 allows to omit state
• form 3 allows to omit both value and state
• form 4 works well with Ramda, BUT most of the time you end up needing to read something from state, so you end up writing something like (value, state) => pipe(/* uses value and state */)(state), so the usage of point-free style ends up being impossible, AND this feature can actually be easily added to other forms with the help of the getNextState option

Cons:

• form 1 looks like a reducer, but the parameters are flipped, which might be confusing for people coming from Redux
• form 1 doesn't allow to omit value, have to write (ignore, state) => nextState
• the existence of both form 1 and form 4 make API overloaded
• hard to extend with new parameters

Proposed APIs

Reducer API

1. (state, value) => nextState
2. (state) => nextState
3. () => nextState

Pros:

• conventional reducer signature, just like in Redux
• form 2 allows to omit value
• form 3 allows to omit both state and value

Cons:

• form 1 doesn't allow to omit state, have to write (ignore, value) => nextState
• hard to extend with new parameters

Object API

1. ({ state, value }) => nextState

Pros:

• any parameter can be omitted
• can be easily extended with any number of parameters

Cons:

• unconventional
• have to use the names state and value (you can do something like ({ state: users, value: newUser }) => ..., but it's not as convenient as with positional parameters)

Notes:

• Is value the best name? How about argument? Or a more conventional payload?

Verdict

If actus is going to add support for something like async actions (or effects), the current API will have to be extended, and the best candidate for extension is the Object API.

Similar to https://github.com/react-stack/redux-storage.

https://www.npmjs.com/package/aggregate-error

Immer gets in the way even when you're not using it:

TypeError: Cannot perform 'isExtensible' on a proxy that has been revoked

It would be better for subscribers to be tolerant to other subscribers' errors.

Reproducible case: https://github.com/EvgenyOrekhov/super-rentals/tree/must-use-import-to-load-es-module-bug

$ npm start

> [email protected] start C:\super-rentals
> ember serve

Must use import to load ES Module: C:\super-rentals\node_modules\actus-ember\index.js
require() of ES modules is not supported.
require() of C:\super-rentals\node_modules\actus-ember\index.js from C:\super-rentals\node_modules\ember-cli\lib\models\package-info-cache\package-info.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from C:\super-rentals\node_modules\actus-ember\package.json.

Probably should be something like inject(target, config).

https://www.npmjs.com/package/deep-freeze

• Should be optional
• By default should work only when not in production mode

• Add commonjs version (fixed in 4489902)
• Add an older version of Node.js to .travis.yml
• Declare that older version in engines in package.json

• actus-default-actions
• actus-logger
• actus-redux-devtools?
• actus-freeze?

The reason is that subscribers are notified on state changes, not on action calls. This behavior is by design. Not sure what to do here. Perhaps turn the logger plugin into a special internal subscriber that will be notified on action calls, not on state changes.

https://gist.github.com/srdjan/1d10cbd42a2d695f696dee6b47fdc5e0

• Add proper documentation first

Draft: https://github.com/EvgenyOrekhov/js-framework/blob/master/src/framework/localStorageManager.js.

Can be done by the means of conditional require() calls.