Git Product home page Git Product logo

Comments (5)

freekmurze avatar freekmurze commented on May 27, 2024 1

it'll be less of a hassle for the laravel package, but it'd be much more of a hassle for the main implementation.

Didn't think too much about that problem, I was focused on making it as easy as possible for the users of the Laravel package.

Even just using all of the traits from the laravel one would be trivial to setup right?

That's true

Thanks for your input here! 👍

from eventsauce.

frankdejonge avatar frankdejonge commented on May 27, 2024

@freekmurze in the laracon workshop I just used the CreatesApplication trait from Laravel, perhaps we can ship with an additional baseclass which extends the eventsauce one and adds CreatesApplication?

from eventsauce.

freekmurze avatar freekmurze commented on May 27, 2024

@frankdejonge That works too indeed. But by only putting on CreatesApplication you'd still miss the other methods provided by the InteractsWithContainer, InteractsWithConsole, InteractsWithDatabase, MocksApplicationServices traits and so on.

If the current AggregateRootTestCase would be refactored so all methods are in a trait you could choose the style you want. Want to extend AggregateRootTestCase? Fine! Want to use the base test of your project (that you might have customized a bit), just add the TestsAggregateRoot trait to it.

from eventsauce.

frankdejonge avatar frankdejonge commented on May 27, 2024

Doesn't laravel provide a single trait to combine those all? Extracting the behaviour from our base class is not trivial because of all the methods used from its base class provided by PHPUnit, which then all need to be added as abstract ones, through which it'd be very hard to detect when things are changing. I agree it'll be less of a hassle for the laravel package, but it'd be much more of a hassle for the main implementation.

from eventsauce.

frankdejonge avatar frankdejonge commented on May 27, 2024

Even just using all of the traits from the laravel one would be trivial to setup right?

from eventsauce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.