`AggregateRootBehaviourWithRequiredHistory::reconstituteFromEvents` is incompatible with `AggreagateRoot::reconstituteFromEvents` about eventsauce HOT 6 CLOSED

I'll have a think about it. I personally don't use the required history and adding a method specifically for this seems a bit overkill. An option could also be to wrap the AggregateRootRepository into something that DOES hint it can through this, would that work for you?

from eventsauce.

I feel that the root of the problem is that:

    public function retrieve(AggregateRootId $aggregateRootId): object;

in AggregateRootRepository does not return ?object. This would be the behavior I would expect (and have seen) for pretty much any Storage system.

If I ask for something and it does not exist, let me know. right now it auto-magically will create it. This might be intended behavior for some cases, but it is IMHO very non-intuitive. And it results in this situation with incompatible implementations.

But you could have the intuitive behavior:

interface AggregateRootRepository
{
    public function retrieve(AggregateRootId $aggregateRootId): ?object;
}

and 2 implementations, one that returns ?object and another that returns object. No exception, no incompatibilities.

from eventsauce.

and if you feel like having only one ConstructingAggregateRootRepository, you could even template it like this:

/**
 * @template T of bool
 */
class ConstructingAggregateRootRepository
{
    /**
      * @param T $constructOnNoneExistant
      */
    public function __construct(
        string $aggregateRootClassName,
        MessageRepository $messageRepository,
        MessageDispatcher $dispatcher = null,
        MessageDecorator $decorator = null,
        bool $constructOnNoneExistant = true
    )
    
    /*
     * @return (T is true ? object : ?object)
     */
    public function retrieve(AggregateRootId $aggregateRootId): ?object

}

from eventsauce.

In terms of BC breaks:

• functionally it is the same (at runtime, the same output for the same inputs as the old code)
• ConstructingAggregateRootRepository is final, so more constructor parameters are OK
• The SA is very different. However, for the 2 most widely used (Psalm and PHPStan) it would just ask for template types if the repository is assigned to a variable or being a return type.

from eventsauce.

Related to #48
There is a detailed explanation.

from eventsauce.

This will be fixed in v1.0. Thanks all.

from eventsauce.