Git Product home page Git Product logo

Comments (1)

frankdejonge avatar frankdejonge commented on May 27, 2024

@simsim2006 Hi, thank for providing feedback to this repository. While I see the effects of your case, there is something wrong with this implementation, which is: your event application has a side effect. If you reconstitute your model, every time you do so, this ChildCried event will be recorded, which is no longer a recording of an actual domain event, it's an (incorrect) side-effect of your setup. So while your PR will fix it, it will not fix this side-effect. You can of course hide the by using snapshots, but now the promise between your snapshot and the regular reconstitution is broken as they should lead to the same state.

TL;DR: the case you present is indeed seemingly out of order, but the case itself is broken.

from eventsauce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.