evemuproject / evemu_control_panel Goto Github PK

PROBLEM:
The New Account section in the Account/Character Creation tab is inserting what looks like a hash into the 'password' field of the database table 'account'. I think this is behavior that was left from the days of Apocrypha support by both the server and EVEmu Control Panel and just like Issue #12, something needs to change to either identify type of database or provide for selection of database type in the EVEmu Control Panel GUI.

Personally, like on Issue #12, I'd prefer the first one, where we identify the database with our own table and data in it.

STEPS TO REPRODUCE:

1. open EVEmu Control Panel and connect to your database in the normal way
2. switch to the Account/Character Editor tab
3. Under New Account, enter your desired username, password, and select role in the drop down box, then click Add
4. go view the 'account' table in your database and check the 'password' field for the account you just created

PROBLEM:
When using EVEmu Control Panel to create user accounts in the Account/Character Editor tab, the "Acct Level", which is used to set the role value of the account, is using role values that are appropriate for the Apocrypha client and no newer clients as of Incursion. This should be solved either one of two ways:
1. Either provide some identifying area in the database itself that can be queried by EVEmu Control Panel and determine which version of the database is being accessed and provide appropriate role values (and for all other parts of the EVEmu Control Panel code to use appropriate queries, etc)
2. Provide a drop down box to select the type of database on the SQL Settings tab that will provide a globally known database type, that is then checked in all areas of the code to use appropriate queries, etc.

Personally, I vote for #1 since it is universal and eliminates some errors on the part of the user of the EVEmu Control Panel setting the right database type.

STEPS TO REPRODUCE:

1. open EVEmu Control Panel and connect to your database in the normal way
2. switch to the Account/Character Editor tab
3. Under New Account, enter your desired username, password, and select role in the drop down box, then click Add

in mainF.cs marketGroupsTree_AfterSelect(...) method variables level0, level1 and level2 are filled incorrectly, in a sense that they are not top-level, second-level and third-level indexes, which cuases index out of bounds exception when used for tree indexing.

I'm attaching the patch (though I can't really see attach file button, so it will go here)

diff --git a/src/GUI/mainF.cs b/src/GUI/mainF.cs
index faef639..b315ef7 100644
--- a/src/GUI/mainF.cs
+++ b/src/GUI/mainF.cs
@@ -1065,10 +1065,13 @@ namespace Evemu_DB_Editor
                 level0 = marketGroupsTree.SelectedNode.Parent.Index;
                 if (marketGroupsTree.SelectedNode.Parent.Parent != null)
                 {
-                    level1 = marketGroupsTree.SelectedNode.Parent.Parent.Index;
+                    level1 = level0;
+                    level0 = marketGroupsTree.SelectedNode.Parent.Parent.Index;                    
                     if (marketGroupsTree.SelectedNode.Parent.Parent.Parent != null)
                     {
-                        level2 = marketGroupsTree.SelectedNode.Parent.Parent.Parent.Index;
+                        level2 = level1;
+                        level1 = level0;
+                        level0 = marketGroupsTree.SelectedNode.Parent.Parent.Parent.Index;
                     }
                 }
             }

I intent to start work on asteroids seed feature. The GUI does not seem difficult but I have no idea what to put in the database. (Probably into entity table?) Any ideas where I can get further information?

PROBLEM:
When using the Seed Market tab in Evemu Control Panel, no matter what you do to generate a SQL query for whatever items from the database you want to seed, the query will never include raceID = '0', which covers quite a few important items such as charges, modules, blueprints and over 13,000 item types in total.

STEPS TO REPRODUCE:

1. Open EVEmu Control Panel
2. Connect to your database
3. Switch to Seed Market tab
4. Select any number of raceIDs, select solar system(s) or region(s), select Categories, and select one or more Groups
5. Select Market Saturation more than 0%, uncheck Apply to Database, set your quantity and hit the Seed Market button
6. View the SQL query text in the window below to see that raceID is checked against every raceID you selected, but '0' was not automatically inserted for you.

WORKAROUND:
The only way to do this is to manually insert '0' into the area of the SQL query where it says raceID in (...) where there is a comma separated list of numbers in single quotes. Insert the '0' into that list, adding a comma for itself, then save that query to a file and run it on your database. You will then get item types of raceID = 0 seeded to your market.

PROPOSED SOLUTION:
I propose the simple solution of just modifying the ECP code where it makes the seed market query to insert the '0' automatically for you so that every query you make, even when you select NO raceID, it should at least have raceID = ('0') in the SQL query text.

It says evemu.typeactivitymaterials is not present in DB when I select an ore from drop-down list. Don't know where the table went, seems to be invTypeMaterials