The eve_online from evemonk

ArgumentError from open-uri on Ruby 2.3.0

server-status.rb:

$LOAD_PATH.unshift File.expand_path './lib'
require 'eve_online'

puts EveOnline::Server::Status.new.server_open?

Try to run it:

flynn@caesura:~/eve_online$ ruby server-status.rb
/home/flynn/.rbenv/versions/2.3.0/lib/ruby/2.3.0/open-uri.rb:117:in `block in check_options': unrecognized option: User-Agent (ArgumentError)
        from /home/flynn/.rbenv/versions/2.3.0/lib/ruby/2.3.0/open-uri.rb:114:in `each'
        from /home/flynn/.rbenv/versions/2.3.0/lib/ruby/2.3.0/open-uri.rb:114:in `check_options'
        from /home/flynn/.rbenv/versions/2.3.0/lib/ruby/2.3.0/open-uri.rb:138:in `open_uri'
        from /home/flynn/.rbenv/versions/2.3.0/lib/ruby/2.3.0/open-uri.rb:717:in `open'
        from /home/flynn/.rbenv/versions/2.3.0/lib/ruby/2.3.0/open-uri.rb:35:in `open'
        from /home/flynn/eve_online/lib/eve_online/base.rb:42:in `content'
        from /home/flynn/eve_online/lib/eve_online/base.rb:47:in `response'
        from /home/flynn/eve_online/lib/eve_online/base.rb:30:in `eveapi'
        from /home/flynn/eve_online/lib/eve_online/base.rb:14:in `result'
        from /home/flynn/eve_online/lib/eve_online/server/status.rb:17:in `server_open'
        from server-status.rb:4:in `<main>'

Drop 2.2 ruby support

Ruby 2.2 is now under the state of the security maintenance phase, until the end of the March of 2018. After the date, maintenance of Ruby 2.2 will be ended. We recommend you start planning migration to newer versions of Ruby, such as 2.4 or 2.3.

https://www.ruby-lang.org/en/news/2017/12/14/ruby-2-2-9-released/

Drop ruby 2.4 support

https://www.ruby-lang.org/en/news/2020/03/31/ruby-2-4-10-released/

write_timeout for ruby 2.6

https://blog.bigbinary.com/2018/08/14/ruby-2-6-adds-write-timeout-to-net-http.html

Corporation Market Orders

In trying to get a list of corporation market orders, the gem raises an error:

/home/rpc/.gem/ruby/2.3.1/gems/eve_online-0.10.0/lib/eve_online/base_xml.rb:13:in `fetch': key not found: "result" (KeyError)
        from /home/rpc/.gem/ruby/2.3.1/gems/eve_online-0.10.0/lib/eve_online/base_xml.rb:13:in `result'
        from /home/rpc/.gem/ruby/2.3.1/gems/memoist-0.15.0/lib/memoist.rb:169:in `result'
        from /home/rpc/.gem/ruby/2.3.1/gems/eve_online-0.10.0/lib/eve_online/corporations/market_orders.rb:45:in `rowset'
        from /home/rpc/.gem/ruby/2.3.1/gems/memoist-0.15.0/lib/memoist.rb:169:in `rowset'
        from /home/rpc/.gem/ruby/2.3.1/gems/eve_online-0.10.0/lib/eve_online/corporations/market_orders.rb:50:in `row'
        from /home/rpc/.gem/ruby/2.3.1/gems/memoist-0.15.0/lib/memoist.rb:169:in `row'
        from /home/rpc/.gem/ruby/2.3.1/gems/eve_online-0.10.0/lib/eve_online/corporations/market_orders.rb:20:in `orders'
        from /home/rpc/.gem/ruby/2.3.1/gems/memoist-0.15.0/lib/memoist.rb:169:in `orders'
        from test.rb:35:in `<main>'

Make this library properly handle caching

I'd love to use (and contribute to) this library, but it doesn't look look like it handles ESI caching properly.

Unless I'm misreading the code, it seems like you only ever cache (using memoize) the first response for every API call. If I'm missing something, feel free to close this issue.

Usage examples - how to include your gem from another script.

Hello,

I'm pretty sure I'm just daft... but how do I leverage your gem from other locations?

This seems to work:

$ cd ~
$ git clone https://github.com/biow0lf/eve_online.git
$ cd eve_online
$ bundle exec bin/setup
Resolving dependencies...
Using rake 12.0.0
Using abstract_type 0.0.7
Using concurrent-ruby 1.0.5
Using i18n 0.8.1
Using minitest 5.10.2
Using thread_safe 0.3.6
Using ice_nine 0.11.2
Using equalizer 0.0.11
Using ast 2.3.0
Using awesome_print 1.7.0
Using bundler 1.14.0
Using docile 1.1.5
Using json 2.1.0
Using simplecov-html 0.10.0
Using coderay 1.1.1
Using diff-lcs 1.2.5
Using multipart-post 2.0.0
Using memoist 0.15.0
Using nori 2.6.0
Using method_source 0.8.2
Using mini_portile2 2.1.0
Using procto 0.0.3
Using parallel 1.11.2
Using regexp_parser 0.3.6
Using rspec-support 3.5.0
Using powerpack 0.1.1
Using slop 3.6.0
Using rb-readline 0.5.4
Using ruby-progressbar 1.8.1
Using unicode-display_width 1.2.1
Using rainbow 2.2.2
Using tzinfo 1.2.3
Using memoizable 0.4.2
Using parser 2.3.3.1
Using simplecov 0.13.0
Using faraday 0.12.1
Using nokogiri 1.7.2
Using rspec-core 3.5.4
Using rspec-expectations 3.5.0
Using rspec-mocks 3.5.0
Using pry 0.10.4
Using activesupport 5.1.0
Using adamantium 0.2.0
Using rubocop 0.48.1
Using codeclimate-test-reporter 1.0.8
Using rspec-its 1.2.0
Using rspec 3.5.0
Using eve_online 0.11.0 from source at `.`
Using anima 0.3.0
Using concord 0.1.5
Using morpher 0.2.6
Using unparser 0.2.5
Using mutant 0.8.12
Using mutant-rspec 0.8.11
Bundle complete! 14 Gemfile dependencies, 54 gems now installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.
$ bundle exec bin/console
[1] pry(main)> EveOnline::XML::ServerStatus.new.online_players
=> 21467

(I'm including the full list of gems installed, I had initially done a # ... snip but the only real difference I can find between running the test script in the root of eve_online gem and running it with a dedicated gemfile)

And when I'm in the root of the gem the same seems to work:

$ pwd
/home/maraaaa/eve_online
$ cat > test.rb<<EOF
#!/usr/bin/env ruby

require 'eve_online'

puts EveOnline::XML::ServerStatus.new.online_players
EOF

But when I try to include it from my own project, I get a uninitialized constant EveOnline::XML::ServerStatus error.

$ cd ~
$ mkdir eve_online_test
$ cd eve_online_test
$ cat > Gemfile <<EOF
source 'https://rubygems.org'

gem 'eve_online'
gem 'nokogiri'
EOF
$ cat > test.rb <<EOF
#!/usr/bin/env ruby

require 'bundler/setup'
require 'eve_online'

status = EveOnline::XML::ServerStatus.new
EOF
$ chmod +x test.rb
$ bundle
Fetching gem metadata from https://rubygems.org/.........
Fetching version metadata from https://rubygems.org/..
Resolving dependencies...
Using concurrent-ruby 1.0.5
Using i18n 0.8.1
Using minitest 5.10.2
Using thread_safe 0.3.6
Using multipart-post 2.0.0
Using json 2.1.0
Using memoist 0.15.0
Using nori 2.6.0
Using mini_portile2 2.1.0
Using bundler 1.14.0
Using tzinfo 1.2.3
Using faraday 0.12.1
Using nokogiri 1.7.2
Using activesupport 5.1.0
Using eve_online 0.11.0
Bundle complete! 2 Gemfile dependencies, 15 gems now installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.
$ bundle exec ./test.rb
bundler: failed to load command: ./test.rb (./test.rb)
NameError: uninitialized constant EveOnline::XML::ServerStatus
  /home/maraaaa/eve_online_test/test.rb:6:in `<top (required)>'

I'm sort of a Ruby newbie, (ha! that rhymes!) so I'm sure I'm missing something obvious... but I am at this point stumped.

For sure the gem is being loaded:

$ cat > test2.rb <<EOF
#!/usr/bin/env ruby

require 'bundler/setup'
require 'eve_online'

puts Gem.loaded_specs.keys.grep 'eve_online'
EOF

and as far as I can tell eve_online/lib/eve_online.rb requires all of the sub modules.

What am I missing?

Off topic...

Are you open to pull requests? We're looking to do some work with the ESI API that your library doesn't yet cover. And rather than reinvent the wheel looks like you've got a good framework to enable further ESI endpoints.

Thanks!
@maraaaa

Gory details:

OS: CentOS 7.3.1611
Ruby Version: ruby 2.3.1p112
Bundler version: 1.14.0

CHARACTER ID RANGES

https://developers.eveonline.com/blog/article/character-id-range-change

evemonk / eve_online Goto Github PK

eve_online's Introduction

EveMonk is an EVE Online management suite

Features

Screenshots

Stack

Configure

Links

Guides

Author

License

eve_online's People

Contributors

Stargazers

Watchers

Forkers

eve_online's Issues

Recommend Projects

Recommend Topics

Recommend Org