Git Product home page Git Product logo

Comments (7)

EvanOxfeld avatar EvanOxfeld commented on July 16, 2024

Unzipping with the correct file permissions isn't implemented right now. I'll add support this weekend / early next week. Thanks for reporting the issue.

from node-unzip.

satazor avatar satazor commented on July 16, 2024

+1

from node-unzip.

EvanOxfeld avatar EvanOxfeld commented on July 16, 2024

I'm revisiting the design impact of permissions, as well as anything else stored in the central directory file headers at the end of the zip - see #1 and #2, after being waylaid (in a fun way) by Node Knockout. Unzip needs to decompress arbitrary zip streams, and currently does so in one incredibly fast pass in the improve-speed branch. I should be able to write each file to disk, then when the central directory headers are streamed modify files as specified.

While I'm giving this issue more thought, suggestions or pull requests (even better!) are welcome.

from node-unzip.

yves-del-medico avatar yves-del-medico commented on July 16, 2024

Hello, I made some modifications to apply permission which apparently were working fine on node-unzip 0.1.2.

I ported my fix on node-unzip 0.1.3, and now I see (not always) an error saying that the file does not exist when
I try to execute the fs.chmod.

It seems that the _readCentralDirectoryFileHeader() is called while the file is still being written to disk and not yet closed.

My feeling is that we should wait until all the files are written to disk before processing the central directory entries.
Any thoughts, ideas ?

from node-unzip.

guy-mograbi-at-gigaspaces avatar guy-mograbi-at-gigaspaces commented on July 16, 2024

is this still open? any update? I really need the permissions to be kept. currently manually resetting permissions. again to each file. would like to have a clean solution.

from node-unzip.

mayankchutani avatar mayankchutani commented on July 16, 2024

@EvanOxfeld Is this issue resolved? Or is there any flag I can pass to unzip.extract in order to preserve the file permissions?

from node-unzip.

ThibaultJanBeyer avatar ThibaultJanBeyer commented on July 16, 2024

still not fixed?

from node-unzip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.