Does not work with nodejs v10.0.0 about node-unzip HOT 5 CLOSED

Hey all,
Together with @Fatme we have investigated this case further and it turns out the problem is caused by our npm-shrinkwrap.json (same will happen in case you use package-lock.json). So, what is the problem - unzip package depends on fstream package. It has a dependency on graceful-fs version 3.0.11. As you can see here this version of graceful-fs depends on the natives package by using ^1.1.0. In our case, in npm-shrinkwrap.json we had the version of natives set to 1.1.2. However, there's a newer version of the natives package that addresses the issue with Node.js 10.x.x - 1.1.3: https://github.com/addaleax/natives/commits/v1.1.3

So the solution for us was to:

1. Delete node_modules
2. Delete npm-shrinkwrap.json (in your case it might be package-lock.json)
3. Execute npm i
4. Execute npm shrinkwrap

from node-unzip.

Are you sure this is not a problem with your test file? I ran the test suite of unzip on the node 10.0.0 docker image and all the tests passed? Can you share the test.js

from node-unzip.

Hi @ZJONSSON

I've created a repro project
https://github.com/Fatme/unzip-node10

Steps to reproduce:

1. git clone [email protected]:Fatme/unzip-node10.git
2. cd unzip-node10
3. npm install
4. node index.js

NOTE: I've tested it on Mac OS High Sierra

from node-unzip.

I can confirm the issue is reproducible on windows too. I tested it on windows 10.
Tested with this: https://nodejs.org/en/download/current/

from node-unzip.

I can also confirm that this package does not seem to work on nodejs v10.0.0 and I get the same error as @Fatme. Another way to reproduce it is to open the Node repl and type require("unzip"). I use unzip version 0.1.11.

from node-unzip.