Hangs with potentially corrupted/invalid/empty zip files about node-unzip HOT 6 OPEN

This is not an issue in yauzl.

from node-unzip.

I ended up using https://github.com/bower/decompress-zip to detect for corrupted zip files, then this module to stream unzip the contents.

from node-unzip.

That's a bit of a brittle solution. Seems like you would want the same library that is doing the unzipping to be the one to detect errors and not crash. Anyway if you've got it working then you've got it working. But I do think yauzl would be a more elegant solution :-)

from node-unzip.

Yeah I agree. If i work on the code again i'll definitely check it out. The failure test cases fill me with confidence https://github.com/thejoshwolfe/yauzl/tree/master/test/failure

from node-unzip.

I encountered the same problem when the destination is unwriteable. e.g. try running domharrington's code with a real zip file, then chmod -rwx some of the destination files, and try running it again. It will hang forever. An uncaught error is thrown, but neither the error nor close events fire.

from node-unzip.

+1 had the same problem, switched over to use yauzl which seems like the better choice long term (this one has had no activity since last year)

from node-unzip.