eush77 / ass-parser Goto Github PK

Just as the title says, there's this dependency warning when installing ass-parser.

Nothing terrible but I thought I might drop in an issue just to let you know.

The dependency comes from lodash.zip which is used by fzip, which uses an old version of lodash libraries.

Hope you can fix it sometime :)

Thanks for ass-parser, it's very helpful.

I was using Electron.js trying to build a desktop client(Mac+Windows) that parse ASS subtitlte file.
(the propose of the project is use Google Translate process SRT and ASS file)

your code work and very helpful,THANK YOU VERY MUCH!
I wonder why such useful modules have so little start/fork.

I am building this side project for fun.
Thanks again!

Star+Fork+Follow!

Would you mind publishing a new version so that I can get the change from #3? Thanks 😄

Can you tell me how can i use it in iOS Project？

With latest Node.JS (7.10.0) throws the following error:

TypeError: text.slice(...).split is not a function
at e:\BTSync\Projects\Web\UnlimitedQuotebook\node_modules\ass-parser\index.js:54:40
at e:\BTSync\Projects\Web\UnlimitedQuotebook\node_modules\fzip\src\fzip.js:49:21
at Array.map (native)
at e:\BTSync\Projects\Web\UnlimitedQuotebook\node_modules\fzip\src\fzip.js:48:53
at parseAss (e:\BTSync\Projects\Web\UnlimitedQuotebook\node_modules\ass-parser\index.js:49:10)
at fs.readFile (e:\BTSync\Projects\Web\UnlimitedQuotebook\index.js:11:28)
at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:439:3)

At the following line in index.js:
var lines = text.slice(begin, end).split('\n');

Fix
Managed to fix the issue by changing line to:
var lines = text.slice(begin, end).toString().split('\n');