Git Product home page Git Product logo

meteor-dapp-wallet's Introduction

Ethereum Wallet Ðapp

The Ethereum wallet.

Build Status

PLEASE NOTE: This wallet is not yet officially released, and can contain severe bugs! Please use at your own risk.

Install

If you don't have Meteor:

$ curl https://install.meteor.com/ | sh

Install npm dependencies:

$ cd meteor-dapp-wallet/app
$ npm install

Development

Start a geth node:

$ geth --ws --wsorigins "http://localhost:3000" --unlock <your account>

Run dev server:

$ cd meteor-dapp-wallet/app
$ meteor

Navigate to http://localhost:3000

Deployment

To create a build:

$ npm install -g meteor-build-client
$ cd meteor-dapp-wallet/app
$ npm install
$ meteor-build-client ../build --path ""

This will generate the files in the ../build folder.

Navigating to index.html will start the app, but you will need to serve it over a local server like MAMP.


To deploy to the wallet.ethereum.org site, execute these commands:

$ git checkout gh-pages
$ git merge develop
$ cd app
$ meteor-build-client ../build --path "/"

And push (or PR) your changes to the gh-pages branch.


Gas usage statistics

  • Deploy original wallet: 1 230 162
  • Deploy wallet stub: 184 280
  • Simple Wallet transaction: 64 280
  • Multisig Wallet transaction below daily limit: 79 280
  • Multisig Wallet transaction above daily limit: 171 096
  • 1 Multisig confirmation: 48 363

meteor-dapp-wallet's People

Contributors

alexvansande avatar alter2000 avatar atomrigs avatar bjornwgnr avatar chejazi avatar chihchengliang avatar chriseth avatar colrad avatar erchard avatar evertonfraga avatar ferni avatar frozeman avatar graph1994 avatar hackmod avatar hiddentao avatar imgbotapp avatar iquidus avatar johndoe389 avatar jordanvaldma avatar luclu avatar mevernom avatar olivierstern avatar projjol avatar qpakzk avatar ryanio avatar sandakersmann avatar sepehrmohamadi avatar timodao avatar waywalker avatar ygun avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

meteor-dapp-wallet's Issues

Direct deposit to contract based wallet

Hey guys. Have a problem.
I withdraw funds from exchange directly to ethereum gui wallet created contract based wallet address.
Tx shows up in blockchain with "canceled" status. What happens? Exchange will get it back? Or is my funds lost forever?

Contract Wallet Sent to Incorrect Address?

I recently attempted to send a transaction from the GUI wallet. The Ether is gone but it did not wind up at the intended destination.

The transaction appears correct in my wallet's list of transactions. However, when I check the transaction on Etherscan.io, my address is shown as the "to" address and the address I intended to transfer my Ether to is not correct at all. The intended destination does show up as part of the "input data" though.

TX: https://etherscan.io/tx/0x08dfb53c07ddd741e7674090306647e1d5d333282f3a7b4fc59f2dd261be640e

My Address: 0x2761c0ad62d0f7f96f38332cabb9229378c9bfc9

Intended Destination: 8f28be6335a844162bedeed8002ee76fb1c08af9

This in on a Win8 install from a "contract based wallet" not an "account"

Did I make a mistake or was this a bug?

BTW I do have an Ubuntu based install of Geth and I am not afraid of the CLI if that might be able to help yield some useful data about what went wrong.

Any insight or help is appreciated. Thanks.

Account selection on send page

In the send panel there is a lot of unused space to the right.: Can you provide a scroll box with the list of accounts so that it makes it easy for "copy and paste" purposes transferring funds between owned accounts.

Account Sorting

There is a issue with the way accounts are sorted when having multiple accounts (>10). After the wallets are updated from sending and receiving ether. Notice accounts 10, 17 and 18 in this image:
wallet3

Minor bugs list

  • accounts can see past tx before one is send?
  • simple transactions aren't confirming, as they don't have a block number right away

one more transaction failed to invoke script

Can you take a look at transaction 0x07d9dbae65f760540e6d9b99da11484e06d35c907994c6b0b1444eca5c9ff49e?
It's sending 100 finney from etherbase account 0xd2143a6dffdd21f3aaa748119262959be1a1d3c7 to created contract-based wallet 0x8056338e73fde306bb5d9aedec7f4a7b8637c9e7
Although it lists "Contract invocation", I do not see any "Input data" and it looks like these 100 finney are lost.
On this contract-based wallet, if everything worked fine, the balance should be equal to the sum of transactions received minus the sum of transactions sent plus the sum of rewards for the mined blocks, yes?
The sum of received transactions is (0.1+5.0028683+2.99+0.02+0.02) = 8.1328683
The sum of transactions sent is 1 + 0.02 = 1.02
The mined block reward, for block 388103 is 5, as I understand.
Total should be 8.1228683 + 5 - 1.02 = 12.1128683
Now the balance is 7.01, that is 5.1028683 ethers less.
The transaction 0x39b66c720fe5952890091ba3e05f4c85a6121ea8a21c459b66d1fb2e4521c795 from ethpool.org for 5.0028683 ethers you have already explained, thank you. But it looks like transaction 0x07d9dbae65f760540e6d9b99da11484e06d35c907994c6b0b1444eca5c9ff49e for 100 finney from my own coinbase account to contract-based wallet is also lost. Is there the setting for default gas limit for transactions for the node, or for account? Or it should be increased for each transaction? Then, I think, it should be somewhere in the documentation for this application.

Regards,
Sergey Ivanov.

Protocol change for msg.sender?

I needed to change the original wallet and use tx.origin instead of msg.sender, as currently the msg.sender is always the calling contract, not the “last sender”.

Wallet payment decrease balance without actual sending of the money.

I've just created simple contract-based wallet "test", put there 0.04 eth. It worked.
Then I've tested moving 0.02 eth from one contract-based wallet to another one. It worked, but it's not visible by blockchain explorers. After that I've tried to send 0.01 eth to external address, and I saw "invocation of the script" which decreased balance, but I do not see anything related to external address to where this 0.01 eth should go.
Addresses here are:

  1. Creator, etherbase: 0xd2143a6dffdd21f3aaa748119262959be1a1d3c7
  2. New simple contract-based wallet: 0x65eb93c4e0854e3b00a64cd18c176a7fd54dc50f
  3. Another simple contract-based wallet: 0x8056338e73fde306bb5d9aedec7f4a7b8637c9e7
  4. External address to which nothing was sent, although balance was 0x4dd795496f3f438fddd57d43bc81a0d0a88ee265
    It looks like here the GUI of the wallet was developed, but the script for script-based contracts was not tested even for very basic functionality.

Resources not find on developer console

I'm running on Windows 7 64 bit. (Behind a firewall, so no peers, but that's probably not relevant.)
When I go into the developer console there are three messages:
Failed to load resource: net::ERR_FILE_NOT_FOUND
The file are:
file:///C:/sounds/bip.mp3
file:///sockjs/info?cb=wbua9fc8de
file:///C:/(install location)/resources/app.asar/interface/wallet/packages/ethereum_dapp-styles/fonts/SourceSansPro-ExtraLightIt.otf

Lost wallet after refresh mist

Created a single address wallet: {"data":{"type":"wallet","owners":["0xe6716f9544a56c530d868e4bfbacb172315bdead"],"name":"Main","balance":"999000000000000000000","creationBlock":898497,"disabled":true,"address":"0xe636b5701367f5a7f8f04db07142c265d0128057","transactions":["tx_aa360bfa13","tx_eaf75b0358"],"_id":"8JuKjwDPvCdzk5aPx"},"expires":null} is the wallet in minimongo.

The wallet disappeared after refreshing

missing wallet icon

after creating new wallet go to 'send money' tab. Wallet icon is missing there (pic. 1). After pressing it, and selecting other wallet, the icon appears (pic. 2). if we select first wallet again, the icon is also ok (pic 3).

pic 1.
screen shot 2015-06-09 at 12 37 47
pic 2.
screen shot 2015-06-09 at 12 38 34
pic 3.
screen shot 2015-06-09 at 12 38 51

[feedback] Send money

It took me a while to figure out that if I click on "FROM" I can change the sender. [Suggestion] If you are in a wallet/account and press "Send" on top - the wallet/account would be selected. - It is a second way to select the sending address.

Bad transaction history for wallet

I created a simple wallet (0xf2d850b176ddf0b6c1411d68ef96d2d8b7b0b480, named "TestWallet") from account 0x86889b1cea13d370e827e099e3778b17d488b3dd, and transferred one finney to it (also from 0x86889b1cea13d370e827e099e3778b17d488b3dd). After a short while, the transaction history contained a number of transactions that are not mine.

image

Failure to create wallet

I tried to create a wallet of a "simple type", but got an error message as shown:

image

The message is ambiguous, as I don't know how to restart a wallet. In this case, I suppose it is the app itself. After restarting the application, I got the same message and still no wallet listed. Second time I restarted, the error message was gone, but still no wallet.

Last block time incorrect

"X time since last block" notification at top of Win64 GUI Wallet does not update properly when new block is found.

Suggestion: Textual changes

  • When deploying the master contract on testnet have a message that explains what's happening during the spinner and after a message what has just been done.
  • When a new wallet is waiting for confirmations change the text from "Creating" to "Confirming" so the progress-bar makes sense.

Might add more if I find it.

Failure to rename account

Clicking on account, you can rename it. Accidentally, I pressed backspace and ENTER, removing the default name. It is now listed to "UNNAMED WALLET", and I can't set a new name for it. There is no "old name" to click on.

image

import old account

I created my first account 2 month ago using the command line tool. Now I wanted to get access to this Etherbase account using the latest wallet version (0.3.2.) and copied the related file (named UTC--2015-08-03T1....) from the old keystore folder to the new keystore folder. The old account is shown now as another Etherbase account in the wallet GUI. But when I try to create a wallet for this account or try to send some ETH, I get the error message: password not correct, but the password is definitely correct. Any idea ?

No way to unlock account

I consider myself to be pretty good with passwords. I have issues unlocking accounts with the 64bit windows version of the wallet. I could somehow unlock it once to fund a contract that allowed me to create a wallet. Once I did that I could never transfer any funds to the wallet I created because I would constantly get "wrong password" when attempting to send from the account.

So I created lots of accounts out of frustration and now I want to go and delete accounts once i see if I can unlock them. I can't click anywhere that will allow me to test to see if I can unlock account. No way to delete accounts... frustrating.

Script not always invoked on receiving transactions

I have tried Developer Preview of Ethereum Wallet: created simple contract-based wallet. Tried sending to it 3 Ethers from my account on hitbtc.com and it worked fine. Later I joined solo mining pool on ethpool.org, and after a while got block reward send to this wallet. It did not show up in balance of the wallet. Later I have sent 100 wei to test if the script will be invoked from my etherbase address to the wallet, and the script was not invoked again. So two transactions are stuck, they did not invoke the script. What I did wrong? Or is it a bug in the wallet's contract script?
Just checked the node is working fine, by sending 1 eth from this contract-based wallet. All 4 transactions can be checked on https://etherscan.io/address/0x8056338e73fde306bb5d9aedec7f4a7b8637c9e7

suggestion: progress bar for creating wallet

after creating new wallet I see active indicator (pic 1), but I don't know for what does it mean. It would be nice to have there progress bar similar to the one after making transaction (pic 2) :)

pic 1
screen shot 2015-06-09 at 12 42 49

pic 2
screen shot 2015-06-09 at 12 42 56

suggestin: clickable pending wallet

It would be nice to have clickable wallet, that is still being created (pic 1). After opening it, there could be a NOTE like: "This wallet is still being created, please wait for XXX confirmations before using it." (pic 2).

pic 1
screen shot 2015-06-09 at 12 42 49

pic 2
screen shot 2015-06-09 at 12 49 19

Zero value when executing a contract that transfers ether

When I transfer ether from my wallet to an address the Execute Contract dialog 0.00 Ether above the arrow at the top. As I'm transferring I'd expect to see the amount I'm transferring there.

(This is v0.3.2 running on WIndows 7 64 bit)

revoked multisig transaction reported as executed

When you start a multi-sig transfer

  • with the first signing account unlocked, and
  • the second one not unlocked, and
  • you revoke the transaction because of the locked status of second account,
    the transaction still gets reported on the dashboard

Window containing electron becomes "unresponsive" while importing blocks

Linux 64 bit.

The block counter works fine and I see progress, but I cannot resize or move the window around. Might be a problem with my window manager, but I have never experienced this before.

Edit: It is possible to resize the window, but it seems that the terminal that I launched the wallet from it totally frozen and unresponsive. Don't know if it is due to electron, but I have never seen this before.

keine eth in contract wallet

Können sie mir bitte behilflich sein meine 800 eth coins wieder zu bekommen?

wollte mir 800 eth von kraken in meine wallet senden, jedoch habe ich diese coins direkt an meine erstellte contract wallet senden wollen und
die sind leider nicht angekommen.

die 2te überweisung von kraken in meine acount wallet hat wunderbar geklappt.

was muss ich nun machen damit meine 800 eth in meiner contract wallet zu sehen sind?

Accounts not displayed

I had geth already running. Opened the wallet app on OSX 10.10 and it displays no account. OK, I click ADD ACCOUNT, it asks for password and confirm password, then "generating account" ... and nothing. The GUI is not updated but my geth instance in fact has a new account. Even after restarting the wallet, nothing there.

Developer tools console:

Failed to load resource: net::ERR_FILE_NOT_FOUND
file:///sockjs/info?cb=g8xfuqrd4z Failed to load resource: net::ERR_FILE_NOT_FOUND
/Users/roman/ether/Ethereum-Wallet-darwin-x64-0-3-1/Ethereum-Wallet.app/Contents/Resources/app.asar…:276 Uncaught TypeError: Cannot read property 'startingBlock' of undefined

Confusion: Contract based simple wallets

From a novice user perspective, there are two things that look almost the same. You can create an account, and you can create a simple "contract based wallet". These two alternatives look the same, and it can be difficult to understand the difference.

I don't understand it fully myself, but I think one "Account" can be used to control more than one "wallet", which means only one password is needed.

So what is really the recommended behavior for a novice user? Just create one account, and then use it to store ether. Or is the recommended thing to not store ether on the account, but always create at least one wallet?

So what this issue is about isn't necessarily a functionality change, but information shown to the user.

Array Indices

I have a question regarding array indexing in Solidity. I understood that array indices start at 0 and if that's the case, the following code in the wallet contract says:

if (pending.yetNeeded == 0) {
            // reset count of confirmations needed.
            pending.yetNeeded = m_required;
            // reset which owners have confirmed (none) - set our bitmap to 0.
            pending.ownersDone = 0;
            pending.index = m_pendingIndex.length++;
            m_pendingIndex[pending.index] = _operation;
        }

If the m_pendingIndex array is empty and we encounter this code on the first operation to be comfirmed, pending.index would be set to 1 since the length of m_pendingIndex.length would be zero and we would be inserting the first element in the m_pendingIndex at index value 1, and in my head that first element should be inserted at index 0. Is there something I am missing?

Thanks,

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.