etherdelta / smart_contract Goto Github PK

Can u please attach license file?

need to install contract someone? i can pay.

Look at the file attached. In the window "my transaction" and in the column "trade" one can see two transaction where 75 Taas were bought.
By mistake the two orders seems like they count as only 1 since i missed payout of 75 Taas.
By searching both transaction on deltabalances it seems like they are counted as one.
Take a look here at the Attach file:

Here is the address the transactions happened on:
https://etherscan.io/address/0x9f44280A09C0A1aF8ebf74f99020B4f797b1e040

This is the one for the 65 Taas:
https://etherscan.io/tx/0x691aaca9358ffc54293840b97fe1009d3fe4081867640ee5d1d8a67a8d6ee9a9

This is the one for the 75 Taas... seems like both transactions was registered twice at the same time so the EtherDelta exchange only payed out one transaction:
Here is the adress for both of them i get when i tried to follow the transaction history in "my transaction" window under the column "important" and "Transaction" in Etherdelta, as one can see it looks exactly the same:
https://etherscan.io/tx/0xdc628fcbcecb25e3f0c804900a547213bfc36672619f5f119e6d146879aeade9
https://etherscan.io/tx/0xdc628fcbcecb25e3f0c804900a547213bfc36672619f5f119e6d146879aeade9
https://deltabalances.github.io/tx.html#0xdc628fcbcecb25e3f0c804900a547213bfc36672619f5f119e6d146879aeade9

The next transaction under there is for transferring ethereum internal in EtherDelta in order to buy token Taas https://etherscan.io/tx/0xe05f50cc76bd0890792642e88fb39fd610111571cd9f05c3b0b9308d150588cd

Can anyone from the team contact me on mail? [email protected]
Have i lost 75 Taas ?, do i get Ethereum refunded ?...
Why does the 75 Taas seems lost when i bought them with little time in between the transaction ? Is there anyone i could get help from with this ?

Hello
I am looking for some advice If I can please.
When I build the smart contract node deploy.js -args it outputs the bytecode is this just for EtherDelta contract

in the folder https://github.com/etherdelta/etherdelta.github.io/tree/master/smart_contract
there are 3 different sections of bytecode do I need to replace all of these?

Im a bit confused to the process of getting the bytecode for;
token.sol.bytecode
reservetoken.sol.bytecode

Please can someone point me in the right direction I have it all setup but im sure im doing something wrong deploying the contract

Kind regards

Hey there,

It would be nice if you could update the contract to use revert instead of throw. It would lead to less gas consumption :)

I sent 750 Utrust tokens directly to the smart contract by mistake ,I'm using first time etherdelta felling that I lost tokens .can u please help me to recover my tokens .

my transaction is success and is as follows: https://etherscan.io/tx/0x6ba5ace336c8c396c3bd97fb321d24b7809ec851ca65e068df0601408e400d72

I love the ED source code and i must say a big kudos to the developers that created such a beautiful thing. Since it's open source, i wanted to be using it with some modifications when applicable. I am perfectly okay with the frontend and features, but the only major thing i wanted to change was the smart contract so that i can be able to change the fees, set the fees and also be able to receive the fees too and i know the only way to achieve that is by creating my own smart contract which i am willing to do.

Can anyone please help or guide me on how i can integrate my created smart contract with the ED frontend so that it replaces the default ED smart contract details with mine? Any help, direction or guidance will be greatly appreciated because i really need to be able to do that, or is it not possible? Thanks in advance to anyone who can help me out.

Hello

I need someone to install the contract for me.

I am willing to pay

Please contact me [email protected]

Hey,

Your smart contract generates a warning in Remix about using call here:

	function withdraw() {
		if (tokens[0][msg.sender] < amount) throw;
		tokens[0][msg.sender] = safeSub(tokens[0][msg.sender], amount);
		if (!msg.sender.call.value(amount)()) throw;
		Withdraw(0, msg.sender, amount, tokens[0][msg.sender]);
	}

Shouldn't this have been written like:

	function withdraw() {
		if (tokens[0][msg.sender] < amount) throw;
		tokens[0][msg.sender] = safeSub(tokens[0][msg.sender], amount);
		if (!msg.sender.send(amount)) throw;
		Withdraw(0, msg.sender, amount, tokens[0][msg.sender]);
	}

Thoughts?