Git Product home page Git Product logo

ethck-s-downtime-tracking's People

Contributors

chrisjbrown avatar ethck avatar varriount avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

ethck-s-downtime-tracking's Issues

Error when importing world downtime activities

Cannot import previously exported World Downtime Activities.

Error in console:

foundry.js:4503 Foundry VTT | Rendering GMConfig
gmConfig.js:71 Uncaught (in promise) TypeError: Cannot read property 'id' of undefined
at gmConfig.js:71
(anonymous) @ gmConfig.js:71
load (async)
(anonymous) @ foundry.js:4040
readTextFromFile @ foundry.js:4039
importWorldActivities @ gmConfig.js:66
dispatch @ jquery.min.js:2
v.handle @ jquery.min.js:2

I thought it may have something to do with missing complications tables but they are all there and named the same.
Foundry 0.7.9
DnD5e 1.2.4

Grouped Rolls Don't Respect Selections

Problem:
When setting up an activity that gives the user the option to select one of multiple options, the option they select is not respected when the rolls are made. It looks like it's defaulting to the first option.

Info:

  • Foundry v0.6.6
  • DnD5e v0.95
  • All modules disabled
  • Issue occurs with both player-defined and GM-defined world activities
  • Issue occurs when performing activity as both player and GM

Steps to Reproduce:

Setup
image

Dialog (note Cha is selected)
image

Roll outcome (Con gets rolled)
image

[Feature] Time Spent on Downtime Activities

  • Especially useful for Acq. Inc.

From u/Taco_Supreme:
Still some partial time tracking would be helpful. Let's say Albert is doing a task that takes 10 days and 3 checks. Bob is doing a task that takes 5 days and 1 check. And the Cathy is just working on their franchise so getting a +1 for each day spent there, and will roll at the end of the month.

They get 5 downtime days between doing other stuff, so Albert marks 5 days on his. If you want to you could have him make one of his 3 checks. Bob marks 5 on his and finished his task, making his 1 roll. Cathy just marks 5 days completed on her task and at the end of the month when you roll, you look at how many days are spent across the whole group to figure out the bonus, then reset everyone to 0 days spent on the task.

Downtime Activity tab no longer shows up on sheet

As of 01.05.2021 I noticed that the downtime activity tab was suddenly gone. It just doesn't show anymore, no matter what I do.

This was also tested with a fresh world and no other modules activated.

[Feature] Manual Validation of Rolls by GM

how would I do this ?
Taming th e Untamed
An untamed creature will always be feral, but over time (and
with your DM’s permission) can learn to trust its owner and its
owner’s allies.
To tame an untamed creature, you must take a short or long
rest in its company once each day, making a Wisdom (Animal
Handling) check at the end of that rest. The initial DC for this
check is 20, and the DC for each subsequent check is 20 – half
the number of successful checks you’ve made + the number of
consecutive days you’ve gone without making this check (maximum
10). Placing the creature under the animal friendship spell
does not decrease this DC, but instead grants you an advantage on
the check due to the charmed condition.

I see I can use a custome formula and use "[email protected]"' to get the number but I am not sure how to do the diminishing DC ...

Maybe something where instead of changing the DC the success count is incorporated in the the Roll bonus ...

Leave the DC@20 ... but then [email protected]+(.5*SuccessCount) for the Custom Formula. I am not seeing that in the data object.

The math would be simple enough IDK if the field takes it 20DC -(successfulRoles*.5) the + days would be a consequence .. Ideally imposed by the DM ...

Would be cool if the role took place and then gave the DM the ability to say if it was a SUCCESS or NOT

how do we incorporate the successful roll back into the math of the Role..

Fix Audit Log Sorting

They are currently being sorted by human readable dates (including About Time compat, e.g. custom months/days). These should not be sorted in that fashion, perhaps leaving timestamp as a number and then including a readable version in the change would be a better approach.

Error with BetterRolls + Midi QOL compatibility

I'm getting an error Uncaught (in promise) TypeError: Cannot read property 'altKey' of undefined when having betterrolls compatibility active.

Maybe there was a change somewhere? it worked before one of the recent updates.

Edit fields

Edit fields to better use the module it would be very welcome option to edit the result fields

D

Feedback Type: Bug

Core: 0.7.9
System: dnd5e v1.2.4
Module Version: dnd5e v1.2.4

Description:
Testing bug-reporter with systems

Add Images to Downtime

  • Must be able to choose my own image, no memorizing paths either (do it like dnd5e system...)
  • Must be able to edit my image (no one time creation)
  • It'd be cool if it was like selecting actor portraits (click image)
  • I want to see my images in the chatlog when I use a downtime activity

Suggestion: Auto deduct gold

The use materials prompt is perhaps a little broad as the only material downtime uses is time, and a gold value which represents all resources and sundries the character needs to provide.

Perhaps have it instead as a gold spent box that data validates an entered numerical value, and takes that value away from the user's gold total.

If you can make it work with the Lazy Money module which auto converts coin denominations, it would be very user friendly.

Suggestion: Allow bonuses for non-skill rolls

I love when it asks to make like a persuasion check it pops up a roll dialog allowing advantage/disadvantage and a numerical bonus.

I wish it would also do that for arbitrary die rolls that aren't attached to a skill. Like if I have a downtime task where they roll 1d100, but I want them to be able to get bonuses by spending extra money it would prompt them to add a bonus like it does with a skill.

[suggestion] naked roll

Hello there Ethck! Many thanks for your great module, I just wanted to request something, do you think it would be possible to roll a naked d20?

0.7.x Double UI Tabs

image

Core Version 0.7.4
dnd5e Version: 0.98
Module Version: 0.2.6 (Fresh Install)

I believe this has to do with the Hook changes in 0.7.x. An extended class runs all of the hooks of the inheritance tree or some such, here's a post from the League of devs discord talking about the issue:
image

Test Bug

Feedback Type: Bug

Core: 0.7.9
System: dnd5e v1.2.4
Module Version: downtime-ethck v0.4.1
Dependency Version: Autocomplete Inline Properties v1.2.0

Description:
Testing the updated API.

Module Settings
enableTraining: true,
enableTrainingNpc: true,
aboutTimeCompat: false,
crashCompat: true,
betterRollsCompat: true,
tabName: Downtime,
dcRollMode: blindroll,
extraSheetWidth: 200
Active Modules autocomplete-inline-properties--v1.2.0; azgaar-foundry--v0.1.0; bug-reporter--v1.2.0; combat-utility-belt--v1.4.0; dae--v0.2.45; downtime-ethck--v0.4.1; furnace--vv2.6.0; lib-wrapper--v1.3.5.0; pin-fixer--v1.0.4; pings--v1.2.10; tidy-ui_game-settings--v0.1.21;

There is no way of hiding an activity from players.

I wish I could create an activity and keep it hidden until it is the right time to reveal it to the players. As the module runs now, twhenever you previously prepare activities, they get spoiled to the players.

Suggestion: Additional method of having complication.

Not all tasks have a flat % chance for complication. Some tasks have an automatic complication on 0 successes, or on a roll result total of 0 to 5 etc.

Add a new column of checkboxes called 'Complication?' or similar so that GM can tick if a certain result in the table gets an automatic complication (which would also ideally prevent the % complication from triggering for double complications)
20201223_090400

Suggestion: have description expandable

On the downtime tab, players can only see 1 line of text for the description of a task, regress of how much is written in the tasks set up.

Currently, players can click the task name to expand the box to show the DCS associated with the roll. This should also expand the description box to show the full description text.

Screenshot_20201223-082655_TeamViewer

Suggestion: Ability to sort tasks

The ability to sort tasks alphabetically or manually.
They currently get added to the bottom of the list in the order you create them.

Activity subtypes

Is there a way you could add a dialogue or similar option to the activity form that would allow a player to select a subtype of a downtime activity? For example, in XGtE you can pursue low-class, middle-class, or upper-class carousing. They are similar, but have different complications. A way to set up a general activity and then modify pieces of it depending on player selection would be awesome. Right now I am creating multiples of the same activity from scratch with different DCs - such as the Crime activity - and it is a bit of a pain to set up.

[Bug] Other Modules Casuing Saving Throws and/or Skill Checks not working

Hello.-

Coming from #11 , Ability Checks work fine. However, when using saving throws and/or skill checks, the following behaviour occurs:

  • With Saving Throws, there's no output after clicking the dice

image

image

  • With Skill Checks, there's an output, but it's not replaced afterwards according to the result category (using the same template except replacing the STR Save with Acrobatics):

image

Expected behaviour is, of course, triggering the replacement (changed the example to STR Check):

image

There is no way of creating a tool check anymore

Whenever I choose a Tool Check on the list "Roll Type", instead of a list of tools being listed on the "Roll choice" list, I get a generic list with following options: "Kit, Instrument, set, supplies, Tool Utensils".

image

Old rolls created work properly when loaded, but won't list the tool option needed.
image
image

D&D 4e Compat?

Mentioned by kekilla

just allow for a drop down menu and a + button, the drop down for a skill, value for DC and the plus for adding another check
and then this could also be easily used for 4e like skill challenges

[Suggestion] Allow complications to be visible to GM only.

Great mod.

Some complications need to be GM only since they are setups for role-play opportunities that the PC should not see.

In other cases, though, it makes a fun bonus for PCs to see the results of a complication.

Maybe it could be a switch per downtime activity? Kind of how you have private rolls.

Fix Crime

Make the form have every possible roll in it in like different section so instead of 3 forms (in this case) it is just always 1 form.

Not showing the results

So I've gone through the process of making all the rolls and results tables, but when clicking on the icon, it will only show the rolls and not the results. Am I doing something wrong?

Downtimes not saving

Using any Ability Check works fine, but Skill Checks (Acrobatics, Athletics, etc.) aren't. I'm not too sure about Saving Throws since after updating I can't seem to save or change any config (probably related to #10 ).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.