Git Product home page Git Product logo

Comments (5)

etaque avatar etaque commented on June 6, 2024 1

Hi, I think you're quite close, it's just a question of precedence and parenthesis now. I got it working with this adaptation of lib's example:

validate : Validation CustomError User
validate =
    map8
        User
        (field "name" (string |> andThen nonEmpty))
        (field "email" (email |> andThen (asyncCheck True)))
        (field "password" (string |> andThen (minLength 4)))
        ((field "password" string) |> andThen validateConfirmation)
        (field "admin" (bool |> defaultValue False))
        (field "date" date)
        (field "profile" validateProfile)
        (field "todos" (list validateTodo))


validateConfirmation : String -> Validation CustomError String
validateConfirmation password =
    field "passwordConfirmation"
        (string
            |> andThen
                (\confirmation ->
                    if password == confirmation then
                        succeed confirmation
                    else
                        fail (customError ConfirmationError)
                )
        )

That could be better, I'm trying to create a helper that would enable us to write field "passwordConfirmation" string |> andThen (confirm "password")

from elm-form.

kyasu1 avatar kyasu1 commented on June 6, 2024 1

Hi,

Thank you for the great works, this library helped me so much since I need to write a lot of forms views...

While working with this validation example, I noticed it was not trivial to show user friendly error messages. Adding |> withCustomError at the end of password validation does not show the expected message but InvalidString or Empty depending on the initial edit or not. This annoying behavior may be caused by the validation error from (field "password" string) on the next line which has a higher priority than custom errors.

Anyway I figured out a workaround and so wanted to share it.

Simplified original example: Code on Ellie

validate : Validation String User
validate =
    succeed User
        |> andMap (field "name" (string |> withCustomError "Input Name !"))
        |> andMap (field "password" (string |> withCustomError "Input Password !"))
        |> andMap ((field "password" string) |> andThen validateConfirmation)


validateConfirmation : String -> Validation String String
validateConfirmation password =
    field "passwordConfirmation"
        (string
            |> andThen
                (\confirmation ->
                    if password == confirmation then
                        succeed confirmation
                    else
                        fail (customError "Confirmation Error")
                )
        )

Example with user friendly error messages: Code on Ellie

validate : Validation String User
validate =
    succeed User
        |> andMap (field "name" (string |> withCustomError "Input Name !"))
        |> andMap (field "password" (string |> withCustomError "Input Password !"))
        |> andMap 
            (oneOf 
                [ (field "password" string) |> andThen validateConfirmation
                , emptyString |> andThen validateConfirmation
                ]
              )


validateConfirmation : String -> Validation String String
validateConfirmation password =
    field "passwordConfirmation"
        (string
            |> withCustomError "Input Password Confimation !"
            |> andThen
                (\confirmation ->
                    if password == confirmation then
                        succeed confirmation
                    else
                        fail (customError "Confirmation Error")
                )
        )

from elm-form.

alexofob avatar alexofob commented on June 6, 2024

I have done some further troubleshooting and it seems that reading 2 different fields as I had shown above does not make it possible to track the error in the field's error state. One field is nested into another and the error states are not updated at all when validating the fields.
We may have to look into another way of solving this issue.

I will appreciate your comments.

from elm-form.

alexofob avatar alexofob commented on June 6, 2024

Great stuff @etaque.

This works!

Many thanks.

from elm-form.

felixLam avatar felixLam commented on June 6, 2024

This was genuinely helpful. I found this thanks to the help from david_hernandez on slack. Maybe this should be part of some example or in the Readme as this serves as a simple example of interdependent validation.

from elm-form.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.