Git Product home page Git Product logo

Comments (2)

etaque avatar etaque commented on June 20, 2024

Hello,
Finally found the time to look at your issue, it's effectively a grouping problem.

In there:

thingCombinationValidation : Validation MyError ( Thing, Thing )
thingCombinationValidation =
    field "firstThing" thingValidation
        |> andThen
            (\fst ->
                field "secondThing" thingValidation
                    |> andThen
                        (\snd ->
                            if List.member ( fst, snd ) forbiddenCombinations then
                                fail (customError InvalidCombination)
                            else
                                succeed ( fst, snd )
                        )
            )

The fail (customError InvalidCombination) isn't attached to a field, like that, so error is lost in errors tree, see how it's done in lib:
https://github.com/etaque/elm-form/blob/master/src/Form/Validate.elm#L131

So what you can do is to use field to attach your custom error, like so:

field "firstThing" (fail (customError InvalidCombination))

Maybe that kind of error could be caught by better types. Worth investigating!

from elm-form.

nmk avatar nmk commented on June 20, 2024

Thank you for looking into this! I was pretty sure I had answered during the holidays, but just noticed I hadn't. Sorry about that!

Using field to add an error works, but is not really intuitive. Maybe adding a function like failAtField implemented in terms of field and fail as shown above would make it clearer.

from elm-form.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.