Git Product home page Git Product logo

htmllogger's People

Contributors

esplinr avatar progval avatar

Watchers

avatar

Forkers

progval balooga

htmllogger's Issues

Python 2.7 compatibility broken

Hi,

I was trying to test this plugin in python 2.7, but I was getting exceptions like:

Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/supybot/log.py", line 361, in m
    return f(self, *args, **kwargs)
  File "/usr/lib/pymodules/python2.7/supybot/irclib.py", line 126, in __call__
    method(irc, msg)
  File "/home/ircbot/supybot/plugins/HtmlLogger/plugin.py", line 407, in doNotice
    self.doLog(irc, channel, True, None, '-%s- %s', msg.nick, text)
  File "/home/ircbot/supybot/plugins/HtmlLogger/plugin.py", line 337, in doLog
    log = self.getLog(irc, channel)
  File "/home/ircbot/supybot/plugins/HtmlLogger/plugin.py", line 305, in getLog
    with open(logPath, encoding='utf-8', mode='r'+bin_mode) as logFile:
ValueError: binary mode doesn't take an encoding argument
ERROR 2014-09-10T18:41:37 Exception id: 0x23abb

So, looking at the history, I saw that this was fixed in: ced60e2 by removing the encoding='utf-8, but then, it was added again in 5554bd3.
Any reason for that? Could I send you a PR to get that fix? (in case that's needed for python 3.x)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.