Hello ,

Is there any typescript definition for this ?

Where do I need to call shim() ?

I'm assuming it needs to go in main.ts:

import { enableProdMode } from '@angular/core';
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';

import { AppModule } from './app/app.module';
import { environment } from './environments/environment';
import { shim } from 'promise.prototype.finally';

shim();

if (environment.production) {
  enableProdMode();
}

platformBrowserDynamic().bootstrapModule(AppModule)
  .catch(err => console.log(err));

however, the TypeScript compiler complains about not finding the 'finally' property in implementations: error TS2339: Property 'finally' does not exist on type 'Promise<void>'

What am I doing wrong?

Just looked at the bundle size through source-map-explorer and observed that 'es-abstract' required by 'Promise.prototype.finally' takes 43Kb of minified bundle size 13,9% of total.

This package uses few es-abstract methods and removing its reliance on it, would decrease the size considerably.

If you think is doable, i can prepare a PR.

For some weird reason the shim() isn't able to shim the global Promise on karma with the phantomJS driver (the main app works fine, and the jasmine client version of the specs work fine on other browsers).

When debugging I see the shim hitting define-property here:

if (supportsDescriptors) {
 // it actually fires this
  Object.defineProperty(object, name, {
    configurable: true,
    enumerable: false,
    value: value,
    writable: true
  });
} else { ... }

but then

require('promise.prototype.finally').shim()
console.log(Promise.prototype.finally) // logs undefined

Now if I pass the Promise object to the shim and change the library function signature accordingly it works

// shim.js
...
module.exports = function shimPromiseFinally(obj) {
	obj = obj || Promise;
	requirePromise();

	var polyfill = getPolyfill();
	define(obj.prototype, { 'finally': polyfill }, {
		'finally': function testFinally() {
			return obj.prototype['finally'] !== polyfill;
		}
	});
	return polyfill;
};
...


// karma.entry.js
require('promise.prototype.finally').shim(Promise)
console.log(Promise.prototype.finally) // logs the polyfill, it works!

I can submit a PR if you think this is something you want to add (I've seen other shimming libs do this too, perhaps this is a common issue)

PS: for anyone wondering this is my quick fix for now:

const finallyPolyfill = require('promise.prototype.finally').shim()

// Make sure we're shimming promise.finally.
// (auto .shim() doesn't work in karma for some reason)
if (!Promise.prototype.finally) { Promise.prototype.finally = finallyPolyfill }

Hi,

if you'll write something like this:

Promise.reject('reject')
  .finally(() => console.warn('finally'))
  .catch(() => console.warn('catch'));

You'll get the following output:

finally
catch
Promise {[[PromiseStatus]]: "resolved", [[PromiseValue]]: undefined}
Uncaught (in promise) reject

The last Uncaught (in promise) reject looks to be odd here, because the promise was properly handled.

Here is another example, where the promise rejection was not handled:

Promise.reject('reject')
  .finally(() => console.warn('finally'));

and the output is:

finally
Promise {[[PromiseStatus]]: "rejected", [[PromiseValue]]: "reject"}
Uncaught (in promise) reject
Uncaught (in promise) reject

The promise rejection was not handled at all and we got two unhandledrejection instead of one.

Each new finally in promise chain will produce one extra unhandledrejection event. This will result in four events triggered:

Promise.reject('reject')
  .finally(() => console.warn('finally'))
  .finally(() => console.warn('finally'))
  .finally(() => console.warn('finally'));

Does this correct behaviour? If yes, then how should I handle those extra rejections?

use Promise.prototype.finally shim in Mozilla Firefox 56.0.2 (64 bit) has appear an error

TypeError: Promise.prototype.then called on incompatible value

🚨 You need to enable Continuous Integration on Greenkeeper branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet.
We recommend using:

• CircleCI
• Travis CI
• Buildkite
• CodeShip
• Azure Pipelines
• TeamCity
• Buddy
• AppVeyor
  But Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please click the 'fix repo' button on account.greenkeeper.io.

The devDependency eslint was updated from 6.7.2 to 6.8.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Running the shim in a Chrome Version 52.0.2743.116 (64-bit) raises an error complaining about the lack of a global Promise function.

requirePromise.js:5 Uncaught TypeError: `Promise.prototype.finally` requires a global `Promise` be available.

Given that there is definitely such function there, shouldn't the code requirePromise.js look further for it?
Wouldn't it be appropriate to change the verification to something like the following?

if (typeof (Promise || global.Promise || window.Promise) !== 'function') {
    throw ...
}

One of the subclassing tests fails on these node versions. Either the polyfill code should detect this, or if not possible synchronously, skip the failing tests.

I'm specifically looking at these two abstract operations, which basically does this:

var PromiseResolve = Promise.resolve.bind(Promise)
var PromiseThen = Function.call.bind(Promise.prototype.then)

function CreateThenFinally(onFinally) {
    if (typeof onFinally !== "function") return onFinally
    return function (value) {
        return PromiseThen(PromiseResolve(onFinally()), function () { return value })
    }
}

function CreateCatchFinally(onFinally) {
    if (typeof onFinally !== "function") return onFinally
    return function (value) {
        return PromiseThen(PromiseResolve(onFinally()), function () { throw value })
    }
}

☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io

The dependency es-abstract was updated from 1.17.4 to 1.17.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

es-abstract is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

While using this module and bundling all modules using angular2 rollup process, getting below error:

'shim' is not exported by node_modules/promise.prototype.finally/index.js (imported by src/main.js). For help fixing this error see https://github.com/rollup/rollup/wiki/Troubleshooting#name-i
s-not-exported-by-module

What is the work around for this?

This might be related to #4 as it only happens with Firefox, but I couldn't figure out the root cause and I don't have a minimal example.

Setup:

promise = ...fetch(...)
promiseFinally(promise, () => ...)

Now at some point we hit

this._c is undefined

in this line: https://github.com/zloirock/core-js/blob/0bb657cfc7834d03fd68c48a1cba70f2ccab20c0/modules/es6.promise.js#L212

this is window when the error happens, which is obviously wrong. So something seems to be wrongly bound there.

I'm not even sure this is an issue with this library, but it goes away when I switch to es6-promise.

I don't have many details because I don't have iDevices but a teammate had to remove the polyfill because it's crashing on iOS 10.3

on iOS 10.2 this doesn't happen and the polyfill works without any issues

Our experience is that the returned Promise from fetch on Firefox is not polyfilled with finally. This works on Chrome and other browsers.

It be nice if the npm package ships with a single file that needs to be included to polyfill finally globally in the browser.

We get
SCRIPT5007: Unable to get property 'configurable' of undefined or null reference
on line
if (Object.getOwnPropertyDescriptor && Object.getOwnPropertyDescriptor(promiseFinally, 'name').configurable)

We are using Profile polyfill from https://github.com/zloirock/core-js

The dependency es-abstract was updated from 1.17.0-next.1 to 1.17.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

es-abstract is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

🚨 You need to enable Continuous Integration on Greenkeeper branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet.
We recommend using:

• CircleCI
• Travis CI
• Buildkite
• CodeShip
• Azure Pipelines
• TeamCity
• Buddy
• AppVeyor
  But Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please click the 'fix repo' button on account.greenkeeper.io.

The implementation tests, and the index tests in node < 10, both fail these tests.

When using this code in my project:

import promiseFinally from 'promise.prototype.finally';
promiseFinally.shim();

I will see this warning in Chrome 67.0.3396.87 console:
index.js:51 [Deprecation] Application Cache is deprecated in non-secure contexts, and will be restricted to secure contexts in M69, around September 2018. Please consider migrating your application to HTTPS, and eventually shifting over to Service Workers. See https://goo.gl/rStTGz for more details.

Hello, I have this error .fetch(...).then(...).finally is not a function, in firefox (latest version) only. If I remove all .finally(() => { }); functions for the app it works, also if I run it with webpack dev server works, but in production or with webpack dev server with the -p flag it doesn't work anymore.

I'm using 2.0.1 version, but I tried the latest 3.0.1 too and same, didn't do nothing. Any ideas?