erwah / scimproxy Goto Github PK

There're some issues I found in scim compliance tests:
1. Run "PUT User XML", test will throw exception:
to_server: "java.lang.RuntimeException: Type missmatch expected 
'java.util.Calendar' but Received 'java.util.GregorianCalendar' at 
info.simplecloud.core.handlers.HandlerHelper.typeCheck(HandlerHelper.java:25) 
at 
info.simplecloud.core.handlers.CalendarHandler.encodeXml(CalendarHandler.java:40
) at 
info.simplecloud.core.handlers.ComplexHandler.encodeXml(ComplexHandler.java:152)
 at 
info.simplecloud.core.handlers.ComplexHandler.encodeXml(ComplexHandler.java:152)
 at 
info.simplecloud.core.coding.encode.XmlEncoder.internalEncode(XmlEncoder.java:11
3) at info.simplecloud.core.coding.encode.XmlEncoder.encode(XmlEncoder.java:35) 
at info.simplecloud.core.Resource.getResource(Resource.java:91) at 
info.simplecloud.core.User.getUser(User.java:83) at 
info.simplecloud.scimproxy.compliance.test.PutTest.putUser(PutTest.java:121) at 
info.simplecloud.scimproxy.compliance.test.PutTest.run(PutTest.java:41) at 
info.simplecloud.scimproxy.compliance.Compliance.runTests(Compliance.java:103) 
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at ...

In our case, I don't support XML, so I fix the issue by calling put() for "PUT 
user" tests (same behavior as PUT group). see attached patch.

2. The photos attribute of test data (user_full.json) doesn't indicate the URL 
points to a valid photo. In SCIM Core Schema 
(http://www.simplecloud.info/specs/draft-scim-core-schema-01.html), it 
mentioned that the URL must point to a valid photo: "URL of a photo of the 
User. The value SHOULD be a canonicalized URL, and MUST point to an image file 
(e.g. a GIF, JPEG, or PNG image file) rather than to a web page containing an 
image." So, I expected the URL of the photo should contain file extension like 
.jpg. Otherwise, my API backend can only accept any URL passed as Photos 
attribute, this may not conform to the SCIM Core Schema.

3. The ETag used in PUT tests are retrieved from Meta->Version but this 
meta->version is an optional field according to SCIM Core Schema. In my case, I 
didn't pass ETag as meta->version, instead, I pass it in header. So I modified 
the test a little bit to get ETag before making the PUT request if 
meta->version doesn't exist. See attached patch.

4. Sorting in XML is still running even I claim XML is not supported in 
ServiceProviderConfig. The cause is the case sensitive comparison of "XML" in 
code. See attached patch for fix.

Please review the attached patch and deployed to http://www.simplecloud.info/ 
for its SCIM compliance test if it's ok to you.

What steps will reproduce the problem?
1. Try to decode Json with extension
2. Extension values are never populated

The issue is the wrong var is being used to access the extension json at line 
68:

Object value = userJson.get(metaData.getName());

should be:

Object value = extensionJson.get(metaData.getName());

What steps will reproduce the problem?
1.  Follow http://code.google.com/p/scimproxy/wiki/GettingStarted
2.  run ' mvn compile test jetty:run'
3.

What is the expected output? 

Expected output is that Jetty runs

What do you see instead?

Failed tests: 
  getUserSchema(info.simplecloud.scimproxy.ScimSchemaServletGetTest): expected:<200> but was:<500>
  getGroupSchema(info.simplecloud.scimproxy.ScimSchemaServletGetTest): expected:<200> but was:<500>
  getUserSchemasJson(info.simplecloud.scimproxy.ScimSchemaServletGetTest): expected:<200> but was:<500>
  getUserSchemasXml(info.simplecloud.scimproxy.ScimSchemaServletGetTest): expected:<501> but was:<500>
  getSchemas(info.simplecloud.scimproxy.ScimSchemasServletGetTest): expected:<200> but was:<500>
  getSchemasJson(info.simplecloud.scimproxy.ScimSchemasServletGetTest): expected:<200> but was:<500>
  getSchemasXml(info.simplecloud.scimproxy.ScimSchemasServletGetTest): expected:<501> but was:<500>
  getConf(info.simplecloud.scimproxy.ScimServiceProviderConfigServletGetTest): expected:<200> but was:<500>
  postUser(info.simplecloud.scimproxy.ScimUserServletBulkUserTest): expected:<200> but was:<500>
  putUser(info.simplecloud.scimproxy.ScimUserServletBulkUserTest): expected:<200> but was:<500>
  patchUser(info.simplecloud.scimproxy.ScimUserServletBulkUserTest): expected:<200> but was:<500>
  deleteUser(info.simplecloud.scimproxy.ScimUserServletBulkUserTest): expected:<200> but was:<500>
  createUserJson(info.simplecloud.scimproxy.ScimUserServletPostTest): expected:<201> but was:<500>
  createUserXml(info.simplecloud.scimproxy.ScimUserServletPostTest): expected:<201> but was:<500>

Tests in error: 
  info.simplecloud.scimproxy.ScimGroupServletDeleteTest: Failed to parse user
  info.simplecloud.scimproxy.ScimGroupServletGetTest: Failed to parse user
  createGroupJson(info.simplecloud.scimproxy.ScimGroupServletPostTest): Failed to parse user
  createGroupJsonEmpty(info.simplecloud.scimproxy.ScimGroupServletPostTest): Failed to parse user
  createGroupJson2(info.simplecloud.scimproxy.ScimGroupServletPostTest): Failed to parse user
  createGroupJson3(info.simplecloud.scimproxy.ScimGroupServletPostTest): Failed to parse user
  createGroupJson4(info.simplecloud.scimproxy.ScimGroupServletPostTest): Failed to parse user
  createGroupXml(info.simplecloud.scimproxy.ScimGroupServletPostTest): Internal error, decoding xml
  createGroupXml2(info.simplecloud.scimproxy.ScimGroupServletPostTest): Internal error, decoding xml
  createGroupXml3(info.simplecloud.scimproxy.ScimGroupServletPostTest): Internal error, decoding xml
  info.simplecloud.scimproxy.ScimGroupServletPutTest: Failed to parse user
  info.simplecloud.scimproxy.ScimGroupServletSearchTest: Failed to parse user
  info.simplecloud.scimproxy.ScimUserServletAuthTest: Failed to parse user
  info.simplecloud.scimproxy.ScimUserServletDeleteTest: Failed to parse user
  info.simplecloud.scimproxy.ScimUserServletGetTest: Failed to parse user
  info.simplecloud.scimproxy.ScimUserServletPasswordPatchTest: Failed to parse user
  info.simplecloud.scimproxy.ScimUserServletPatchTest: Failed to parse user
  info.simplecloud.scimproxy.ScimUserServletPutTest: Failed to parse user
  info.simplecloud.scimproxy.ScimUsersServletTest: Failed to parse user

Tests run: 33, Failures: 14, Errors: 19, Skipped: 0


What version of the product are you using? 

svn checkout from trunk Sept 18th

On what operating system?

Mac OS X, Java 6, Maven3


Please provide any additional information below.

I am getting error when running mvn compile test jetty:run : 

1. After doing mvn install in scimcore directory, I tried to cd to 
scimproxy\scimproxy. The directory does not exist.
2. I tried running mvn compile test jetty:run in scimproxy directory : I get 
the following exception : 


[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ scimproxy ---
[INFO] Compiling 67 source files to 
C:\Software\SCIM\SCIMProxy\trunk\scimproxy\target\classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\com\sun\jersey\jersey-server\1.8\jersey-server
-1.8.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\com\sun\jersey\jersey-core\1.8\jersey-core-1.8
.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\commons-lang\commons-lang\2.2\commons-lang-2.2
.jar; invalid CEN header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\commons-validator\commons-validator\1.4.0\comm
ons-validator-1.4.0.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\commons-beanutils\commons-beanutils\1.8.3\comm
ons-beanutils-1.8.3.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\commons-digester\commons-digester\1.8\commons-
digester-1.8.jar; invalid CEN header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\commons-configuration\commons-configuration\1.
6\commons-configuration-1.6.jar; invalid CEN header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\commons-beanutils\commons-beanutils-core\1.8.0
\commons-beanutils-core-1.8.0.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\org\mortbay\jetty\jetty\7.0.0.pre5\jetty-7.0.0
.pre5.jar; invalid CEN header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\org\mortbay\jetty\servlet-api\3.0.pre4\servlet
-api-3.0.pre4.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\commons-io\commons-io\2.0.1\commons-io-2.0.1.j
ar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\com\sun\jersey\jersey-json\1.8\jersey-json-1.8
.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\com\sun\xml\bind\jaxb-impl\2.2.3-1\jaxb-impl-2
.2.3-1.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\org\codehaus\jackson\jackson-core-asl\1.7.1\ja
ckson-core-asl-1.7.1.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\org\codehaus\jackson\jackson-mapper-asl\1.7.1\
jackson-mapper-asl-1.7.1.jar; invalid CEN header (bad signature)
[INFO] 15 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.844s
[INFO] Finished at: Mon Oct 22 14:58:55 IST 2012
[INFO] Final Memory: 5M/77M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) 
on project scimproxy: Compilation failure: Compilation failure:
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\com\sun\jersey\jersey-server\1.8\jersey-server
-1.8.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\com\sun\jersey\jersey-core\1.8\jersey-core-1.8
.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\commons-lang\commons-lang\2.2\commons-lang-2.2
.jar; invalid CEN header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\commons-validator\commons-validator\1.4.0\comm
ons-validator-1.4.0.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\commons-beanutils\commons-beanutils\1.8.3\comm
ons-beanutils-1.8.3.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\commons-digester\commons-digester\1.8\commons-
digester-1.8.jar; invalid CEN header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\commons-configuration\commons-configuration\1.
6\commons-configuration-1.6.jar; invalid CEN header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\commons-beanutils\commons-beanutils-core\1.8.0
\commons-beanutils-core-1.8.0.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\org\mortbay\jetty\jetty\7.0.0.pre5\jetty-7.0.0
.pre5.jar; invalid CEN header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\org\mortbay\jetty\servlet-api\3.0.pre4\servlet
-api-3.0.pre4.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\commons-io\commons-io\2.0.1\commons-io-2.0.1.j
ar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\com\sun\jersey\jersey-json\1.8\jersey-json-1.8
.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\com\sun\xml\bind\jaxb-impl\2.2.3-1\jaxb-impl-2
.2.3-1.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\org\codehaus\jackson\jackson-core-asl\1.7.1\ja
ckson-core-asl-1.7.1.jar; invalid LOC header (bad signature)
[ERROR] error: error reading 
C:\Users\chaitrali\.m2\repository\org\codehaus\jackson\jackson-mapper-asl\1.7.1\
jackson-mapper-asl-1.7.1.jar; invalid CEN header (bad signature)