Comments (2)
Hello,
I assume that you mean main classes, which you receive from GetAnime()
nad GetManga()
methods.
The idea is not bad, but I think it would need a little adjustements. The models are a bit different - for example, the Manga model does not contain property Studios, and the Anime model has Author property. Both are also prone to changes due to modification done by MAL and Jikan author. You can make a lot of interfaces with common properties, and the may be incompatible on next REST API update.
What I find justified, is to create interface for items with MalId (IMalEntityWithId
?), representing entities which has their own separate page on MAL (so it would be Anime, Manga, Characters, People, Genres, Magazines and Producers; would be also users if the MalId was placed on the profile). I think it would satisfy your needs. I have to update library version on 1st or 2nd January due to changes in REST API endpoint, so I guess it can be enclosed on next release.
The best solution, in fact, would be cloning this repository (or forking and then cloning), adding it to your main project, creating an interface of your need and making Anime and Manga classes implement this interface. You would have complete control over interfaces and common properties.
from jikan.net.
Hi,
In new version (1.2) both Manga and Anime (and few other classes) share IMalEntity
interface which allow you to reference to items by MalId
. Documentation should be updated in the near future.
from jikan.net.
Related Issues (20)
- [Proposal] Add new constructor to Jikan class HOT 2
- GetSeason returning JikanValidationException for year bigger than current year HOT 3
- Kanjiname returns null HOT 3
- [Proposal] Make argument check on enums to make sure they are valid before making HTTP request HOT 4
- Error Handling for Get Methods HOT 2
- version 1.6.0 change notes? HOT 2
- The server responded with error 400: BadRequest HOT 2
- GetPerson request failed HOT 5
- Exception while trying to get user's manga/anime list HOT 3
- GetCharacterFull seems to be missing HOT 2
- Injectable HttpClient for the HttpClientFactory pattern HOT 3
- the current way to use titles is marked as deprecated HOT 2
- Retrieving next page from GetUpcomingSeasonAsync HOT 2
- GetScheduleAsync exception HOT 12
- GetSeasonAsync doesn't have page param HOT 7
- GetSeason needs params - current season? HOT 2
- JikanApiError is not being deserialized correctly HOT 3
- Response deserialization failing silently
- Review Model not valid (v4) HOT 2
- Review DTO Changes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jikan.net.