[Proposal] Make argument check on enums to make sure they are valid before making HTTP request about jikan.net HOT 4 CLOSED

There's always someone who will think of a scenario you won't :)

I agree that adding such validation method is a good idea, even if it's statistically much less probable than passing wrong string or int value. You can either make a PR for that (and I will review and merge, then release a new version alongside another fix you have made for SearchManga method) or you can a wait a bit and I'll do it myself (most likely in 2 weeks, being quite busy for now).

As for execution time, it will be a miniscule - likely 1-5 added miliseconds, when fetching http response from Jikan is 150-200 ms for cached values, around 700-1200 ms for non-cached. IMO it's worth it.

from jikan.net.

I'll make a PR

from jikan.net.

Both changes were included in nuget 1.5.6, which should be visible shortly.

from jikan.net.

Nice, thanks!

from jikan.net.