Git Product home page Git Product logo

Comments (7)

Ervie avatar Ervie commented on July 29, 2024 1

Hello! Thanks for notification, it is indeed linked to some changes on MAL side. It is two separate things:

  • Advanced search now always returns only one page. You can go on MAL and try to use advanced anime/manga search in any combination (series, rating, score, genre etc.) - what you choose does not matter, if you're still using advanced search.
  • For basic search, paging changed a bit - this will require fix building an url. No matter wich page you choose, it might return same records.

For second issue I will apply a fix tomorrow and will release a new version. For former, probably I will have to remove two methods:

  • SearchAnime(string query, int page, AnimeSearchConfig config)
  • SearchManga(string query, int page, MangaSearchConfig config)

Because they serve no purpose after MAL changes...

from jikan.net.

seanbreckenridge avatar seanbreckenridge commented on July 29, 2024

fyi, we've been discussing this in the #jikan-api channel in the discord

from jikan.net.

Ervie avatar Ervie commented on July 29, 2024

Ok, will look into the thread

from jikan.net.

Ervie avatar Ervie commented on July 29, 2024

Ok, it turned out that advanced search support pagination, but only without search phrase... Weird choice by MAL. Beside fixing pagination for basic search, I removed afromentioned two methods, but added four new:

  • SearchAnime(AnimeSearchConfig searchConfig
  • SearchAnime(AnimeSearchConfig searchConfig, int page)
  • SearchManga(MangaSearchConfig searchConfig)
  • SearchManga(MangaSearchConfig searchConfig, int page)

All of them are basically advanced search, but without search phrase. Removed methods might come back in the future, but MAL have to return pagination to search phrase with advanced filters 🤷‍♂️
Changes are implemented in the version 1.3.3, should be visible soon on the nuget. I added information in the Readme and changelog, wiki will be updated later.

from jikan.net.

JaoHundred avatar JaoHundred commented on July 29, 2024

I've checked out the discussion in Discord, really odd choices from MAL. Let's hope it's temporary. Anyway, thanks for the new version!

from jikan.net.

seanbreckenridge avatar seanbreckenridge commented on July 29, 2024

Was reported to the MAL team and they're looking into it; seems to be a bug.

from jikan.net.

Ervie avatar Ervie commented on July 29, 2024

For now I will be closing this issue, when the MAL fix we can return to this topic

from jikan.net.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.