ernicommunity / erni-photo-database Goto Github PK

Ideally integrate with Active Directory through OpenID Connect.

Please do not commit any ERNI specific setting to repository.

We used to have db connection string stored using user secrets (README still says we do), but in current implementation it is read from config.
Is it a temporary solution/workaround? Whats the story behind the change?

Related to #11 - we should not store any sensitive data (connection strings, API keys etc.) in the repo. Instead, let's move everything into ASP.NET Core's user secrets manager.

This will require us to reconfigure the deployment environment as well (add system vars with prod secrets).

we should stick to EF naming conventions in model:

• use plural for table names

  ERNI-Photo-Database/server/ERNI.PhotoDatabase.DataAccess/EntityConfiguration/TagConfiguration.cs

  Line 11 in 9ba85f1

  builder.ToTable("Tag");

• use plural for collection navigation properties

  ERNI-Photo-Database/server/ERNI.PhotoDatabase.DataAccess/DomainModel/Photo.cs

  Line 16 in 9ba85f1

  public List<PhotoTag> PhotoTag { get; set; }

Keep image ratio on the thumbnails, so the orientation is obvious to the user

On detail view you should have a option to download picture in sizes:

• Original size
• max(width, height) = 1920
• max(width, height) = 720
• max(width, height) = 340

Aspect ratio should be always preserved.

Since preferred sizes are likely to change in the future do resizing on the fly.

Please preserve the original format picture extension (.jpg, jpeg, .png, ...)

When someone clone the project and hit F5 in Visual Studio, application will crash on some exception.

The reason is that some dependencies are missing.

Please add proper instructions to README.md

When running in dev mode we always call context.Database.EnsureDeleted(); which drops the database. Whats the motivation behind this? it would be nice to be able to develop with persistance between sessions 😄