Hi, nice work, was so easy to add your code to make installation work, but i have some issue.

After use stardard installation:

dotnet ./MyService.dll install

i saw that topshelf assume that there is a executable called ./MyService.exe, and when service start, an error appears.

Instead of manually ack the install, do u have any workaround ?

how to set RunAs,RunAsLocalSystem...

Hi,
I have found that errors thrown during start up don't cause the host container to be disposed. For my use case this means my error logs from that time don't end up getting flushed. I am using .NET Core 2.2

Example code:

using System;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;
using Topshelf.Extensions.Hosting;

namespace ConsoleApp2
{
    class Program
    {
        static async Task Main(string[] args)
        {
            //await CreateHostBuilder(args).RunConsoleAsync();

            CreateHostBuilder(args).RunAsTopshelfService(s =>
            {
                s.SetServiceName("Name");
                s.SetDisplayName("Name");
            });
        }

        public static IHostBuilder CreateHostBuilder(string[] args)
        {
            return new HostBuilder()
                .ConfigureServices((h, s) => s
                    .AddHostedService<MyService>()
                    .AddSingleton<Service>());
        }
    }

    public class MyService : IHostedService
    {
        private readonly Service _service;

        public MyService(Service service)
        {
            _service = service;
        }

        public Task StartAsync(CancellationToken cancellationToken)
        {
            _service.DoSomething();
            return Task.CompletedTask;
        }

        public Task StopAsync(CancellationToken cancellationToken)
        {
            return Task.CompletedTask;
        }
    }

    public class Service : IDisposable
    {
        public void DoSomething()
        {
            throw new Exception("Break things");
        }

        public void Dispose()
        {
            // Breakpoint here
        }
    }
}

When I use RunAsConsoleAsync the start up error cleans up the container, ultimately hitting the breakpoint in the service dispose. With the RunAsTopShelfService extension this doesn't happen.

Thanks,
Adam

Background information: I initially raised this as a Serilog bug until I identified the container issue through their guidance. serilog/serilog-extensions-hosting#15

Creating a default host builder via this api
var builder = Microsoft.Extensions.Hosting.Host.CreateDefaultBuilder(args)
it does not load appsettings.json settings.

This is due to CreateDefaultBuilder setting the content root to
builder.UseContentRoot(Directory.GetCurrentDirectory());
https://docs.microsoft.com/en-us/aspnet/core/fundamentals/host/generic-host?view=aspnetcore-3.0
and at that time GetCurrentDirectory is c:\windows\system32

Hi Erik,

Thanks for this nice and handy utility!

I have a feature request... I would like the CancellationToken that is passed into the StartAsync and StopAsync methods of the IHostedService to have its IsCancellationRequested property set to true when the service is stopped, so that I can cancel long running jobs and wait for them to finish.
I am more than happy to submit a PR if you like.