erickzanardo / nes_ui Goto Github PK

Description

As a developer, I'd like to use the NesIcons class like I use Icons from Material:

Icons.delete

Currently, I need to use NesIcons.instance to access any icon, I think we can change the NesIcons class and make the icons static rather than a NesIcons instance, so when I use an icon, that'll be:

NesIcons.delete

What do you think?

Requirements

• There is no drop in test coverage.

Description
Currently I have everything in my app wrapped in a NesFixedViewport, so that it fills the whole screen, and makes all the pixels look larger. I have an issue where when I open a NesDialog, it doesn't capture the same resolutionAspectRatio that is set by the NesFixedViewport. The pixels on the NesDialog appear much smaller. I was wondering if there was a way for the NesDialog to inherit the same settings from the NesFixedViewport.

Screenshot below:

Description

NesIconButton onTap does not animate properly on mobile (the button press animation only triggers when the button is held down longer than a regular tap).
This was tested with both an emulated Pixel 3A and a physical S21 FE.
NesButton does not have the same problem (and neither does NesButton.icon).
The same issue exists with the scrolling icons used for NesIterableOptions.

Steps To Reproduce

1. Go to any page with an NesIconButton widget.
2. Tap on the widget.
3. OnTap will trigger, but unless you tap longer than usual the button will not animate.

Expected Behavior

Buttons should always animate.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Description

Currently, we have lightLabelColor and darkLabelColor in NesButtonTheme. However, this only affects the color of text and not the color of an Icon.

const NesButtonTheme({
  // ...
  required this.lightLabelColor,
  required this.darkLabelColor,
});

Requirements

• Set color of Icon widget
• Set colors of NesIcon widget

Example

The play icon should be white (i.e. matching the text) here:

Additional Context

I'm not sure how this would work with NesIcon since it requires both a primary and secondary color. Maybe the primary can be the same as the text color, and the secondary color could be the opposite of the text color (i.e. lightLabelColor vs darkLabelColor).
However, the regular Icon class should be straight forward to set the icon theme.

Description

Clearly describe what you are looking to add. The more context the better.

I'd like to ask if you could add a NesIcons.instance.ad. This could be similar to the gallery/window icon but with a play button inside.
I've just added rewarded ads that let the player continue after dying by watching an ad. Currently, there's not a good NesIcon for this so I'm just using the shield (see the screenshot).

Requirements

• Add an icon for a button that triggers an ad

Additional Context

Add any other context or screenshots about the feature request go here.

Description

Hovering over a button should show the hand/pointer mouse cursor

Steps To Reproduce

1. Hover over on NesButton
2. See mouse arrow instead of pointer