WM8731

A simple HAL for the Cirrus Logic/Wolfson WM8731 audio codec IC.

wm8731's People

Contributors

Stargazers

Watchers

wm8731's Issues

AnalogAudioPath::bypass() should have more descriptive names

Currently it returns an InputSelect, which has .mic() and .line_input(), but that's not what the BYPASS bit means — it should be something like enabled and disabled to match the datasheet:

Function types should be generics, not `fn`-literals

If I do something like (awkward naming aside, that's #1):

    #[test]
    fn bypass_button() {
        let user_hit_the_bypass_button = true;

        let result = WM8731::analog_audio_path(|w| {
            if user_hit_the_bypass_button {
                w.bypass().mic()
            } else {
                w.bypass().line_input()
            }
        });

        assert_eq!(result.address, 4);
        assert_eq!(result.value, 0b0000_1000);
    }

the compile fails because a closure that captures (even immutably!) a variable is not an fn type:

error[E0308]: mismatched types
   --> src/lib.rs:203:48
    |
203 |           let result = WM8731::analog_audio_path(|w| {
    |  ________________________________________________^
204 | |             if user_hit_the_bypass_button {
205 | |                 w.bypass().mic()
206 | |             } else {
207 | |                 w.bypass().line_input()
208 | |             }
209 | |         });
    | |_________^ expected fn pointer, found closure
    |
    = note: expected fn pointer `for<'r> fn(&'r mut AnalogAudioPath)`
                  found closure `[closure@src/lib.rs:203:48: 209:10]`

Since FnOnce is the most-permissive function-ey trait, the canonical signature would be pub fn analog_audio_path<F: FnOnce(&mut AnalogAudioPath)>(c: F) -> Register (and so forth for the remaining functions of the WM8731 impl)

Recommend Projects