epiverse-trace / .github Goto Github PK

I believe there is an issue in the bug report issue template which was caused by 81d80ea. The template no longer appears as an option on other Epiverse packages and there is an error message shown when viewing the file on GitHub.

I don't know when the code of conduct was last revised, but it appears to be out of date given the committee members are not all part of the project anymore.

This issue is to track the known items that need to be revised, and provides a space to discuss what changes may need to be revised as well.

This issue is to discuss purely technical/logistical details regarding the Code of Conduct, as I presume the substantive content is subject to the committee's decisions.

Revision items

These items will be updated based on the discussion.

• Add latest revision date to document
• Where should input for feedback on the CoC go? Anna's email still mentioned
• Review who has access to the Google Form and where this information goes upon submission
• Review Google Form content itself (also mentions committee members no longer present)
• Committee membership
  • Anna Carnegie is no longer at LHSTM - remove
  • Claudine Lim is no longer at data.org - remove
  • Do we add a new committee member for LHSTM?
  • Do we add a new committee member for data.org?
  • Are the remaining committee members still up to date?
• Mentions of "Community Manager" throughout the document may not be relevant anymore as there is no current community manager?
• "You may also make a report directly to one member of the Committee by contacting them directly" - no direct contact information is provided - do we add this? (best practice)

https://github.blog/2023-08-09-four-tips-to-keep-your-github-actions-workflows-secure/#1-dont-use-syntax-in-the-run-section-to-avoid-unexpected-substitution-behavior

Could use:

• https://github.com/herdstat

This issue is to request that R/RcppExports.R should be excluded from linting as part of the lint-changed-files workflow. The current list aims to exclude unchanged files but also overrides the default exclusion of RcppExports.R, which triggers the line length linter.

I first noticed this issue due to a failing workflow in epiverse-trace/epidemics#135. I missed an earlier instance of this issue in epiverse-trace/epidemics#130 as @bahadzie edited R/RcppExports.R to satisfy the linter, and I ignored the file as it's usually auto-generated.

GitHub doesn't implement selection of templates for Pull Requests as for Issues so the current template (as long as it's in a subdirectory) will not be used.

It could be useful to have a generic contributing guide to use as a default for epiverse-trace package that doesn't need / have a more specific contributing guide.

Examples:

• RStudio default contributing guide, and an example of a more specific contributing guide overwriting it.

The herdstat workflow is failing because the main branch recently got protected (I think, cc @Bisaloo). It worked before because main was unprotected at that time.

I will shortly submit a pull request that updates the workflow to create a pull request to update the contribution graph instead. This helps circumvent the branch protection without having to remove it (because it's there for good reason).

While reviewing this repo, I noticed the code of conduct links out to two Google Docs, which are not tracked in this repository directly.

Might it be an idea to directly include the code of conduct in the repo as a markdown file? I'd be happy to port it over if we want this.

My arguments for moving it over:

• Reduce amounts of clicks needed to access the relevant content
• Version-control of document history (including revisions)
• It will be a great time to also review the contents as they're still denoting Anna and Claudine

Would be interested to hear your thoughts @Bisaloo.

I think the issue template is missing an entry for documentation issues - which aren't a "bug" as such or a feature request.

linelist provides generic issue templates we might want to re-use. They are already re-used in epiparameters.

https://github.com/epiverse-trace/linelist/tree/main/.github/ISSUE_TEMPLATE

https://github.com/epiverse-trace/linelist/tree/main/.github/PULL_REQUEST_TEMPLATE