eouw0o83hf / copymasta Goto Github PK

There's a confounding issue to solve regarding passive entry into key combos (let go of a key and boom you're in a combo).

Example, with Chrome as target browser:

1. [C+ ]: No action
2. [CS+ ]: No action
3. [CAS+ ]: No action
4. [CAS+W]: Move current email onto clipboard
5. [CS+W]: (user took finger off of alt but hasn't yet leapt off of the other buttons) Scenario 1
6. user holds this key configuration until the "key held" commands come raining in Scenario 2

Scenario 1
Chrome ignores this key combo, since it was passively entered. Therefore, there's no reason for the ChromeSafetyHelmet to trigger here, since there's no event to cancel.

Scenario 2
Chrome acts on this key combo, since Windows sends in repeated keydown events. I'm pretty sure we do want ChromeSafetyHelmet to fire here, but it's an odd situation since no originating keydown event made it happen.

This issue is to track further thought on those two scenarios.

Somehow, somewhere between CopyMasta and chrome, the KeyDown event for the shift key gets eaten and not passed to CopyMasta.

Reproduction Steps

1. Hit a key combo including ctrl and shift (whether in Chrome or not)
2. In Chrome, try to open a private window (ctrl+shift+n). Doesn't work.
3. Open a new window (ctrl+n).
4. Now try opening a private window and it works.

See #2 for more information/discussion

Need a way (ctrl+alt+shift+f?) to pull an old guid out of the guid handler.