entur / shamash Goto Github PK

Today we support light and dark modes which can be toggled with a button in the menu. See pic:

We should also support the cool prefers-color-scheme CSS media feature which detects the user's theme preference set in the operating system.

Today's theme preference is saved in localStorage. The logic for setting happens on page load in App.js:

let logo
if (window.localStorage.getItem('theme') === 'dark') {
  require('../css/darktheme.css')
  logo = require('../static/img/entur-white.png')
} else {
  logo = require('../static/img/entur.png')
}

The darktheme.css stylesheet is loaded if "dark theme" is set in localStorage. The button for switching theme simply updates localStorage.

I'm not sure what's the best way of implementing this is, but if you would want to have a go at it, feel free! 🎉

The dark mode is nice, but some colors have too low contrast.

1. The comma is black and basically invisible
   
   Do you see the comma between 10 and omitNonBoarding? No? It's there. It should be much lighter.

2. The curly brackets, colon and parenthesis are too dark
   

3. The text in the top menus is too light
   

App.js is a class component using deprecated lifecycle methods (componentWillMount). It would be nice to rewrite it as a function component with React hooks.

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Failed to decrypt field npmToken. Please re-encrypt and try again.

This is a Node.js and React project. Having TypeScript would be very nice.

A pull request would be greatly appreciated, that

• Sets up a proper TypeScript config (tsconfig.js)
• Converts at least one file from .js to .ts (or .tsx) in src/ to prove it works

This project does have a Node.js server, but it has no build (transpilation/compilation) step. Therefore it is sufficient to only consider the React frontend part for now.

The React app is based on Create React App, and therefore the react-scripts package is used for building and running it.

add origin of the name shamash, please? :-)

We should add ESLint in order to ensure basic code quality and consistency. The ESLint config should extend eslint:recommended and recommended rules for React.

Other rules

• indent: 4 spaces
• semicolon: never

Let's also add a script in package.json so we can use npm run lint for running ESLint.

If you click "Search for ID" in the top menu, a wild modal appears. The only way to close this modal is to press the X in the top right of it. It should also be possible to click anywhere outside the modal to close it.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Datasource	Name	Replacement PR?
npm	babel-eslint
npm	subscriptions-transport-ws

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• fix(deps): update dependency @entur/table from v4.8.7 to v4.8.15
• fix(deps): update dependency @pmmmwh/react-refresh-webpack-plugin from v0.5.13 to v0.5.15
• fix(deps): update dependency semver from v7.6.2 to v7.6.3
• fix(deps): update dependency @apollo/client from v3.10.3 to v3.11.4
• fix(deps): update dependency @babel/core from v7.24.5 to v7.25.2
• fix(deps): update dependency eslint-plugin-jsx-a11y from v6.8.0 to v6.9.0
• fix(deps): update dependency eslint-plugin-react from v7.34.1 to v7.35.0
• fix(deps): update dependency graphql from v15.8.0 to v15.9.0
• fix(deps): update dependency eslint-webpack-plugin from v2.7.0 to v4
• fix(deps): update dependency fs-extra from v9.1.0 to v11
• fix(deps): update dependency graphiql from v1.11.5 to v3
• fix(deps): update dependency graphql from v15.8.0 to v16
• fix(deps): update dependency history from v4.10.1 to v5
• fix(deps): update dependency html-webpack-plugin from v4.5.2 to v5
• fix(deps): update dependency husky from v3.1.0 to v9
• fix(deps): update dependency isomorphic-fetch from v2.2.1 to v3
• fix(deps): update dependency jest-watch-typeahead from v0.6.5 to v2
• fix(deps): update dependency lint-staged from v9.5.0 to v15
• fix(deps): update dependency mini-css-extract-plugin from v0.12.0 to v2
• fix(deps): update dependency optimize-css-assets-webpack-plugin from v5.0.8 to v6
• fix(deps): update dependency postcss-flexbugs-fixes from v4.2.1 to v5
• fix(deps): update dependency postcss-loader from v3.0.0 to v8
• fix(deps): update dependency postcss-normalize from v8.0.1 to v10
• fix(deps): update dependency postcss-preset-env from v6.7.2 to v10
• fix(deps): update dependency postcss-safe-parser from v5.0.2 to v7
• fix(deps): update dependency query-string from v6.14.1 to v9
• fix(deps): update dependency react-app-polyfill from v2.0.0 to v3
• fix(deps): update dependency react-dev-utils from v11.0.4 to v12
• fix(deps): update dependency react-helmet from v5.2.1 to v6
• fix(deps): update dependency react-leaflet from v3.2.5 to v4
• fix(deps): update dependency resolve-url-loader from v3.1.5 to v5
• fix(deps): update dependency sass-loader from v10.5.2 to v16
• fix(deps): update dependency style-loader from v1.3.0 to v4
• fix(deps): update dependency terser-webpack-plugin from v4.2.3 to v5
• fix(deps): update dependency uuid from v3.4.0 to v10
• fix(deps): update dependency webpack from v4.47.0 to v5
• fix(deps): update dependency webpack-dev-server from v3.11.3 to v5
• fix(deps): update dependency webpack-manifest-plugin from v2.2.0 to v5
• fix(deps): update dependency workbox-webpack-plugin from v5.1.4 to v7
• fix(deps): update jest monorepo from v26.6.3 to v29 (major) (babel-jest, jest, jest-circus, jest-resolve)
• fix(deps): update react monorepo from v16.14.0 to v18 (major) (react, react-dom, react-test-renderer)
• fix(deps): update testing-library monorepo (major) (@testing-library/jest-dom, @testing-library/react, @testing-library/user-event)
• fix(deps): update turf monorepo from v6.5.0 to v7 (major) (@turf/bbox, @turf/helpers, @turf/line-to-polygon)
• fix(deps): update typescript-eslint monorepo from v4.33.0 to v8 (major) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): replace dependency babel-eslint with @babel/eslint-parser 7.11.0
• chore(deps): update actions/cache action from vv3 to v4
• chore(deps): update actions/checkout action from vv3 to v4
• chore(deps): update actions/setup-node action from vv3 to v4
• chore(deps): update dependency eslint-plugin-prettier from v3.4.1 to v5
• chore(deps): update dependency prettier from v2.8.8 to v3
• chore(deps): update github artifact actions from vv3 to v4 (major) (actions/download-artifact, actions/upload-artifact)
• fix(deps): update dependency @svgr/webpack from v5.5.0 to v8
• fix(deps): update dependency babel-loader from v8.3.0 to v9
• fix(deps): update dependency bfj from v7.1.0 to v8
• fix(deps): update dependency camelcase from v6.3.0 to v8
• fix(deps): update dependency css-loader from v4.3.0 to v7
• fix(deps): update dependency dotenv from v8.6.0 to v16
• fix(deps): update dependency dotenv-expand from v5.1.0 to v11
• fix(deps): update dependency eslint from v7.32.0 to v9
• fix(deps): update dependency eslint-config-react-app from v6.0.0 to v7
• fix(deps): update dependency eslint-plugin-flowtype from v5.10.0 to v8
• fix(deps): update dependency eslint-plugin-jest from v24.7.0 to v28
• fix(deps): update dependency eslint-plugin-testing-library from v3.10.2 to v6
• fix(deps): update entur packages (major) (@entur/form, @entur/icons, @entur/sdk)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

I highly doubt this is the exact right repo for this (more likely in the openjourneyplanner or just the underlying docs depending on your perspective), but in the docs in the sidebar in shamash one can read the following :

transportModes: [TransportModes]

The allowed modes for the transit part of the trip. Use an empty list to disallow transit for this search. If the element is not present or null, it will default to all transport modes.

If attempting the following query:

{
  trip(
    from: {
      name: "Bjerkealleen 5A, Skedsmo"
      coordinates: {
        latitude: 59.96050414081307
        longitude:11.040338686322317
      }
    }
    to: {
      place:"NSR:StopPlace:385"
      name:"Alna, Oslo"
    }
    numTripPatterns: 3
    dateTime: "2023-09-25T16:35:26.652807"
    walkSpeed: 1.3
    arriveBy: false
    modes: {
       transportModes: null
    }
  )

#### Requested fields
  {
    tripPatterns {
      expectedStartTime
      duration
      walkDistance
      legs {
        mode
        distance
        line {
          id
          publicCode
        }
      }
    }
  }
}

then i get the following response:

{
  "errors": [
    {
      "message": "Exception while fetching data (/trip) : Cannot invoke \"java.util.List.isEmpty()\" because \"transportModes\" is null",
      "locations": [
        {
          "line": 20,
          "column": 3
        }
      ],
      "path": [
        "trip"
      ],
      "extensions": {
        "classification": "DataFetchingException"
      }
    }
  ],
  "data": null
}

If you click "Search for ID" a modal opens. This modal has only light theme support. It should also have a dark theme.

The exact colors are not important. We don't follow a strict color palette (yet). Just pick some dark colors for the background and light colors for the foreground. :D