ent8r / notesreview Goto Github PK
View Code? Open in Web Editor NEW📝 Interface for searching and resolving OpenStreetMap notes
Home Page: https://ent8r.github.io/NotesReview/
License: GNU General Public License v3.0
📝 Interface for searching and resolving OpenStreetMap notes
Home Page: https://ent8r.github.io/NotesReview/
License: GNU General Public License v3.0
The UI for the query field does not provide any help of the syntax expected nor the help, so I don't know what this field expects.
For example here https://www.openstreetmap.org/note/1842026 I first couldn't figure out how to fully see the buttons below (it works by panning the map). Instead it would be more intuitive to shrink the container for the note to the browser height and be able to scroll.
It would be very nice to be able to sort notes by date. This would also be very helpful if you could use a bbox instead of a search query (or both) since you might want to go through all notes in a certain area.
Currently one has to go to GitHub to find the expert mode. That is not really a good usability.
So maybe add a button in the UI or so?
IMHO when the "Closed quests" checkbox is selected, you should show open quests in green and closed ones in red, just like it is done on OSM.org. So one can e.g. compare how many notes are already solved in an area and how many still need to be resolved.
Permalinks like https://ent8r.github.io/NotesReview/?query=StreetComplete&limit=300 are quite useful.
Is it possible to add "create permalink to this query" and "create permalink to this query, execute search on loading page" options? Similar to what overpass-turbo offers?
Or is downloading 3000 notes OK and not overloading OSM API?
STR:
What happens: No search query in the box anymore.
What should happen: keep search query.
Firefox 61.0
Try the following:
Reproducible??
Is this intended?
I would like to keep geographic bounding box when altering the search/sort parameters in list view.
The display is fine in NotesReview 😺
It could be nice to add also the note ID in the URL, and load and display automatically this note 😃
https://ent8r.github.io/NotesReview/expert/?note=2152730
https://ent8r.github.io/NotesReview/?note=2152730
I stopped working with the latest update. The search button does nothing.
Hi,
take for example this note with 7 comments, 4 of which are from me: https://www.openstreetmap.org/note/1837314
If I search for user "Luzandro" in the list view, the note gets shown 4 times and for each of them every single comment (including comments from everyone else and original note text) gets shown 4 times as well leading to 31 comments
I am trying to emulate the query, which StreetComplete uses to fetch the notes, respectively to display them, when the setting "Show all notes" is not enabled, i.e. when it only shows notes with a question mark (?) in it.
So I enter ?
in the search box. For some reason, this does only work in the fast (high zoom level) mode, not in the worldwide query. (I get the message that no notes are found then.)
BTW why did you remove the fast icon for high zoom levels? It was very helpful to see, when a fast query can be made.
Originally mentioned in #15, I see the issue that the fast icon (the flash) is not shown.
When the width is around 1200px or below it just seems to hide that flash. Even on the desktop the window can be so small at some times.
To process a note in JOSM or iD one has to click on "note xxx on OSM" and then on the edit button on osm.org. It would be nice to have a direct link to JOSM and iD in the note popup as have most other QA tools.
As search for "camera" brings back this note which doesn't seems to have anything relevant.
https://www.openstreetmap.org/note/2083046#map=19/43.29558/5.37851
Is that expected?
Continuing #21 (comment)
Yes, all notes are fetched again because the expert (list) mode is a completely different page and there is no backend where the notes could be saved temporarily...
Okay, but what about saving/"caching" them locally? Either just in the JS code (in an object/array/map/set – likely a set would be quite suitable) or some things like local storage, although the last is not really needed, as the storage does not have to be persistent between sessions.
When clicking on the down arrow of this control, negative values could be set 😜
As it seems it always searches worldwide. It should, however, only search in the area I am currently looking at (on the map) as this is only what I am interested at.
This can dramatically increase the speed of the query (I hope).
If possible, could we have a way to search (or filter) for notes:
Thanks
Whether using the flash search or the normal search.
When I search for "caméra" or "camera" I get different results.
For example here: https://ent8r.github.io/NotesReview/?query=cam%C3%A9ra&map=16%2F43.2972%2F5.3814
The application doesn't work with the Internet Explorer (all versions), instead of the map being displayed there is just a white screen which might confuse users.
It would probably be useful to show a small hint to encourage Internet Explorer users to switch the browser...
So you don't accidentally try to process your own notes… 😜
At some point, adding a comment to a note and clicking the comment button didn't result in any visible feedback, i.e. the dialog window just continued to be visibly unmodified. Apparently, when opening another note after that, the comment button worked but applied the comment (and comment close) to the original note.
I'm 100% sure on the first click not having worked, less than 100% on the exact sequence of interaction on the 2nd issue. Is there some playground/test env where I could try to repro without having to create test/dummy notes in the live OSM db?
As I said in this PR that change does pass the turkey test.
See http://www.moserware.com/2008/02/does-your-code-pass-turkey-test.html for a whole article on it.
So I just wanted to open this issue to track this problem.
Maybe someone can try it out in turkey. 😄
${date.toLocaleDateString()}
?May be more?
Quick (and dirty) answer :
npm install
#edit the source files…
npm build
npm start
Something like https://github.com/threepointone/glamor/blob/master/CONTRIBUTING.md
So nice and useful to display images embedded in notes 🌞
Some examples.
Of course it could be a text query 😄
But could be fine to reuse the result of:
function isImage(url)
… and have a simple checkbox 😄
As it can also be seen on #6 (comment), Firefox 57 always shows me in the dev console some images (tiis) would be corrupted.
I see no corrupted tiles on the website, but it's better to get rid of this annoying error message…
Can it be this has a littler bias (:wink:) and favors recently created notes? In the list view, you only rarely see some older than 1 day and only hardly > 14 days.
opened app without changing settings, used first auto-search result
Seeing you moved the input to the sidebar, I have one problem (although I visually generally like it):
However, I see a good solution:
Having everything in one view makes it user-friendlier and would also solve #22.
Of course the views should be "merged" in a way, that interaction makes sense, i.e. e.g.:
typical person will be unable to find it
see http://nrenner.github.io/achavi/ (link via about in footer) http://overpass-turbo.eu/ (link via help -> about in header) for an examples how it may be done
From #19 (comment):
There are now different badges with different colors for different ages of the notes.
Maybe you can color the note markers directly in the same way?
Using the "to" date in the search function is useful for finding old notes (i.e. set to 1/1/2014 or similar) - however some of these notes have been commented on so they're not really old anymore.
Would it be possible to have an option to use the last commented date in when searching?
The new cancel button looks nice, but I think it introduced this issue:
webm file: jump.zip
As you can see, the height of the header is modified when the search happens. This is a visual annoyance.
In terms of finding notes that no-one has considered or looked at yet, I think it would be really useful to be able to show only notes that have no comments after the initial creation. This could be used to help keen mappers triage notes, working on both old and neglected ones and new ones as they come in. This could be implemented in the user interface with a "Show only notes without comments" checkbox.
The notes review tool does not work anymore with the browser Waterfox, a fork of an older Firefox LTS version. It used to work before the complete rewrite.
in list mode text is displayed so it should be possible
PS Thanks, it is quite useful. I already went through several notes that would be bizarre for somebody unaware about StreetComplete. In some cases SC would seem like spam-note generation tool.
I'd be nice if I can cancel the search…
This way one may review just new notes, without rechecking old ones
Hello,
Map doesn't load, because there is some JS error :
Error: Set map center and zoom first. leaflet.js:5:40277
_checkIfLoaded https://unpkg.com/[email protected]/dist/leaflet.js:5
getCenter https://unpkg.com/[email protected]/dist/leaflet.js:5
value https://ent8r.github.io/NotesReview/dist/js/main.min.js:1
e https://ent8r.github.io/NotesReview/dist/js/main.min.js:1
receiveMessage resource:///actors/BrowserTabChild.jsm:98
wrapHandlingUserInput resource://gre/modules/E10SUtils.jsm:893
receiveMessage resource:///actors/BrowserTabChild.jsm:95
Can be reproduced by clicking on "Show on a map", happens in Chromium or Firefox (latest version) under Arch Linux.
Best regards.
Checking/Unchecking 'Hide anonymous notes' causes the map to zoom in/out respectively*. Is this expected behaviour?
In = 3 zoom factors
Out = zoom to almost world extents
Using Firefox latest on Win7
What about loading notes after 100 notes are received and display them on the map, then do another query and load the next ones, and so on…
The advantage would be that the user can see them "popping up" on the map, i.e. the user sees there is some real progress.
Preferably, the user could also cancel the process (if they see it takes too long, i.e. the chosen limit was a bit too high) and still see all notes, which were already fetched. So one can just start the query and end it when one thinks there are enough notes, now. 😃
When a start is given only notes that have been created after this date should be displayed. However, notes that are displayed with a read or yellow icon an that are older than the start date are shown on the map.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.