Since we are not actively using (or deploying) Zend Server anymore ourselves, we might want to consider changing the default stack for the Basebox over to vanilla+nginx rather than zendserver+nginx. Now, many projects need to override this again since vanilla is preferred.

Additionally, we'll probably want to ship the basebox with PHP7 by default as well?

If the vhosting pillar is not configured the core.after file fails and salt does not run.

When I have this setup:

pillars/default/phpfpm.sls

phpfpm:
  php_versions:
    - '7.0'

pillars/defaults/vhosting.sls

vhosting:
  server:
    webserver: nginx
    webserver_edition: vanilla

I get the following error:

The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

salt-call state.highstate --retcode-passthrough  --log-level=info --force-color

Stdout from the command:

local:
    Data failed to compile:
----------
    Cannot extend ID 'php5-fpm' in 'base:vhosting.base'. It is not part of the high state.
This is likely due to a missing include statement or an incorrectly typed ID.
Ensure that a state with an ID of 'php5-fpm' is available
in environment 'base' and to SLS 'vhosting.base'

Any ideas? Let me know if I need to supply more information.
Note: This is pretty much all I have, the rest is pretty standard.

When using webserver_edition: vanilla it tries to install composer but php5-cli isn't installed so it fails.

In order to aid the ease of development we'll probably want to add the following state to the basebox in case the box is based on Ubuntu/Debian:

/home/vagrant/.my.cnf:
  file.symlink:
    - source: /etc/mysql/debian.cnf

This allows people to use mysql commands on the commandline without needing to authenticate.

Generally, projects using the Basebox seem to be overriding the file state to create the web-folder and replacing it with a symlink to /vagrant like so:

# Overwrite the docroot symlink of the app
extend:
  /srv/http/project/hosts/example.com:
    file.symlink:
      - target: /vagrant
      - user: vagrant
      - group: vagrant
      - require:
        - file: /srv/http/project/hosts
      - watch_in:
        - service: nginx

We'll probably want to add something like this to the basebox by default?

nginx: [emerg] could not build the server_names_hash, you should increase server_names_hash_bucket_size: 32

Sorry for putting it here, I can open a jira ticket later it was just for fast forwarding